[New features] Primitive types and struct type #5879
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -407,7 +407,7 @@ namespace ts { | |||
| // (ref: https://github.com/nodejs/node/pull/2649 and https://github.com/Microsoft/TypeScript/issues/4643) | |||
| return _fs.watch( | |||
| path, | |||
| { persistent: true, recursive: !!recursive }, | |||
| { persisten: true, recursive: !!recursive }, | |||
|
Hi guys, so glad that you are carefully reviewing this PR! Thanks! We have our proposal in this post: Actually, sending PR is a part of our gradate research project. We know our implementation is indeed immature, and definitely not ready to submit. But all of us are very interested in studying TypeScript and its potential extensions. We will keep doing it isolated for sure. @weswigham many many thanks to your inline comments. Really helpful for our future research. |
| @@ -1210,7 +1231,7 @@ interface ArrayBuffer { | |||
| interface ArrayBufferConstructor { | |||
| prototype: ArrayBuffer; | |||
| new (byteLength: number): ArrayBuffer; | |||
| isView(arg: any): arg is ArrayBufferView; | |||
| isView(arg: any): boolean; | |||
|
The online diff shows a bunch of missing test results that should be there. |
| @@ -79,7 +79,7 @@ tests/cases/compiler/promisePermutations3.ts(159,21): error TS2345: Argument of | |||
| Type '(value: number) => Promise<any>' is not assignable to type '(value: string) => any'. | |||
| Types of parameters 'value' and 'value' are incompatible. | |||
| Type 'number' is not assignable to type 'string'. | |||
| tests/cases/compiler/promisePermutations3.ts(165,21): error TS2345: Argument of type '{ <T>(x: T): IPromise<T>; <T>(x: T, y: T): Promise<T>; }' is not assignable to parameter of type '(value: (x: any) => any) => Promise<any>'. | |||
| tests/cases/compiler/promisePermutations3.ts(165,21): error TS2345: Argument of type '{ <T>(x: T): IPromise<T>; <T>(x: T, y: T): Promise<T>; }' is not assignable to parameter of type '(value: {}) => Promise<any>'. | |||
There was a problem hiding this comment.
This change seems.... wrong. I don't see anything which would intentionally prompt the change.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a part of a graduate project of San Francisco State University.
Project draft:
The growth of the Web has been explosive. As the most important component of the front-end technology stack, JavaScript is always playing a significant role. It’s easy, fast and extendable. However, JavaScript also has its drawbacks, for instance, no static type checking. TypeScript is a strict superset of JavaScript invented by Microsoft. It brings a complete static type checking mechanism and modern object-oriented syntax features.
This project extends the TypeScript compiler and provides more strict and specific primitive types and new Struct syntax. The main goal is to enhance type safety as well as generate more efficient code.
Author: Yanxing Wang, Jie Dong
Supervisor: Dr. Arno Puder