Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable #57896 (Respect package.json "type" and module-format-specific file extensions in more module modes) #58831

Merged
merged 6 commits into from
Jun 12, 2024

Conversation

andrewbranch
Copy link
Member

This disables the behavior changes introduced in #57896, based on feedback in #58663 and #58523 and feedback from @bpasero about effects on VS Code’s file watchers. The hope is to merge this for 5.5 stable, then merge #58825 (pending review), which will reintroduce the behavior in the original PR in a more limited way, at the beginning of the 5.6 period.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jun 11, 2024
@andrewbranch
Copy link
Member Author

@typescript-bot cherry-pick to release-5.5

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 12, 2024

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
cherry-pick to release-5.5 ✅ Started ✅ Results

@typescript-bot
Copy link
Collaborator

Hey, @andrewbranch! I've created #58848 for you. This involved updating baselines; please check the diff.

@andrewbranch andrewbranch merged commit 97f3f0c into microsoft:main Jun 12, 2024
28 checks passed
@andrewbranch andrewbranch deleted the disable-57896 branch June 12, 2024 23:48
andrewbranch added a commit that referenced this pull request Jun 13, 2024
…e-5.5 (#58848)

Co-authored-by: Andrew Branch <andrewbranch@users.noreply.github.com>
Co-authored-by: Andrew Branch <andrew@wheream.io>
@andrewbranch andrewbranch mentioned this pull request Jun 13, 2024
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 5.5.2 milestone Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants