-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed crash on authored import type nodes when serializing for declarations #59160
Merged
DanielRosenwasser
merged 2 commits into
microsoft:main
from
Andarist:fix/crash-authored-importy-type-nodes
Jul 17, 2024
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
tests/cases/fourslash/completionsClassMemberImportTypeNodeParameter1.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
/// <reference path="fourslash.ts" /> | ||
|
||
// @module: nodenext | ||
|
||
// @Filename: /generation.d.ts | ||
//// export type GenerationConfigType = { max_length?: number }; | ||
|
||
// @FileName: /index.d.ts | ||
//// export declare class PreTrainedModel { | ||
//// _get_generation_config( | ||
//// param: import("./generation.js").GenerationConfigType, | ||
//// ): import("./generation.js").GenerationConfigType; | ||
//// } | ||
//// | ||
//// export declare class BlenderbotSmallPreTrainedModel extends PreTrainedModel { | ||
//// /*1*/ | ||
//// } | ||
|
||
verify.completions({ | ||
marker: "1", | ||
includes: [ | ||
{ | ||
name: "_get_generation_config", | ||
insertText: `_get_generation_config(param: import("./generation.js").GenerationConfigType): import("./generation.js").GenerationConfigType;`, | ||
filterText: "_get_generation_config", | ||
hasAction: undefined, | ||
}, | ||
], | ||
preferences: { | ||
includeCompletionsWithClassMemberSnippets: true, | ||
includeCompletionsWithInsertText: true, | ||
}, | ||
isNewIdentifierLocation: true, | ||
}); |
31 changes: 31 additions & 0 deletions
31
tests/cases/fourslash/completionsClassMemberImportTypeNodeParameter2.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
/// <reference path="fourslash.ts" /> | ||
|
||
// @module: nodenext | ||
|
||
// @FileName: /index.d.ts | ||
//// export declare class Cls { | ||
//// method( | ||
//// param: import("./doesntexist.js").Foo, | ||
//// ): import("./doesntexist.js").Foo; | ||
//// } | ||
//// | ||
//// export declare class Derived extends Cls { | ||
//// /*1*/ | ||
//// } | ||
|
||
verify.completions({ | ||
marker: "1", | ||
includes: [ | ||
{ | ||
name: "method", | ||
insertText: `method(param: import("./doesntexist.js").Foo);`, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is weird but not anything new. Return types nodes with errors are omitted based on |
||
filterText: "method", | ||
hasAction: undefined, | ||
}, | ||
], | ||
preferences: { | ||
includeCompletionsWithClassMemberSnippets: true, | ||
includeCompletionsWithInsertText: true, | ||
}, | ||
isNewIdentifierLocation: true, | ||
}); |
37 changes: 37 additions & 0 deletions
37
tests/cases/fourslash/completionsClassMemberImportTypeNodeParameter3.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
/// <reference path="fourslash.ts" /> | ||
|
||
// @module: nodenext | ||
|
||
// @FileName: /other/foo.d.ts | ||
//// export declare type Bar = { baz: string }; | ||
|
||
// @FileName: /other/cls.d.ts | ||
//// export declare class Cls { | ||
//// method( | ||
//// param: import("./foo.js").Bar, | ||
//// ): import("./foo.js").Bar; | ||
//// } | ||
|
||
// @FileName: /index.d.ts | ||
//// import { Cls } from "./other/cls.js"; | ||
//// | ||
//// export declare class Derived extends Cls { | ||
//// /*1*/ | ||
//// } | ||
|
||
verify.completions({ | ||
marker: "1", | ||
includes: [ | ||
{ | ||
name: "method", | ||
insertText: `method(param: import("./other/foo.js").Bar): import("./other/foo.js").Bar;`, | ||
filterText: "method", | ||
hasAction: undefined, | ||
}, | ||
], | ||
preferences: { | ||
includeCompletionsWithClassMemberSnippets: true, | ||
includeCompletionsWithInsertText: true, | ||
}, | ||
isNewIdentifierLocation: true, | ||
}); |
34 changes: 34 additions & 0 deletions
34
tests/cases/fourslash/completionsClassMemberImportTypeNodeParameter4.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
/// <reference path="fourslash.ts" /> | ||
|
||
// @module: nodenext | ||
|
||
// @FileName: /other/cls.d.ts | ||
//// export declare class Cls { | ||
//// method( | ||
//// param: import("./doesntexist.js").Foo, | ||
//// ): import("./doesntexist.js").Foo; | ||
//// } | ||
|
||
// @FileName: /index.d.ts | ||
//// import { Cls } from "./other/cls.js"; | ||
//// | ||
//// export declare class Derived extends Cls { | ||
//// /*1*/ | ||
//// } | ||
|
||
verify.completions({ | ||
marker: "1", | ||
includes: [ | ||
{ | ||
name: "method", | ||
insertText: `method(param: import("./doesntexist.js").Foo);`, | ||
filterText: "method", | ||
hasAction: undefined, | ||
}, | ||
], | ||
preferences: { | ||
includeCompletionsWithClassMemberSnippets: true, | ||
includeCompletionsWithInsertText: true, | ||
}, | ||
isNewIdentifierLocation: true, | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Value-space identifiers get their
.symbol
in the binder but type-level identifiers in import type nodes don't.Alternatively, this could be fixed in
visitExistingNodeTreeSymbolsWorker
but it's more tricky there.