Fix parsing of generic type parameters in arrow functions with JSX syntax #59485
+37
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially fixes #15713
This PR addresses an issue where the TypeScript parser incorrectly interprets generic type parameters in arrow functions as JSX elements. Specifically, the code
const a = <T>(b: T) => b
was being parsed as a JSX element instead of a generic type parameter.Testing:
Added a new test case
jsxGenericArrowFunction.tsx
to verify the fix. Before the change, the following errors were observed:After the change, these errors no longer occur.
This change ensures that generic type parameters in arrow functions are correctly parsed, improving TypeScript's type-checking and syntax parsing capabilities.
Additionally, as noted in the Design Meeting Notes, there has been anticipation for a fix to this issue from the TypeScript community