Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly list tuple overloads for Promise.all. #5973

Merged
merged 1 commit into from
Dec 7, 2015

Conversation

sandersn
Copy link
Member

@sandersn sandersn commented Dec 7, 2015

Previously, the array type would infer a union type for multiple arguments of differing types. The original overload remains, but I added 9 tuple-based overloads to support up to 10 heterogeneously-typed arguments.

Fixes #5935.

Previously, the array type would infer a union type for multiple arguments
of differing types. The original overload remains, but I added 9
tuple-based overloads to support up to 10 heterogeneously-typed arguments.
@mhegazy
Copy link
Contributor

mhegazy commented Dec 7, 2015

thanks! 👍

sandersn added a commit that referenced this pull request Dec 7, 2015
Explicitly list tuple overloads for `Promise.all`.
@sandersn sandersn merged commit 31f56fd into master Dec 7, 2015
@sandersn sandersn deleted the improve-type-of-Promise.all branch December 7, 2015 18:19
@OliverJAsh
Copy link
Contributor

How can I use these type definitions? They are not available at http://www.typescriptlang.org/playground/

@sandersn
Copy link
Member Author

We only update the playground when there's a release, so it's still on 1.7.x. It'll get the new types for 1.8.

@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants