Try subtype reducing call expression types if type argument arity checks will fail #60036

weswigham · 2024-09-23T20:24:00Z

We basically peek into a cheap part of overload resolution and see if we're destined to report an error on a union's list of signatures, and, if so, try subtype reducing the union and then doing the arity checks. If we can find a matching signature in the reduced union, we proceed with that, instead, and avoid the error.

Note that, per the comment in the code, right now I only do this for call expressions, and not other call-like expressions (decorators, tagged templates, jsx tags), because of where this logic needs to sit in the call resolution stack. If we like it, I can make the logic a bit more generic and insert it into all the call resolution codepaths (it's an interesting bit of logic since it needs both expression type information and signature level information - and the core resolveCall only operates on the later).

Fixes #60006

…cks are all going to fail

weswigham · 2024-09-23T20:24:13Z

@typescript-bot test it

typescript-bot · 2024-09-23T20:24:16Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-09-23T20:42:35Z

Hey @weswigham, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-09-23T20:48:48Z

@weswigham Here are the results of running the user tests with tsc comparing main and refs/pull/60036/merge:

Everything looks good!

typescript-bot · 2024-09-23T21:10:43Z

@weswigham
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{192,473k (± 0.02%)}	_{194,335k (± 0.99%)}	_~	_192,402k	_196,262k	_{p=0.092 n=6}
_{Parse Time}	_{1.31s (± 0.31%)}	_{1.30s (± 0.76%)}	_~	_1.29s	_1.31s	_{p=0.071 n=6}
_{Bind Time}	_0.71s	_0.71s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.58s (± 0.25%)}	_{9.59s (± 0.61%)}	_~	_9.52s	_9.67s	_{p=0.936 n=6}
_{Emit Time}	_{2.73s (± 0.56%)}	_{2.70s (± 1.74%)}	_~	_2.61s	_2.74s	_{p=0.413 n=6}
_{Total Time}	_{14.32s (± 0.21%)}	_{14.30s (± 0.39%)}	_~	_14.26s	_14.41s	_{p=0.257 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_945,734	_945,734	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,049	_410,049	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,786k (± 0.00%)}	_{1,222,791k (± 0.00%)}	_~	_1,222,767k	_1,222,826k	_{p=1.000 n=6}
_{Parse Time}	_{6.66s (± 0.66%)}	_{6.68s (± 0.77%)}	_~	_6.62s	_6.77s	_{p=0.418 n=6}
_{Bind Time}	_{1.86s (± 0.53%)}	_{1.86s (± 0.34%)}	_~	_1.85s	_1.87s	_{p=1.000 n=6}
_{Check Time}	_{31.24s (± 0.29%)}	_{31.30s (± 0.29%)}	_~	_31.17s	_31.41s	_{p=0.225 n=6}
_{Emit Time}	_{15.07s (± 0.29%)}	_{15.04s (± 0.29%)}	_~	_14.97s	_15.08s	_{p=0.261 n=6}
_{Total Time}	_{54.83s (± 0.21%)}	_{54.87s (± 0.20%)}	_~	_54.71s	_54.97s	_{p=0.521 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,521,513	_2,521,513	_~	_~	_~	_{p=1.000 n=6}
_Types	_936,002	_936,002	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,351,486k (± 0.00%)}	_{2,351,479k (± 0.00%)}	_~	_2,351,472k	_2,351,491k	_{p=0.471 n=6}
_{Parse Time}	_{9.28s (± 0.25%)}	_{9.28s (± 0.19%)}	_~	_9.25s	_9.30s	_{p=0.936 n=6}
_{Bind Time}	_{2.14s (± 0.48%)}	_{2.13s (± 0.46%)}	_{-0.02s (- 0.70%)}	_2.11s	_2.14s	_{p=0.028 n=6}
_{Check Time}	_{73.23s (± 0.24%)}	_{73.14s (± 0.27%)}	_~	_72.89s	_73.45s	_{p=0.378 n=6}
_{Emit Time}	_{0.28s (± 2.67%)}	_{0.28s (± 3.53%)}	_~	_0.26s	_0.29s	_{p=0.652 n=6}
_{Total Time}	_{84.93s (± 0.21%)}	_{84.83s (± 0.24%)}	_~	_84.57s	_85.13s	_{p=0.521 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,246,933	_1,246,938	_{+5 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_264,605	_264,606	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,399,865k (± 0.02%)}	_{2,399,994k (± 0.01%)}	_~	_2,399,785k	_2,400,271k	_{p=1.000 n=6}
_{Parse Time}	_{5.07s (± 0.46%)}	_{5.08s (± 0.57%)}	_~	_5.03s	_5.12s	_{p=0.575 n=6}
_{Bind Time}	_{1.92s (± 0.33%)}	_{1.91s (± 0.61%)}	_~	_1.89s	_1.92s	_{p=0.177 n=6}
_{Check Time}	_{34.89s (± 0.72%)}	_{35.01s (± 0.79%)}	_~	_34.78s	_35.55s	_{p=0.748 n=6}
_{Emit Time}	_{2.97s (± 0.46%)}	_{2.96s (± 0.59%)}	_~	_2.94s	_2.99s	_{p=0.934 n=6}
_{Total Time}	_{44.87s (± 0.56%)}	_{44.98s (± 0.62%)}	_~	_44.73s	_45.52s	_{p=0.810 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,246,933	_1,246,938	_{+5 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_264,605	_264,606	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,474,180k (± 0.04%)}	_{2,474,637k (± 0.02%)}	_~	_2,474,206k	_2,475,844k	_{p=0.230 n=6}
_{Parse Time}	_{6.32s (± 1.02%)}	_{6.34s (± 0.68%)}	_~	_6.29s	_6.41s	_{p=0.873 n=6}
_{Bind Time}	_{2.06s (± 1.01%)}	_{2.05s (± 0.44%)}	_~	_2.04s	_2.06s	_{p=0.806 n=6}
_{Check Time}	_{41.92s (± 0.37%)}	_{41.91s (± 0.80%)}	_~	_41.44s	_42.29s	_{p=1.000 n=6}
_{Emit Time}	_{3.59s (± 1.24%)}	_{3.56s (± 1.55%)}	_~	_3.47s	_3.62s	_{p=0.230 n=6}
_{Total Time}	_{53.91s (± 0.35%)}	_{53.87s (± 0.75%)}	_~	_53.30s	_54.28s	_{p=1.000 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_260,157	_260,162	_{+5 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,293	_106,294	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{436,154k (± 0.04%)}	_{436,069k (± 0.03%)}	_~	_435,926k	_436,324k	_{p=0.298 n=6}
_{Parse Time}	_{3.44s (± 0.85%)}	_{3.43s (± 0.63%)}	_~	_3.40s	_3.46s	_{p=0.331 n=6}
_{Bind Time}	_{1.29s (± 0.85%)}	_{1.29s (± 1.16%)}	_~	_1.27s	_1.31s	_{p=0.663 n=6}
_{Check Time}	_{18.15s (± 0.41%)}	_{18.07s (± 0.24%)}	_~	_18.01s	_18.13s	_{p=0.090 n=6}
_{Emit Time}	_{1.52s (± 2.24%)}	_{1.53s (± 1.22%)}	_~	_1.51s	_1.56s	_{p=0.625 n=6}
_{Total Time}	_{24.40s (± 0.34%)}	_{24.32s (± 0.33%)}	_~	_24.21s	_24.40s	_{p=0.213 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,018	_225,018	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,249	_94,249	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,285k (± 0.02%)}	_{370,294k (± 0.01%)}	_~	_370,242k	_370,358k	_{p=0.936 n=6}
_{Parse Time}	_{2.75s (± 0.50%)}	_{2.77s (± 0.78%)}	_~	_2.75s	_2.81s	_{p=0.076 n=6}
_{Bind Time}	_{1.56s (± 0.70%)}	_{1.56s (± 0.57%)}	_~	_1.55s	_1.57s	_{p=0.932 n=6}
_{Check Time}	_{15.72s (± 0.35%)}	_{15.71s (± 0.52%)}	_~	_15.65s	_15.86s	_{p=0.686 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.03s (± 0.27%)}	_{20.04s (± 0.43%)}	_~	_19.96s	_20.18s	_{p=1.000 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁	₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,094,697	_3,094,697	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,066,781	_1,066,781	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,192,582k (± 0.00%)}	_{3,192,544k (± 0.00%)}	_~	_3,192,444k	_3,192,616k	_{p=0.336 n=6}
_{Parse Time}	_{17.20s (± 0.26%)}	_{17.21s (± 0.46%)}	_~	_17.08s	_17.31s	_{p=0.688 n=6}
_{Bind Time}	_{5.40s (± 2.11%)}	_{5.39s (± 2.33%)}	_~	_5.30s	_5.61s	_{p=0.809 n=6}
_{Check Time}	_{100.00s (± 0.41%)}	_{99.93s (± 0.25%)}	_~	_99.68s	_100.27s	_{p=0.936 n=6}
_{Emit Time}	_{27.30s (± 0.14%)}	_{27.25s (± 0.25%)}	_~	_27.16s	_27.33s	_{p=0.142 n=6}
_{Total Time}	_{149.90s (± 0.28%)}	_{149.77s (± 0.17%)}	_~	_149.54s	_150.11s	_{p=0.471 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_277,129	_277,129	_~	_~	_~	_{p=1.000 n=6}
_Types	_113,106	_113,106	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{427,005k (± 0.01%)}	_{426,976k (± 0.02%)}	_~	_426,901k	_427,071k	_{p=0.575 n=6}
_{Parse Time}	_{3.95s (± 0.41%)}	_{3.95s (± 0.38%)}	_~	_3.93s	_3.97s	_{p=0.935 n=6}
_{Bind Time}	_{1.72s (± 0.96%)}	_{1.71s (± 0.48%)}	_~	_1.70s	_1.72s	_{p=0.323 n=6}
_{Check Time}	_{17.61s (± 0.21%)}	_{17.56s (± 0.42%)}	_~	_17.45s	_17.62s	_{p=0.257 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{23.28s (± 0.17%)}	_{23.22s (± 0.34%)}	_~	_23.10s	_23.31s	_{p=0.260 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_539,981	_539,981	_~	_~	_~	_{p=1.000 n=6}
_Types	_181,270	_181,270	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{483,378k (± 0.01%)}	_{483,386k (± 0.02%)}	_~	_483,276k	_483,574k	_{p=0.936 n=6}
_{Parse Time}	_{3.23s (± 0.66%)}	_{3.26s (± 0.43%)}	_{+0.03s (+ 0.98%)}	_3.24s	_3.28s	_{p=0.023 n=6}
_{Bind Time}	_{1.16s (± 0.35%)}	_{1.16s (± 0.85%)}	_~	_1.15s	_1.17s	_{p=0.487 n=6}
_{Check Time}	_{18.61s (± 0.58%)}	_{18.56s (± 0.53%)}	_~	_18.40s	_18.68s	_{p=0.230 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{23.00s (± 0.48%)}	_{22.98s (± 0.48%)}	_~	_22.79s	_23.11s	_{p=0.630 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-09-23T21:59:17Z

@weswigham Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60036/merge:

Everything looks good!

weswigham · 2024-09-24T20:28:39Z

@typescript-bot pack this

typescript-bot · 2024-09-24T20:28:42Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`pack this`	✅ Started	✅ Results

typescript-bot · 2024-09-24T20:31:02Z

Hey @weswigham, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/163678/artifacts?artifactName=tgz&fileId=1764C8FADAAE7E5D00AD2DA8F1ABBDC2E5359205EA31222B43802ECE65FF68EC02&fileName=/typescript-5.7.0-insiders.20240924.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.7.0-pr-60036-8".;

Try subtype reducing call expression types if type argument arity che…

372959a

…cks are all going to fail

weswigham requested review from sandersn and andrewbranch September 23, 2024 20:24

typescript-bot assigned weswigham Sep 23, 2024

typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Sep 23, 2024

weswigham mentioned this pull request Sep 23, 2024

Missing overload method on union types #60006

Closed

weswigham closed this Sep 24, 2024

Andarist mentioned this pull request Oct 1, 2024

[Control flow] Array filter with typeguard works differently following array initial value #60108

Open

DanielRosenwasser mentioned this pull request Oct 18, 2024

Design Meeting Notes, 9/24/2024 #60284

Open

sandersn removed this from PR Backlog Apr 22, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Try subtype reducing call expression types if type argument arity checks will fail #60036

Try subtype reducing call expression types if type argument arity checks will fail #60036

weswigham commented Sep 23, 2024

weswigham commented Sep 23, 2024

typescript-bot commented Sep 23, 2024 •

edited

Loading

typescript-bot commented Sep 23, 2024

typescript-bot commented Sep 23, 2024

typescript-bot commented Sep 23, 2024

tsc

typescript-bot commented Sep 23, 2024

weswigham commented Sep 24, 2024

typescript-bot commented Sep 24, 2024 •

edited

Loading

typescript-bot commented Sep 24, 2024 •

edited

Loading

Try subtype reducing call expression types if type argument arity checks will fail #60036

Try subtype reducing call expression types if type argument arity checks will fail #60036

Conversation

weswigham commented Sep 23, 2024

weswigham commented Sep 23, 2024

typescript-bot commented Sep 23, 2024 • edited Loading

typescript-bot commented Sep 23, 2024

typescript-bot commented Sep 23, 2024

typescript-bot commented Sep 23, 2024

tsc

typescript-bot commented Sep 23, 2024

weswigham commented Sep 24, 2024

typescript-bot commented Sep 24, 2024 • edited Loading

typescript-bot commented Sep 24, 2024 • edited Loading

typescript-bot commented Sep 23, 2024 •

edited

Loading

typescript-bot commented Sep 24, 2024 •

edited

Loading

typescript-bot commented Sep 24, 2024 •

edited

Loading