Set impliedNodeFormat based on redirectedReference options #60039

andrewbranch · 2024-09-23T22:39:54Z

tests/baselines/reference/tscWatch/projectsWithReferences/on-sample-project-with-nodenext.js

andrewbranch · 2024-09-23T22:42:02Z

typescript-bot · 2024-09-23T22:42:05Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-09-23T23:03:21Z

Hey @andrewbranch, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-09-23T23:10:39Z

@andrewbranch Here are the results of running the user tests with tsc comparing main and refs/pull/60039/merge:

Everything looks good!

typescript-bot · 2024-09-23T23:21:41Z

@andrewbranch
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{194,850k (± 0.97%)}	_{192,487k (± 0.07%)}	_~	_192,367k	_192,751k	_{p=0.128 n=6}
_{Parse Time}	_{1.57s (± 0.48%)}	_{1.57s (± 0.52%)}	_~	_1.56s	_1.58s	_{p=0.306 n=6}
_{Bind Time}	_{0.86s (± 1.27%)}	_{0.86s (± 1.04%)}	_~	_0.85s	_0.87s	_{p=1.000 n=6}
_{Check Time}	_{11.35s (± 0.31%)}	_{11.38s (± 0.54%)}	_~	_11.28s	_11.45s	_{p=0.226 n=6}
_{Emit Time}	_{3.24s (± 0.98%)}	_{3.22s (± 0.95%)}	_~	_3.17s	_3.24s	_{p=0.280 n=6}
_{Total Time}	_{17.02s (± 0.38%)}	_{17.03s (± 0.52%)}	_~	_16.87s	_17.11s	_{p=0.810 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_945,734	_945,734	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,049	_410,049	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,792k (± 0.00%)}	_{1,222,786k (± 0.00%)}	_~	_1,222,730k	_1,222,824k	_{p=0.748 n=6}
_{Parse Time}	_{6.67s (± 0.27%)}	_{6.64s (± 0.37%)}	_~	_6.61s	_6.67s	_{p=0.120 n=6}
_{Bind Time}	_{1.86s (± 0.40%)}	_{1.86s (± 0.40%)}	_~	_1.85s	_1.87s	_{p=1.000 n=6}
_{Check Time}	_{31.25s (± 0.44%)}	_{31.26s (± 0.41%)}	_~	_31.12s	_31.47s	_{p=0.810 n=6}
_{Emit Time}	_{15.02s (± 0.40%)}	_{15.06s (± 0.30%)}	_~	_14.98s	_15.11s	_{p=0.228 n=6}
_{Total Time}	_{54.79s (± 0.27%)}	_{54.83s (± 0.25%)}	_~	_54.68s	_55.07s	_{p=0.419 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,521,513	_2,521,513	_~	_~	_~	_{p=1.000 n=6}
_Types	_936,002	_936,002	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,351,490k (± 0.00%)}	_{2,351,526k (± 0.00%)}	_~	_2,351,421k	_2,351,569k	_{p=0.066 n=6}
_{Parse Time}	_{9.28s (± 0.34%)}	_{9.29s (± 0.23%)}	_~	_9.26s	_9.31s	_{p=0.567 n=6}
_{Bind Time}	_{2.13s (± 0.49%)}	_{2.13s (± 0.46%)}	_~	_2.12s	_2.14s	_{p=0.315 n=6}
_{Check Time}	_{73.53s (± 0.64%)}	_{73.63s (± 0.23%)}	_~	_73.44s	_73.88s	_{p=0.810 n=6}
_{Emit Time}	_{0.28s (± 1.47%)}	_{0.28s (± 1.47%)}	_~	_0.27s	_0.28s	_{p=1.000 n=6}
_{Total Time}	_{85.22s (± 0.58%)}	_{85.32s (± 0.18%)}	_~	_85.14s	_85.55s	_{p=0.810 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,246,933	_1,246,934	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_264,605	_264,605	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,399,827k (± 0.04%)}	_{2,399,584k (± 0.02%)}	_~	_2,398,990k	_2,399,941k	_{p=0.810 n=6}
_{Parse Time}	_{5.04s (± 1.01%)}	_{5.10s (± 0.68%)}	_~	_5.06s	_5.15s	_{p=0.092 n=6}
_{Bind Time}	_{1.91s (± 0.61%)}	_{1.91s (± 0.63%)}	_~	_1.89s	_1.92s	_{p=0.933 n=6}
_{Check Time}	_{34.86s (± 0.14%)}	_{34.81s (± 0.30%)}	_~	_34.69s	_34.99s	_{p=0.148 n=6}
_{Emit Time}	_{3.03s (± 4.84%)}	_{3.23s (± 5.20%)}	_{🔻+0.21s (+ 6.88%)}	_3.02s	_3.42s	_{p=0.037 n=6}
_{Total Time}	_{44.86s (± 0.31%)}	_{45.06s (± 0.18%)}	_{+0.20s (+ 0.44%)}	_44.96s	_45.18s	_{p=0.045 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,246,933	_1,246,934	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_264,605	_264,605	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,474,586k (± 0.02%)}	_{2,474,130k (± 0.02%)}	_~	_2,473,691k	_2,474,898k	_{p=0.128 n=6}
_{Parse Time}	_{5.26s (± 0.37%)}	_{5.28s (± 1.45%)}	_~	_5.18s	_5.37s	_{p=0.423 n=6}
_{Bind Time}	_{1.72s (± 1.20%)}	_{1.73s (± 0.99%)}	_~	_1.70s	_1.75s	_{p=0.216 n=6}
_{Check Time}	_{35.34s (± 0.33%)}	_{35.24s (± 0.27%)}	_~	_35.14s	_35.40s	_{p=0.149 n=6}
_{Emit Time}	_{2.99s (± 1.03%)}	_{3.08s (± 5.16%)}	_~	_2.94s	_3.35s	_{p=0.574 n=6}
_{Total Time}	_{45.34s (± 0.18%)}	_{45.33s (± 0.39%)}	_~	_45.07s	_45.57s	_{p=0.936 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_260,157	_260,158	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,293	_106,293	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{436,080k (± 0.03%)}	_{435,980k (± 0.02%)}	_~	_435,901k	_436,108k	_{p=0.378 n=6}
_{Parse Time}	_{3.45s (± 0.85%)}	_{3.44s (± 0.66%)}	_~	_3.42s	_3.48s	_{p=0.746 n=6}
_{Bind Time}	_{1.29s (± 1.24%)}	_{1.30s (± 0.42%)}	_~	_1.30s	_1.31s	_{p=0.055 n=6}
_{Check Time}	_{18.12s (± 0.31%)}	_{18.14s (± 0.35%)}	_~	_18.07s	_18.26s	_{p=0.520 n=6}
_{Emit Time}	_{1.52s (± 0.99%)}	_{1.52s (± 1.40%)}	_~	_1.49s	_1.54s	_{p=0.413 n=6}
_{Total Time}	_{24.37s (± 0.25%)}	_{24.41s (± 0.13%)}	_~	_24.36s	_24.46s	_{p=0.226 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,018	_225,018	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,249	_94,249	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,282k (± 0.02%)}	_{370,303k (± 0.02%)}	_~	_370,199k	_370,397k	_{p=0.689 n=6}
_{Parse Time}	_{3.44s (± 1.21%)}	_{3.44s (± 0.81%)}	_~	_3.40s	_3.47s	_{p=1.000 n=6}
_{Bind Time}	_{1.94s (± 1.97%)}	_{1.93s (± 2.02%)}	_~	_1.87s	_1.99s	_{p=0.518 n=6}
_{Check Time}	_{19.49s (± 0.29%)}	_{19.49s (± 0.54%)}	_~	_19.38s	_19.62s	_{p=1.000 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.88s (± 0.43%)}	_{24.86s (± 0.60%)}	_~	_24.66s	_25.05s	_{p=0.629 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁	₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,094,498	_3,094,498	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,066,739	_1,066,739	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,192,396k (± 0.00%)}	_{3,192,389k (± 0.00%)}	_~	_3,192,355k	_3,192,447k	_{p=0.630 n=6}
_{Parse Time}	_{13.92s (± 0.25%)}	_{13.97s (± 0.40%)}	_~	_13.89s	_14.02s	_{p=0.168 n=6}
_{Bind Time}	_{4.42s (± 2.20%)}	_{4.36s (± 0.28%)}	_~	_4.34s	_4.37s	_{p=0.360 n=6}
_{Check Time}	_{82.44s (± 0.46%)}	_{82.15s (± 0.40%)}	_~	_81.72s	_82.67s	_{p=0.128 n=6}
_{Emit Time}	_{22.38s (± 0.35%)}	_{22.49s (± 0.94%)}	_~	_22.28s	_22.87s	_{p=0.575 n=6}
_{Total Time}	_{123.17s (± 0.26%)}	_{122.97s (± 0.30%)}	_~	_122.54s	_123.49s	_{p=0.378 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_277,129	_277,129	_~	_~	_~	_{p=1.000 n=6}
_Types	_113,106	_113,106	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{426,977k (± 0.01%)}	_{426,996k (± 0.02%)}	_~	_426,936k	_427,104k	_{p=1.000 n=6}
_{Parse Time}	_{3.95s (± 0.37%)}	_{3.93s (± 0.30%)}	_~	_3.91s	_3.94s	_{p=0.079 n=6}
_{Bind Time}	_{1.72s (± 1.13%)}	_{1.72s (± 0.44%)}	_~	_1.71s	_1.73s	_{p=0.396 n=6}
_{Check Time}	_{17.53s (± 0.35%)}	_{17.54s (± 0.20%)}	_~	_17.48s	_17.58s	_{p=0.747 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{23.20s (± 0.28%)}	_{23.20s (± 0.13%)}	_~	_23.14s	_23.23s	_{p=0.872 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_539,981	_539,981	_~	_~	_~	_{p=1.000 n=6}
_Types	_181,270	_181,270	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{483,418k (± 0.02%)}	_{483,397k (± 0.01%)}	_~	_483,358k	_483,439k	_{p=0.521 n=6}
_{Parse Time}	_{3.21s (± 0.58%)}	_{3.23s (± 0.51%)}	_~	_3.21s	_3.25s	_{p=0.462 n=6}
_{Bind Time}	_{1.16s (± 0.85%)}	_{1.16s (± 1.09%)}	_~	_1.14s	_1.18s	_{p=0.801 n=6}
_{Check Time}	_{18.63s (± 0.27%)}	_{18.62s (± 0.26%)}	_~	_18.54s	_18.67s	_{p=0.628 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{23.01s (± 0.29%)}	_{23.00s (± 0.25%)}	_~	_22.93s	_23.07s	_{p=0.687 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-09-24T00:18:19Z

@andrewbranch Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60039/merge:

Everything looks good!

Andarist · 2024-09-24T10:53:21Z

I have a strong suspicion that redirected references and impliedNodeFormat are behind crashes like this one. In the cal.com's case, we can bisect the crash to #59479 but those kind of crashes were present way before that PR.

I'm still trying to reduce that repro case but I figured out it might be an interesting info to you. I have confirmed that this PR doesn't fix that issue right now.

src/compiler/program.ts

andrewbranch · 2024-09-24T18:02:00Z

I think our strategy here is going to have to change significantly. The fix in this PR as it stands breaks the scenario tested in 100f939. We can’t actually skip setting impliedNodeFormat on source files in any case; we can only choose how to interpret the value there.

sheetalkamat · 2024-09-24T19:19:02Z

I feel like this value should be in program instead of on sourceFile because sourceFiles are shared across programs. Eg thats what we did for module resolution as it causes issues otherwise. Otherwise sourceFile with given options "OptionsAffectingSourceFile" need to handle these cases and then it starts depending on ModuleResolution options again? (we removed that dependency)

andrewbranch · 2024-09-24T19:26:06Z

That’s one option I thought about. moduleResolution is already correctly marked as affecting source files. Unfortunately, impliedNodeFormat is public on SourceFile. But internally, most if not all accesses happen through Program now, so I think we could just always set impliedNodeFormat on source files and let the Program-based accesses decide whether to return anything.

Andarist · 2024-09-24T22:14:59Z

I can confirm that this now fixes #60029 (comment) . I'm still working on creating a test based on that crash though.

andrewbranch · 2024-09-24T22:23:11Z

@typescript-bot test it

typescript-bot · 2024-09-24T22:23:15Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	👀 Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-09-24T22:45:29Z

Hey @andrewbranch, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-09-24T22:46:54Z

@andrewbranch Here are the results of running the user tests with tsc comparing main and refs/pull/60039/merge:

Everything looks good!

typescript-bot · 2024-09-24T22:59:50Z

Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page.

Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up.

typescript-bot · 2024-09-24T23:03:54Z

@andrewbranch
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,340	_62,340	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,378	_50,378	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{194,485k (± 1.00%)}	_{194,026k (± 0.94%)}	_~	_192,698k	_196,426k	_{p=0.575 n=6}
_{Parse Time}	_{1.30s (± 1.52%)}	_{1.30s (± 0.97%)}	_~	_1.29s	_1.32s	_{p=0.934 n=6}
_{Bind Time}	_0.71s	_{0.71s (± 0.57%)}	_~	_0.71s	_0.72s	_{p=0.405 n=6}
_{Check Time}	_{9.49s (± 0.37%)}	_{9.54s (± 0.26%)}	_{+0.04s (+ 0.46%)}	_9.50s	_9.57s	_{p=0.044 n=6}
_{Emit Time}	_{2.72s (± 0.49%)}	_{2.73s (± 0.52%)}	_~	_2.71s	_2.75s	_{p=0.180 n=6}
_{Total Time}	_{14.22s (± 0.31%)}	_{14.28s (± 0.28%)}	_{+0.06s (+ 0.45%)}	_14.22s	_14.34s	_{p=0.030 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,102	_947,100	_{-2 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_410,738	_410,736	_{-2 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{1,224,022k (± 0.00%)}	_{1,226,017k (± 0.00%)}	_{+1,995k (+ 0.16%)}	_1,225,985k	_1,226,081k	_{p=0.005 n=6}
_{Parse Time}	_{6.59s (± 0.41%)}	_{6.71s (± 0.33%)}	_{+0.12s (+ 1.77%)}	_6.69s	_6.75s	_{p=0.005 n=6}
_{Bind Time}	_{1.87s (± 0.22%)}	_{1.86s (± 0.28%)}	_~	_1.86s	_1.87s	_{p=0.112 n=6}
_{Check Time}	_{31.41s (± 0.36%)}	_{31.39s (± 0.65%)}	_~	_31.12s	_31.59s	_{p=1.000 n=6}
_{Emit Time}	_{15.04s (± 0.48%)}	_{15.42s (± 0.43%)}	_{+0.38s (+ 2.53%)}	_15.31s	_15.50s	_{p=0.005 n=6}
_{Total Time}	_{54.91s (± 0.31%)}	_{55.38s (± 0.34%)}	_{+0.47s (+ 0.86%)}	_55.09s	_55.61s	_{p=0.008 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,521,651	_2,524,911	_{+3,260 (+ 0.13%)}	_~	_~	_{p=0.001 n=6}
_Types	_936,037	_939,429	_{+3,392 (+ 0.36%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,351,711k (± 0.00%)}	_{2,451,724k (± 0.00%)}	_{🔻+100,014k (+ 4.25%)}	_2,451,612k	_2,451,780k	_{p=0.005 n=6}
_{Parse Time}	_{9.28s (± 0.16%)}	_{9.60s (± 0.27%)}	_{+0.32s (+ 3.45%)}	_9.56s	_9.64s	_{p=0.005 n=6}
_{Bind Time}	_{2.13s (± 0.38%)}	_{2.14s (± 0.38%)}	_~	_2.13s	_2.15s	_{p=0.666 n=6}
_{Check Time}	_{73.47s (± 0.49%)}	_{74.43s (± 0.77%)}	_{+0.96s (+ 1.30%)}	_73.59s	_75.13s	_{p=0.013 n=6}
_{Emit Time}	_0.28s	_{0.28s (± 2.26%)}	_~	_0.27s	_0.29s	_{p=1.000 n=6}
_{Total Time}	_{85.17s (± 0.43%)}	_{86.45s (± 0.65%)}	_{+1.28s (+ 1.50%)}	_85.59s	_87.10s	_{p=0.010 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,250,056	_1,250,052	_{-4 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_264,970	_264,969	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,404,460k (± 0.01%)}	_{2,404,510k (± 0.01%)}	_~	_2,404,182k	_2,404,942k	_{p=0.810 n=6}
_{Parse Time}	_{5.13s (± 0.81%)}	_{5.16s (± 0.36%)}	_~	_5.13s	_5.18s	_{p=0.199 n=6}
_{Bind Time}	_{1.91s (± 0.72%)}	_{1.91s (± 0.51%)}	_~	_1.90s	_1.92s	_{p=0.677 n=6}
_{Check Time}	_{34.93s (± 0.22%)}	_{34.98s (± 0.25%)}	_~	_34.87s	_35.09s	_{p=0.423 n=6}
_{Emit Time}	_{2.97s (± 1.32%)}	_{2.99s (± 0.98%)}	_~	_2.96s	_3.03s	_{p=0.748 n=6}
_{Total Time}	_{44.95s (± 0.27%)}	_{45.06s (± 0.20%)}	_~	_44.91s	_45.15s	_{p=0.128 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,250,056	_1,250,052	_{-4 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_264,970	_264,969	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,479,136k (± 0.02%)}	_{2,479,235k (± 0.03%)}	_~	_2,478,452k	_2,480,713k	_{p=0.936 n=6}
_{Parse Time}	_{6.34s (± 0.93%)}	_{6.34s (± 0.38%)}	_~	_6.31s	_6.38s	_{p=0.688 n=6}
_{Bind Time}	_{2.06s (± 0.53%)}	_{2.06s (± 0.86%)}	_~	_2.03s	_2.08s	_{p=0.454 n=6}
_{Check Time}	_{41.59s (± 0.19%)}	_{41.86s (± 0.65%)}	_~	_41.57s	_42.23s	_{p=0.066 n=6}
_{Emit Time}	_{3.80s (± 5.51%)}	_{3.55s (± 2.30%)}	_~	_3.41s	_3.62s	_{p=0.109 n=6}
_{Total Time}	_{53.83s (± 0.35%)}	_{53.83s (± 0.60%)}	_~	_53.47s	_54.26s	_{p=0.936 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_260,936	_260,932	_{-4 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,385	_106,384	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{436,643k (± 0.03%)}	_{436,625k (± 0.03%)}	_~	_436,496k	_436,844k	_{p=0.470 n=6}
_{Parse Time}	_{3.45s (± 0.68%)}	_{3.44s (± 0.98%)}	_~	_3.40s	_3.49s	_{p=0.571 n=6}
_{Bind Time}	_{1.31s (± 0.64%)}	_{1.30s (± 0.49%)}	_~	_1.29s	_1.31s	_{p=0.226 n=6}
_{Check Time}	_{18.23s (± 0.25%)}	_{18.14s (± 0.49%)}	_~	_18.04s	_18.26s	_{p=0.108 n=6}
_{Emit Time}	_{1.53s (± 1.06%)}	_{1.52s (± 1.73%)}	_~	_1.48s	_1.56s	_{p=0.212 n=6}
_{Total Time}	_{24.51s (± 0.21%)}	_{24.41s (± 0.42%)}	_~	_24.28s	_24.55s	_{p=0.065 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,916	_225,916	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,414	_94,414	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,906k (± 0.01%)}	_{371,019k (± 0.01%)}	_{+113k (+ 0.03%)}	_370,942k	_371,087k	_{p=0.008 n=6}
_{Parse Time}	_{2.77s (± 0.82%)}	_{2.79s (± 0.77%)}	_~	_2.76s	_2.81s	_{p=0.258 n=6}
_{Bind Time}	_{1.57s (± 1.48%)}	_{1.56s (± 0.66%)}	_~	_1.55s	_1.58s	_{p=0.162 n=6}
_{Check Time}	_{15.79s (± 0.23%)}	_{15.85s (± 0.40%)}	_{+0.06s (+ 0.37%)}	_15.80s	_15.94s	_{p=0.044 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.14s (± 0.31%)}	_{20.21s (± 0.22%)}	_~	_20.16s	_20.26s	_{p=0.053 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁	₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,099,752	_3,099,796	_{+44 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_1,068,965	_1,068,870	_{-95 (- 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,196,791k (± 0.00%)}	_{3,201,832k (± 0.00%)}	_{+5,040k (+ 0.16%)}	_3,201,774k	_3,201,888k	_{p=0.005 n=6}
_{Parse Time}	_{13.90s (± 0.36%)}	_{14.13s (± 0.41%)}	_{+0.23s (+ 1.68%)}	_14.04s	_14.20s	_{p=0.005 n=6}
_{Bind Time}	_{4.34s (± 0.24%)}	_{4.36s (± 1.93%)}	_~	_4.31s	_4.53s	_{p=0.617 n=6}
_{Check Time}	_{81.85s (± 0.18%)}	_{81.97s (± 0.37%)}	_~	_81.57s	_82.31s	_{p=0.688 n=6}
_{Emit Time}	_{22.34s (± 0.31%)}	_{23.27s (± 0.43%)}	_{🔻+0.94s (+ 4.19%)}	_23.17s	_23.45s	_{p=0.005 n=6}
_{Total Time}	_{122.43s (± 0.17%)}	_{123.73s (± 0.18%)}	_{+1.31s (+ 1.07%)}	_123.37s	_123.94s	_{p=0.005 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_278,920	_278,920	_~	_~	_~	_{p=1.000 n=6}
_Types	_113,837	_113,837	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{428,434k (± 0.01%)}	_{428,845k (± 0.02%)}	_{+411k (+ 0.10%)}	_428,740k	_428,961k	_{p=0.005 n=6}
_{Parse Time}	_{4.89s (± 0.38%)}	_{4.92s (± 0.59%)}	_~	_4.89s	_4.97s	_{p=0.075 n=6}
_{Bind Time}	_{2.13s (± 0.65%)}	_{2.15s (± 0.38%)}	_{+0.03s (+ 1.33%)}	_2.14s	_2.16s	_{p=0.011 n=6}
_{Check Time}	_{21.89s (± 0.46%)}	_{21.91s (± 0.33%)}	_~	_21.84s	_22.02s	_{p=0.573 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{28.91s (± 0.40%)}	_{28.99s (± 0.30%)}	_~	_28.89s	_29.14s	_{p=0.230 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_540,027	_540,027	_~	_~	_~	_{p=1.000 n=6}
_Types	_181,292	_181,292	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{483,541k (± 0.01%)}	_{483,566k (± 0.01%)}	_~	_483,518k	_483,621k	_{p=0.471 n=6}
_{Parse Time}	_{4.01s (± 0.34%)}	_{4.01s (± 0.32%)}	_~	_4.00s	_4.03s	_{p=0.510 n=6}
_{Bind Time}	_{1.43s (± 0.72%)}	_{1.42s (± 0.72%)}	_~	_1.41s	_1.44s	_{p=0.134 n=6}
_{Check Time}	_{22.89s (± 0.32%)}	_{22.88s (± 0.15%)}	_~	_22.84s	_22.94s	_{p=1.000 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{28.33s (± 0.21%)}	_{28.31s (± 0.15%)}	_~	_28.26s	_28.39s	_{p=0.685 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

andrewbranch · 2024-09-24T23:09:20Z

Pretty sure what I have works, though moving the storage to Program would be more efficient, though also a public API break... I don’t think I’ll have time to get this into 5.7 as I’ll be out on vacation starting tomorrow and returning past the beta deadline.

src/compiler/program.ts

-            || fileExtensionIsOneOf(sourceFile.fileName, [Extension.Cjs, Extension.Cts]))
+        ModuleKind.Node16 <= moduleKind && moduleKind <= ModuleKind.NodeNext
+        || fileExtensionIsOneOf(sourceFile.fileName, [Extension.Cts, Extension.Dcts, Extension.Cjs, Extension.Mts, Extension.Dmts, Extension.Mjs])
+        || pathContainsNodeModules(sourceFile.fileName)


typescript-bot · 2024-09-25T00:02:10Z

@andrewbranch Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60039/merge:

Something interesting changed - please have a look.

Details

blakeblackshear/frigate

web/tsconfig.json

error TS2322: Type 'IconType | typeof import("/mnt/ts_downloads/_/m/frigate/web/node_modules/react-icons/lu/index")' is not assignable to type 'IconType'.
- web/src/components/filter/CameraGroupSelector.tsx#L177
error TS2322: Type 'IconType | typeof import("/mnt/ts_downloads/_/m/frigate/web/node_modules/react-icons/lu/index") | undefined' is not assignable to type 'IconType | undefined'.
- web/src/components/filter/CameraGroupSelector.tsx#L769
error TS2604: JSX element type 'Icon' does not have any construct or call signatures.
- web/src/components/icons/IconPicker.tsx#L130
error TS2786: 'Icon' cannot be used as a JSX component.
- web/src/components/icons/IconPicker.tsx#L130
error TS2322: Type 'IconType | typeof import("/mnt/ts_downloads/_/m/frigate/web/node_modules/react-icons/lu/index")' is not assignable to type 'IconType | undefined'.
- web/src/components/icons/IconPicker.tsx#L133

openai-translator/openai-translator

tsconfig.json

error TS2352: Conversion of type 'typeof import("/mnt/ts_downloads/_/m/openai-translator/node_modules/.pnpm/react-icons@5.0.1_react@18.2.0/node_modules/react-icons/md/index")' to type 'Record<string, IconType>' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.
error TS2769: No overload matches this call.
- src/common/components/Translator.tsx#L1725

… `impliedNodeFormat` clash

Andarist · 2024-09-26T09:12:49Z

It took me a while to reduce this 🥵 but here's a test case for the crash I mentioned in my previous comments here: andrewbranch#3

…e-format-and-document-registry Add extra test case for a weird situation with symlinks and potential `impliedNodeFormat` clash

Andarist · 2024-12-03T06:21:30Z

@jakebailey could you build this one? :) a user would like to test effect of this PR on the VS Code crashes they experience: #60243 (comment)

jakebailey · 2024-12-03T07:47:20Z

Unfortunately not, as the PR has merge conflicts.

…flicts

Bug/57553 resolve conflicts

andrewbranch · 2024-12-03T16:49:38Z

@typescript-bot pack this

typescript-bot · 2024-12-03T16:49:44Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`pack this`	✅ Started	✅ Results

typescript-bot · 2024-12-03T16:51:31Z

Hey @andrewbranch, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/164262/artifacts?artifactName=tgz&fileId=5C36B3AB96C551B2F152060199F6CA1288F88DF0A9038EE0C59713D67D1C98DE02&fileName=/typescript-5.8.0-insiders.20241203.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.8.0-pr-60039-24".;

andrewbranch added 2 commits September 23, 2024 11:29

Add failing test

daad420

Set impliedNodeFormat based on redirectedReference options

5a97e07

typescript-bot assigned andrewbranch Sep 23, 2024

typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Sep 23, 2024

andrewbranch requested a review from sheetalkamat September 23, 2024 22:40

andrewbranch commented Sep 23, 2024

View reviewed changes

tests/baselines/reference/tscWatch/projectsWithReferences/on-sample-project-with-nodenext.js Outdated Show resolved Hide resolved

andrewbranch added 3 commits September 23, 2024 16:14

Use traceResolution setting of current project, not referenced project

6badddc

Merge branch 'main' into bug/57553

a01b643

Update baseline

15a114f

andrewbranch marked this pull request as draft September 23, 2024 23:18

Add failing test

100f939

sheetalkamat reviewed Sep 24, 2024

View reviewed changes

src/compiler/program.ts Show resolved Hide resolved

sheetalkamat reviewed Sep 24, 2024

View reviewed changes

src/compiler/program.ts Outdated Show resolved Hide resolved

andrewbranch added 6 commits September 24, 2024 14:36

Always set impliedNodeFormat on source files, filter when looking it up

8ba691a

Add trace baselines

778b288

Add unit test / fourslash server baselines

632e498

Update compiler tests/baselines

fd13d3b

Update unit test assertions

6951b0b

moduleResolution no longer affects SourceFile, I think

c0afec1

Merge branch 'main' into bug/57553

56c9473

Update API baseline

e19fe20

sheetalkamat reviewed Sep 24, 2024

View reviewed changes

src/compiler/program.ts Show resolved Hide resolved

sheetalkamat reviewed Sep 24, 2024

View reviewed changes

Add extra test case for a weird situation with symlinks and potential…

5c07256

… `impliedNodeFormat` clash

andrewbranch mentioned this pull request Oct 15, 2024

Project references result in multiple dual publish module resolutions #59456

Closed

andrewbranch and others added 2 commits October 17, 2024 16:48

Merge branch 'main' into bug/57553

5457461

Merge pull request #3 from Andarist/add-extra-test-around-implied-nod…

80fd886

…e-format-and-document-registry Add extra test case for a weird situation with symlinks and potential `impliedNodeFormat` clash

Andarist mentioned this pull request Nov 28, 2024

TS Server fatal error: Debug Failure. #60243

Open

Andarist mentioned this pull request Dec 3, 2024

Bug/57553 resolve conflicts andrewbranch/TypeScript#5

Merged

Andarist and others added 2 commits December 3, 2024 10:18

Merge remote-tracking branch 'origin/main' into bug/57553-resolve-con…

ac24ab7

…flicts

Merge pull request #5 from Andarist/bug/57553-resolve-conflicts

1325ee2

Bug/57553 resolve conflicts

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Set impliedNodeFormat based on redirectedReference options #60039

Set impliedNodeFormat based on redirectedReference options #60039

andrewbranch commented Sep 23, 2024

andrewbranch commented Sep 23, 2024

typescript-bot commented Sep 23, 2024 •

edited

Loading

typescript-bot commented Sep 23, 2024

typescript-bot commented Sep 23, 2024

typescript-bot commented Sep 23, 2024

tsc

typescript-bot commented Sep 24, 2024

Andarist commented Sep 24, 2024

andrewbranch commented Sep 24, 2024 •

edited

Loading

sheetalkamat commented Sep 24, 2024

andrewbranch commented Sep 24, 2024

Andarist commented Sep 24, 2024

andrewbranch commented Sep 24, 2024

typescript-bot commented Sep 24, 2024 •

edited

Loading

typescript-bot commented Sep 24, 2024

typescript-bot commented Sep 24, 2024

typescript-bot commented Sep 24, 2024

typescript-bot commented Sep 24, 2024

tsc

andrewbranch commented Sep 24, 2024

This comment was marked as duplicate.

typescript-bot commented Sep 25, 2024

blakeblackshear/frigate

web/tsconfig.json

openai-translator/openai-translator

tsconfig.json

Andarist commented Sep 26, 2024

Andarist commented Dec 3, 2024

jakebailey commented Dec 3, 2024 •

edited

Loading

andrewbranch commented Dec 3, 2024

typescript-bot commented Dec 3, 2024 •

edited

Loading

typescript-bot commented Dec 3, 2024 •

edited

Loading

Set impliedNodeFormat based on redirectedReference options #60039

Are you sure you want to change the base?

Set impliedNodeFormat based on redirectedReference options #60039

Conversation

andrewbranch commented Sep 23, 2024

andrewbranch commented Sep 23, 2024

typescript-bot commented Sep 23, 2024 • edited Loading

typescript-bot commented Sep 23, 2024

typescript-bot commented Sep 23, 2024

typescript-bot commented Sep 23, 2024

tsc

typescript-bot commented Sep 24, 2024

Andarist commented Sep 24, 2024

andrewbranch commented Sep 24, 2024 • edited Loading

sheetalkamat commented Sep 24, 2024

andrewbranch commented Sep 24, 2024

Andarist commented Sep 24, 2024

andrewbranch commented Sep 24, 2024

typescript-bot commented Sep 24, 2024 • edited Loading

typescript-bot commented Sep 24, 2024

typescript-bot commented Sep 24, 2024

typescript-bot commented Sep 24, 2024

typescript-bot commented Sep 24, 2024

tsc

andrewbranch commented Sep 24, 2024

This comment was marked as duplicate.

typescript-bot commented Sep 25, 2024

blakeblackshear/frigate

web/tsconfig.json

openai-translator/openai-translator

tsconfig.json

Andarist commented Sep 26, 2024

Andarist commented Dec 3, 2024

jakebailey commented Dec 3, 2024 • edited Loading

andrewbranch commented Dec 3, 2024

typescript-bot commented Dec 3, 2024 • edited Loading

typescript-bot commented Dec 3, 2024 • edited Loading

typescript-bot commented Sep 23, 2024 •

edited

Loading

andrewbranch commented Sep 24, 2024 •

edited

Loading

typescript-bot commented Sep 24, 2024 •

edited

Loading

jakebailey commented Dec 3, 2024 •

edited

Loading

typescript-bot commented Dec 3, 2024 •

edited

Loading

typescript-bot commented Dec 3, 2024 •

edited

Loading