Suggested solution to #5730 [tsserver] custom command #6010
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion (specifically my comment) in #5730 .
To summarise here, the idea is to allow complex hosts (such as Angular-aware editors) to inject extra commands into
tsserver
, without recompilingtsserver.js
.Instead of all the complexity of a plugin hosting model, I suggest we turn the table and put the burden of hosting on the actual host interested in running
tsserver
.The Angular-editing enrichment will load
tsserver.js
script content, eval() it, then it has a window to updatets.server.Session.prototype
to its liking before the server starts up proper.