Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(60223): add Promise.try() to ESNext lib #60232

Merged
merged 5 commits into from
Nov 6, 2024
Merged

fix(60223): add Promise.try() to ESNext lib #60232

merged 5 commits into from
Nov 6, 2024

Conversation

dirkluijk
Copy link
Contributor

Fixes #60223

@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Oct 15, 2024
@dirkluijk dirkluijk force-pushed the fix-promise-try branch 2 times, most recently from dbb3235 to 1407fab Compare October 15, 2024 08:13
@dirkluijk
Copy link
Contributor Author

dirkluijk commented Oct 15, 2024 •
edited
Loading

This is my first contribution to this project. Please let me know if this PR needs anything else. :)

Maybe this can still make it to the final 5.7 release?

@IllusionMH
Copy link
Contributor

IllusionMH commented Oct 15, 2024 •
edited
Loading

Shouldn't it be es2025 instead?
es2024 was finished/approved in June https://github.com/tc39/ecma262/releases/tag/es2024

@dirkluijk
Copy link
Contributor Author

dirkluijk commented Oct 15, 2024 •
edited
Loading

I wasn't fully aware of how the TC39 finalization process works. Shall I move it to ESNext, or to ES2025? I will move it to ESNext instead.

@dirkluijk dirkluijk changed the title fix(60223): add Promise.try() to ES2024 lib fix(60223): add Promise.try() to ESNext lib Oct 15, 2024
@dirkluijk
Copy link
Contributor Author

@microsoft-github-policy-service agree

@dirkluijk
Copy link
Contributor Author

Should be fixed.

@dirkluijk
Copy link
Contributor Author

dirkluijk commented Oct 15, 2024 •
edited
Loading

@gabritto I just updated the PR to allow a PromiseLike return value instead of a Promise.

ljharb
ljharb reviewed Oct 15, 2024
View reviewed changes
src/lib/esnext.promise.d.ts Outdated Show resolved Hide resolved
@gabritto gabritto self-requested a review October 15, 2024 22:02
@dirkluijk
Copy link
Contributor Author

Updated the PR to allow passing additional arguments.

ljharb
ljharb reviewed Oct 16, 2024
View reviewed changes
Copy link
Contributor

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dirkluijk
Copy link
Contributor Author

When will this PR be merged? 😉

@jakebailey
Copy link
Member

TS 5.7 beta is already out, and we don't do anything bug bugfixes or editor improvements after beta. The linked issue is milestoned as 5.8.

@gabritto gabritto merged commit 60dd512 into microsoft:main Nov 6, 2024
32 checks passed
@dirkluijk dirkluijk deleted the fix-promise-try branch December 17, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakebailey jakebailey jakebailey left review comments

@ljharb ljharb ljharb left review comments

@gabritto gabritto gabritto approved these changes

Assignees

@gabritto gabritto

Labels
For Milestone Bug PRs that fix a bug with a specific milestone
Projects
PR Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update ESNext with Promise.try (stage 4)
6 participants
@dirkluijk @IllusionMH @jakebailey @ljharb @gabritto @typescript-bot