Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prioritization of paths specifiers over node_modules package specifiers #60238

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

andrewbranch
Copy link
Member

Fixes #51398

Review with whitespace changes hidden. Slightly above the diff that GitHub shows is a comment outlining the module specifier priority intended, but it wasn’t working in this case where paths points to something inside node_modules.

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Oct 15, 2024
Copy link
Member

@iisaduan iisaduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big diff difference reviewing with and without whitespace changes :D

@andrewbranch andrewbranch merged commit 2ac4cb7 into microsoft:main Oct 23, 2024
32 checks passed
@andrewbranch andrewbranch deleted the bug/51398 branch October 23, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Auto import with wildcard imports with expanded path
3 participants