Allow assignments to readonly class properties within IIFEs contained in constructors #60416

Andarist · 2024-11-04T19:03:47Z

… in constructors

jakebailey · 2024-11-04T19:05:18Z

typescript-bot · 2024-11-04T19:05:23Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-11-04T19:44:12Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-11-04T19:46:50Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₁	₃₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,340	_62,340	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,379	_50,379	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,400k (± 0.76%)}	_{192,862k (± 0.07%)}	_~	_192,766k	_193,152k	_{p=0.689 n=6}
_{Parse Time}	_{1.30s (± 0.84%)}	_{1.30s (± 1.26%)}	_~	_1.29s	_1.33s	_{p=0.734 n=6}
_{Bind Time}	_{0.72s (± 0.57%)}	_{0.72s (± 0.57%)}	_~	_0.72s	_0.73s	_{p=1.000 n=6}
_{Check Time}	_{9.74s (± 0.32%)}	_{9.76s (± 0.37%)}	_~	_9.73s	_9.83s	_{p=1.000 n=6}
_{Emit Time}	_{2.72s (± 0.57%)}	_{2.73s (± 0.51%)}	_~	_2.71s	_2.75s	_{p=0.683 n=6}
_{Total Time}	_{14.48s (± 0.17%)}	_{14.51s (± 0.30%)}	_~	_14.47s	_14.59s	_{p=0.369 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₃	₃₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,888	_947,888	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,840	_410,840	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,224,599k (± 0.00%)}	_{1,224,640k (± 0.00%)}	_~	_1,224,584k	_1,224,703k	_{p=0.173 n=6}
_{Parse Time}	_{6.64s (± 0.75%)}	_{6.62s (± 0.35%)}	_~	_6.59s	_6.65s	_{p=0.517 n=6}
_{Bind Time}	_{1.89s (± 0.29%)}	_{1.88s (± 0.40%)}	_~	_1.87s	_1.89s	_{p=0.476 n=6}
_{Check Time}	_{31.85s (± 0.14%)}	_{31.87s (± 0.35%)}	_~	_31.72s	_32.01s	_{p=1.000 n=6}
_{Emit Time}	_{15.19s (± 0.32%)}	_{15.30s (± 0.77%)}	_~	_15.16s	_15.47s	_{p=0.077 n=6}
_{Total Time}	_{55.56s (± 0.14%)}	_{55.66s (± 0.29%)}	_~	_55.50s	_55.88s	_{p=0.261 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,495,004	_2,495,004	_~	_~	_~	_{p=1.000 n=6}
_Types	_908,592	_908,592	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,307,261k (± 0.00%)}	_{2,307,260k (± 0.00%)}	_~	_2,307,205k	_2,307,302k	_{p=0.936 n=6}
_{Parse Time}	_{9.32s (± 0.32%)}	_{9.32s (± 0.43%)}	_~	_9.28s	_9.38s	_{p=0.871 n=6}
_{Bind Time}	_{2.13s (± 0.26%)}	_{2.15s (± 0.64%)}	_~	_2.13s	_2.17s	_{p=0.090 n=6}
_{Check Time}	_{75.21s (± 0.27%)}	_{74.97s (± 0.30%)}	_~	_74.72s	_75.36s	_{p=0.078 n=6}
_{Emit Time}	_{0.28s (± 1.86%)}	_{0.28s (± 1.45%)}	_~	_0.28s	_0.29s	_{p=0.114 n=6}
_{Total Time}	_{86.94s (± 0.26%)}	_{86.72s (± 0.28%)}	_~	_86.42s	_87.14s	_{p=0.109 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,258,544	_1,258,543	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,358	_266,358	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,423,400k (± 0.02%)}	_{2,423,085k (± 0.02%)}	_~	_2,422,188k	_2,423,492k	_{p=0.230 n=6}
_{Parse Time}	_{5.23s (± 0.45%)}	_{5.23s (± 0.21%)}	_~	_5.21s	_5.24s	_{p=0.575 n=6}
_{Bind Time}	_{1.92s (± 0.57%)}	_{1.92s (± 0.63%)}	_~	_1.90s	_1.93s	_{p=0.652 n=6}
_{Check Time}	_{35.55s (± 0.20%)}	_{35.55s (± 0.18%)}	_~	_35.44s	_35.63s	_{p=0.689 n=6}
_{Emit Time}	_{3.00s (± 0.94%)}	_{3.02s (± 1.32%)}	_~	_2.97s	_3.08s	_{p=0.377 n=6}
_{Total Time}	_{45.70s (± 0.18%)}	_{45.73s (± 0.18%)}	_~	_45.63s	_45.83s	_{p=0.689 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,258,544	_1,258,543	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,358	_266,358	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,980,603k (±12.47%)}	_{2,620,396k (±11.19%)}	_~	_2,499,838k	_3,219,507k	_{p=0.173 n=6}
_{Parse Time}	_{6.78s (± 2.40%)}	_{6.59s (± 2.04%)}	_~	_6.50s	_6.86s	_{p=0.128 n=6}
_{Bind Time}	_{2.12s (± 2.02%)}	_{2.15s (± 1.00%)}	_~	_2.13s	_2.19s	_{p=0.149 n=6}
_{Check Time}	_{43.21s (± 0.35%)}	_{43.19s (± 0.38%)}	_~	_42.89s	_43.36s	_{p=1.000 n=6}
_{Emit Time}	_{3.65s (± 6.50%)}	_{3.51s (± 2.52%)}	_~	_3.39s	_3.62s	_{p=0.230 n=6}
_{Total Time}	_{55.77s (± 0.55%)}	_{55.45s (± 0.42%)}	_~	_55.12s	_55.76s	_{p=0.093 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_261,751	_261,750	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,472	_106,472	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{438,818k (± 0.01%)}	_{438,827k (± 0.02%)}	_~	_438,691k	_438,937k	_{p=0.689 n=6}
_{Parse Time}	_{3.56s (± 0.99%)}	_{3.53s (± 0.60%)}	_~	_3.51s	_3.57s	_{p=0.170 n=6}
_{Bind Time}	_{1.32s (± 0.89%)}	_{1.32s (± 1.05%)}	_~	_1.29s	_1.33s	_{p=1.000 n=6}
_{Check Time}	_{18.95s (± 0.31%)}	_{18.97s (± 0.65%)}	_~	_18.85s	_19.17s	_{p=1.000 n=6}
_{Emit Time}	_{1.54s (± 0.79%)}	_{1.54s (± 1.45%)}	_~	_1.50s	_1.56s	_{p=0.684 n=6}
_{Total Time}	_{25.36s (± 0.22%)}	_{25.36s (± 0.52%)}	_~	_25.23s	_25.58s	_{p=0.377 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,921	_225,921	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,415	_94,415	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,123k (± 0.02%)}	_{371,125k (± 0.01%)}	_~	_371,087k	_371,206k	_{p=0.810 n=6}
_{Parse Time}	_{2.91s (± 0.77%)}	_{2.90s (± 1.32%)}	_~	_2.84s	_2.95s	_{p=0.570 n=6}
_{Bind Time}	_{1.59s (± 0.65%)}	_{1.58s (± 1.24%)}	_~	_1.56s	_1.61s	_{p=0.805 n=6}
_{Check Time}	_{16.41s (± 0.41%)}	_{16.40s (± 0.11%)}	_~	_16.38s	_16.43s	_{p=1.000 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.91s (± 0.28%)}	_{20.88s (± 0.24%)}	_~	_20.79s	_20.92s	_{p=0.747 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,132,118	_3,132,118	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,079,618	_1,079,618	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,221,188k (± 0.00%)}	_{3,221,101k (± 0.01%)}	_~	_3,220,518k	_3,221,270k	_{p=1.000 n=6}
_{Parse Time}	_{14.16s (± 0.63%)}	_{14.08s (± 0.55%)}	_~	_13.97s	_14.20s	_{p=0.128 n=6}
_{Bind Time}	_{4.50s (± 2.46%)}	_{4.55s (± 3.04%)}	_~	_4.45s	_4.75s	_{p=0.253 n=6}
_{Check Time}	_{86.65s (± 3.47%)}	_{86.78s (± 2.05%)}	_~	_84.64s	_88.56s	_{p=0.575 n=6}
_{Emit Time}	_{26.51s (± 6.63%)}	_{25.44s (± 8.11%)}	_~	_22.80s	_27.20s	_{p=0.066 n=6}
_{Total Time}	_{131.82s (± 2.91%)}	_{130.85s (± 2.09%)}	_~	_126.94s	_134.15s	_{p=0.575 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_288,119	_288,119	_~	_~	_~	_{p=1.000 n=6}
_Types	_116,928	_116,928	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{439,536k (± 0.02%)}	_{439,505k (± 0.03%)}	_~	_439,338k	_439,644k	_{p=0.936 n=6}
_{Parse Time}	_{4.07s (± 0.48%)}	_{4.10s (± 0.67%)}	_~	_4.06s	_4.13s	_{p=0.072 n=6}
_{Bind Time}	_{1.75s (± 1.43%)}	_{1.75s (± 1.11%)}	_~	_1.73s	_1.78s	_{p=1.000 n=6}
_{Check Time}	_{18.72s (± 0.64%)}	_{18.60s (± 0.45%)}	_~	_18.52s	_18.76s	_{p=0.065 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.54s (± 0.51%)}	_{24.46s (± 0.39%)}	_~	_24.39s	_24.64s	_{p=0.261 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_543,132	_543,132	_~	_~	_~	_{p=1.000 n=6}
_Types	_181,889	_181,889	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{485,498k (± 0.01%)}	_{485,479k (± 0.02%)}	_~	_485,249k	_485,569k	_{p=0.936 n=6}
_{Parse Time}	_{4.16s (± 0.70%)}	_{4.18s (± 0.29%)}	_~	_4.17s	_4.20s	_{p=0.254 n=6}
_{Bind Time}	_{1.45s (± 1.20%)}	_{1.46s (± 1.09%)}	_~	_1.44s	_1.48s	_{p=0.458 n=6}
_{Check Time}	_{23.64s (± 0.32%)}	_{23.77s (± 0.68%)}	_~	_23.59s	_24.05s	_{p=0.149 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{29.25s (± 0.36%)}	_{29.41s (± 0.55%)}	_~	_29.22s	_29.70s	_{p=0.065 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-11-04T19:59:32Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/60416/merge:

Everything looks good!

typescript-bot · 2024-11-04T20:59:27Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60416/merge:

Everything looks good!

Andarist · 2024-11-30T15:47:42Z

@jakebailey 2 approvals and CI is happy about it, is there anything else to be done here before landing this one? :)

jakebailey · 2024-12-02T19:15:40Z

No, I just forgot to merge it 😅

Allow assignments to readonly class properties within IIFEs contained…

5586a40

… in constructors

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Nov 4, 2024

RyanCavanaugh approved these changes Nov 4, 2024

View reviewed changes

jakebailey approved these changes Nov 4, 2024

View reviewed changes

jakebailey merged commit 9717772 into microsoft:main Dec 2, 2024
32 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow assignments to readonly class properties within IIFEs contained in constructors #60416

Allow assignments to readonly class properties within IIFEs contained in constructors #60416

Andarist commented Nov 4, 2024

jakebailey commented Nov 4, 2024

typescript-bot commented Nov 4, 2024 •

edited

Loading

typescript-bot commented Nov 4, 2024

typescript-bot commented Nov 4, 2024

tsc

typescript-bot commented Nov 4, 2024

typescript-bot commented Nov 4, 2024

Andarist commented Nov 30, 2024

jakebailey commented Dec 2, 2024

Allow assignments to readonly class properties within IIFEs contained in constructors #60416

Allow assignments to readonly class properties within IIFEs contained in constructors #60416

Conversation

Andarist commented Nov 4, 2024

jakebailey commented Nov 4, 2024

typescript-bot commented Nov 4, 2024 • edited Loading

typescript-bot commented Nov 4, 2024

typescript-bot commented Nov 4, 2024

tsc

typescript-bot commented Nov 4, 2024

typescript-bot commented Nov 4, 2024

Andarist commented Nov 30, 2024

jakebailey commented Dec 2, 2024

typescript-bot commented Nov 4, 2024 •

edited

Loading