fix(60484): Implementing a prim type in a class expression should report error #60490

a-tarasyuk · 2024-11-12T22:16:55Z

…ression

jakebailey · 2024-11-13T00:41:35Z

typescript-bot · 2024-11-13T00:41:40Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-11-13T00:58:58Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/60490/merge:

Everything looks good!

typescript-bot · 2024-11-13T01:00:54Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-11-13T01:22:59Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,363	_62,363	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,395	_50,395	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,036k (± 0.01%)}	_{193,712k (± 0.76%)}	_~	_193,000k	_196,691k	_{p=0.689 n=6}
_{Parse Time}	_{1.31s (± 0.96%)}	_{1.31s (± 0.62%)}	_~	_1.30s	_1.32s	_{p=0.558 n=6}
_{Bind Time}	_0.72s	_0.72s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.80s (± 0.44%)}	_{9.82s (± 0.37%)}	_~	_9.76s	_9.87s	_{p=0.375 n=6}
_{Emit Time}	_{2.73s (± 0.67%)}	_{2.73s (± 0.71%)}	_~	_2.71s	_2.76s	_{p=1.000 n=6}
_{Total Time}	_{14.56s (± 0.22%)}	_{14.58s (± 0.23%)}	_~	_14.53s	_14.62s	_{p=0.521 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₇	₃₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,936	_947,936	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,955	_410,955	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,226,017k (± 0.00%)}	_{1,225,994k (± 0.00%)}	_~	_1,225,948k	_1,226,055k	_{p=0.229 n=6}
_{Parse Time}	_{6.64s (± 0.90%)}	_{6.68s (± 0.55%)}	_~	_6.64s	_6.73s	_{p=0.261 n=6}
_{Bind Time}	_{1.89s (± 0.27%)}	_{1.89s (± 0.44%)}	_~	_1.87s	_1.89s	_{p=0.923 n=6}
_{Check Time}	_{32.08s (± 0.54%)}	_{32.09s (± 0.24%)}	_~	_31.97s	_32.18s	_{p=0.810 n=6}
_{Emit Time}	_{15.25s (± 0.64%)}	_{15.18s (± 0.41%)}	_~	_15.10s	_15.26s	_{p=0.336 n=6}
_{Total Time}	_{55.86s (± 0.27%)}	_{55.84s (± 0.14%)}	_~	_55.75s	_55.96s	_{p=1.000 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,498,292	_2,498,292	_~	_~	_~	_{p=1.000 n=6}
_Types	_908,904	_908,904	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,317,079k (± 0.00%)}	_{2,317,077k (± 0.00%)}	_~	_2,317,033k	_2,317,097k	_{p=0.873 n=6}
_{Parse Time}	_{9.32s (± 0.33%)}	_{9.32s (± 0.16%)}	_~	_9.31s	_9.34s	_{p=0.453 n=6}
_{Bind Time}	_{2.17s (± 0.29%)}	_{2.16s (± 0.68%)}	_~	_2.14s	_2.18s	_{p=0.345 n=6}
_{Check Time}	_{74.69s (± 0.38%)}	_{75.02s (± 0.34%)}	_~	_74.80s	_75.46s	_{p=0.066 n=6}
_{Emit Time}	_{0.29s (± 4.05%)}	_{0.28s (± 2.67%)}	_~	_0.27s	_0.29s	_{p=0.279 n=6}
_{Total Time}	_{86.47s (± 0.32%)}	_{86.79s (± 0.30%)}	_~	_86.56s	_87.23s	_{p=0.109 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,389	_1,225,389	_~	_~	_~	_{p=1.000 n=6}
_Types	_266,556	_266,555	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,415,089k (± 6.13%)}	_{2,415,182k (± 6.13%)}	_~	_2,354,119k	_2,717,845k	_{p=0.689 n=6}
_{Parse Time}	_{5.26s (± 0.89%)}	_{5.25s (± 1.34%)}	_~	_5.18s	_5.38s	_{p=0.572 n=6}
_{Bind Time}	_{1.77s (± 0.86%)}	_{1.77s (± 1.40%)}	_~	_1.73s	_1.80s	_{p=0.572 n=6}
_{Check Time}	_{35.20s (± 0.58%)}	_{35.08s (± 0.63%)}	_~	_34.73s	_35.31s	_{p=0.298 n=6}
_{Emit Time}	_{2.98s (± 0.81%)}	_{2.98s (± 1.05%)}	_~	_2.94s	_3.02s	_{p=0.873 n=6}
_{Total Time}	_{45.23s (± 0.36%)}	_{45.09s (± 0.42%)}	_~	_44.85s	_45.30s	_{p=0.199 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,389	_1,225,389	_~	_~	_~	_{p=1.000 n=6}
_Types	_266,556	_266,555	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,786,889k (±14.22%)}	_{3,149,153k (± 0.03%)}	_~	_3,147,856k	_3,150,021k	_{p=0.173 n=6}
_{Parse Time}	_{6.97s (± 1.93%)}	_{7.03s (± 0.73%)}	_~	_6.97s	_7.12s	_{p=0.810 n=6}
_{Bind Time}	_{2.15s (± 1.08%)}	_{2.15s (± 0.82%)}	_~	_2.13s	_2.17s	_{p=0.747 n=6}
_{Check Time}	_{42.82s (± 0.65%)}	_{42.85s (± 0.20%)}	_~	_42.73s	_42.93s	_{p=1.000 n=6}
_{Emit Time}	_{3.50s (± 3.06%)}	_{3.55s (± 2.27%)}	_~	_3.49s	_3.70s	_{p=0.298 n=6}
_{Total Time}	_{55.43s (± 0.84%)}	_{55.58s (± 0.23%)}	_~	_55.38s	_55.70s	_{p=1.000 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_262,223	_262,223	_~	_~	_~	_{p=1.000 n=6}
_Types	_106,607	_106,606	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{439,795k (± 0.01%)}	_{439,814k (± 0.02%)}	_~	_439,726k	_439,968k	_{p=0.810 n=6}
_{Parse Time}	_{3.55s (± 0.40%)}	_{3.55s (± 0.83%)}	_~	_3.52s	_3.59s	_{p=0.871 n=6}
_{Bind Time}	_{1.32s (± 0.83%)}	_{1.32s (± 0.96%)}	_~	_1.31s	_1.34s	_{p=0.932 n=6}
_{Check Time}	_{18.98s (± 0.33%)}	_{18.96s (± 0.40%)}	_~	_18.89s	_19.09s	_{p=0.628 n=6}
_{Emit Time}	_{1.53s (± 1.40%)}	_{1.52s (± 1.79%)}	_~	_1.47s	_1.55s	_{p=0.624 n=6}
_{Total Time}	_{25.38s (± 0.23%)}	_{25.35s (± 0.42%)}	_~	_25.23s	_25.54s	_{p=0.377 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₀	₇₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_226,062	_226,062	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,488	_94,488	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,606k (± 0.01%)}	_{371,578k (± 0.01%)}	_~	_371,549k	_371,603k	_{p=0.173 n=6}
_{Parse Time}	_{3.61s (± 0.57%)}	_{3.60s (± 1.30%)}	_~	_3.56s	_3.68s	_{p=0.373 n=6}
_{Bind Time}	_{1.96s (± 0.82%)}	_{1.95s (± 1.73%)}	_~	_1.92s	_2.00s	_{p=0.519 n=6}
_{Check Time}	_{20.50s (± 0.55%)}	_{20.41s (± 0.18%)}	_~	_20.34s	_20.45s	_{p=0.126 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_0.00s	_~	_~	_~	_{p=0.405 n=6}
_{Total Time}	_{26.07s (± 0.43%)}	_{25.96s (± 0.31%)}	_~	_25.86s	_26.07s	_{p=0.077 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₄	₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,144,290	_3,144,290	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,084,113	_1,084,113	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,228,274k (± 0.01%)}	_{3,228,217k (± 0.01%)}	_~	_3,227,496k	_3,228,549k	_{p=0.575 n=6}
_{Parse Time}	_{14.05s (± 0.57%)}	_{14.03s (± 0.28%)}	_~	_13.97s	_14.06s	_{p=0.628 n=6}
_{Bind Time}	_{4.53s (± 2.33%)}	_{4.60s (± 3.31%)}	_~	_4.44s	_4.74s	_{p=0.573 n=6}
_{Check Time}	_{85.80s (± 0.42%)}	_{86.27s (± 1.66%)}	_~	_84.71s	_89.01s	_{p=0.575 n=6}
_{Emit Time}	_{23.97s (± 7.21%)}	_{24.50s (± 8.80%)}	_~	_22.75s	_27.26s	_{p=1.000 n=6}
_{Total Time}	_{128.35s (± 1.16%)}	_{129.41s (± 2.24%)}	_~	_127.33s	_134.70s	_{p=0.689 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_288,542	_288,542	_~	_~	_~	_{p=1.000 n=6}
_Types	_117,082	_117,082	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{440,787k (± 0.03%)}	_{440,780k (± 0.02%)}	_~	_440,630k	_440,915k	_{p=0.936 n=6}
_{Parse Time}	_{4.11s (± 1.16%)}	_{4.07s (± 0.83%)}	_~	_4.03s	_4.13s	_{p=0.295 n=6}
_{Bind Time}	_{1.73s (± 1.58%)}	_{1.75s (± 0.47%)}	_~	_1.74s	_1.76s	_{p=0.133 n=6}
_{Check Time}	_{18.91s (± 0.13%)}	_{18.85s (± 0.46%)}	_~	_18.72s	_18.98s	_{p=0.090 n=6}
_{Emit Time}	_0.00s	_{0.00s (±244.70%)}	_~	_0.00s	_0.01s	_{p=0.405 n=6}
_{Total Time}	_{24.74s (± 0.12%)}	_{24.66s (± 0.37%)}	_~	_24.54s	_24.80s	_{p=0.088 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₈	₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_551,583	_551,583	_~	_~	_~	_{p=1.000 n=6}
_Types	_184,808	_184,808	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{491,944k (± 0.01%)}	_{491,908k (± 0.01%)}	_~	_491,839k	_491,968k	_{p=0.261 n=6}
_{Parse Time}	_{3.43s (± 0.51%)}	_{3.41s (± 0.63%)}	_~	_3.38s	_3.44s	_{p=0.145 n=6}
_{Bind Time}	_{1.18s (± 0.35%)}	_{1.18s (± 1.16%)}	_~	_1.16s	_1.20s	_{p=0.245 n=6}
_{Check Time}	_{19.54s (± 0.29%)}	_{19.53s (± 0.31%)}	_~	_19.43s	_19.61s	_{p=0.873 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.15s (± 0.21%)}	_{24.12s (± 0.27%)}	_~	_24.01s	_24.21s	_{p=0.520 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-11-13T02:39:15Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60490/merge:

Everything looks good!

src/compiler/checker.ts

fix(60484): report error when implementing a prim type in a class exp…

455d591

…ression

typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Nov 12, 2024

Andarist reviewed Nov 13, 2024

View reviewed changes

src/compiler/checker.ts Show resolved Hide resolved

add tests for classes extending primitive types

34b0399

jakebailey approved these changes Nov 20, 2024

View reviewed changes

jakebailey merged commit d85767a into microsoft:main Nov 20, 2024
32 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(60484): Implementing a prim type in a class expression should report error #60490

fix(60484): Implementing a prim type in a class expression should report error #60490

a-tarasyuk commented Nov 12, 2024

jakebailey commented Nov 13, 2024

typescript-bot commented Nov 13, 2024 •

edited

Loading

typescript-bot commented Nov 13, 2024

typescript-bot commented Nov 13, 2024

typescript-bot commented Nov 13, 2024

tsc

typescript-bot commented Nov 13, 2024

fix(60484): Implementing a prim type in a class expression should report error #60490

fix(60484): Implementing a prim type in a class expression should report error #60490

Conversation

a-tarasyuk commented Nov 12, 2024

jakebailey commented Nov 13, 2024

typescript-bot commented Nov 13, 2024 • edited Loading

typescript-bot commented Nov 13, 2024

typescript-bot commented Nov 13, 2024

typescript-bot commented Nov 13, 2024

tsc

typescript-bot commented Nov 13, 2024

typescript-bot commented Nov 13, 2024 •

edited

Loading