Skip to content

Use double quotes in declaration file's reference path generation #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/compiler/emitter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3103,7 +3103,7 @@ module ts {
compilerHost.getCurrentDirectory(),
/*isAbsolutePathAnUrl*/ false);

referencePathsOutput += "/// <reference path='" + declFileName + "' />" + newLine;
referencePathsOutput += "/// <reference path=\"" + declFileName + "\" />" + newLine;
}

if (root) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,6 @@ declare module "SubModule" {
}
}
//// [declFileAmbientExternalModuleWithSingleExportedModule_1.d.ts]
/// <reference path='declFileAmbientExternalModuleWithSingleExportedModule_0.d.ts' />
/// <reference path="declFileAmbientExternalModuleWithSingleExportedModule_0.d.ts" />
import SubModule = require('SubModule');
export declare var x: SubModule.m.m3.c;
2 changes: 1 addition & 1 deletion tests/baselines/reference/declFileForExportedImport.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@ var z = exports.b.x;
//// [declFileForExportedImport_0.d.ts]
export declare var x: number;
//// [declFileForExportedImport_1.d.ts]
/// <reference path='declFileForExportedImport_0.d.ts' />
/// <reference path="declFileForExportedImport_0.d.ts" />
export import a = require('declFileForExportedImport_0');
export import b = a;
10 changes: 5 additions & 5 deletions tests/baselines/reference/importDecl.js
Original file line number Diff line number Diff line change
Expand Up @@ -205,11 +205,11 @@ export declare function foo(): d;
import m4 = require("importDecl_require");
export declare function foo2(): m4.d;
//// [importDecl_1.d.ts]
/// <reference path='importDecl_require.d.ts' />
/// <reference path='importDecl_require1.d.ts' />
/// <reference path='importDecl_require2.d.ts' />
/// <reference path='importDecl_require3.d.ts' />
/// <reference path='importDecl_require4.d.ts' />
/// <reference path="importDecl_require.d.ts" />
/// <reference path="importDecl_require1.d.ts" />
/// <reference path="importDecl_require2.d.ts" />
/// <reference path="importDecl_require3.d.ts" />
/// <reference path="importDecl_require4.d.ts" />
import m4 = require("importDecl_require");
export declare var x4: m4.d;
export declare var d4: typeof m4.d;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,6 @@ export declare class B {
id: number;
}
//// [importDeclarationUsedAsTypeQuery_1.d.ts]
/// <reference path='importDeclarationUsedAsTypeQuery_require.d.ts' />
/// <reference path="importDeclarationUsedAsTypeQuery_require.d.ts" />
import a = require('importDeclarationUsedAsTypeQuery_require');
export declare var x: typeof a;
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ declare module "SubModule" {
export = SubModule;
}
//// [missingImportAfterModuleImport_1.d.ts]
/// <reference path='missingImportAfterModuleImport_0.d.ts' />
/// <reference path="missingImportAfterModuleImport_0.d.ts" />
import SubModule = require('SubModule');
declare class MainModule {
SubModule: SubModule;
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/moduleSymbolMerging.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ declare module A {
}
}
//// [B.d.ts]
/// <reference path='A.d.ts' />
/// <reference path="A.d.ts" />
declare module A {
}
declare module B {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ export declare module SpecializedWidget {
function createWidget2(): Widget2;
}
//// [privacyCannotNameAccessorDeclFile_exporter.d.ts]
/// <reference path='privacyCannotNameAccessorDeclFile_GlobalWidgets.d.ts' />
/// <reference path="privacyCannotNameAccessorDeclFile_GlobalWidgets.d.ts" />
import Widgets = require("privacyCannotNameAccessorDeclFile_Widgets");
import Widgets1 = require("GlobalWidgets");
export declare function createExportedWidget1(): Widgets.Widget1;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ export declare module SpecializedWidget {
function createWidget2(): Widget2;
}
//// [privacyCannotNameVarTypeDeclFile_exporter.d.ts]
/// <reference path='privacyCannotNameVarTypeDeclFile_GlobalWidgets.d.ts' />
/// <reference path="privacyCannotNameVarTypeDeclFile_GlobalWidgets.d.ts" />
import Widgets = require("privacyCannotNameVarTypeDeclFile_Widgets");
import Widgets1 = require("GlobalWidgets");
export declare function createExportedWidget1(): Widgets.Widget1;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,7 @@ export declare module SpecializedWidget {
function createWidget2(): Widget2;
}
//// [privacyFunctionCannotNameParameterTypeDeclFile_exporter.d.ts]
/// <reference path='privacyFunctionCannotNameParameterTypeDeclFile_GlobalWidgets.d.ts' />
/// <reference path="privacyFunctionCannotNameParameterTypeDeclFile_GlobalWidgets.d.ts" />
import Widgets = require("privacyFunctionCannotNameParameterTypeDeclFile_Widgets");
import Widgets1 = require("GlobalWidgets");
export declare function createExportedWidget1(): Widgets.Widget1;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@ export declare module SpecializedWidget {
function createWidget2(): Widget2;
}
//// [privacyFunctionReturnTypeDeclFile_exporter.d.ts]
/// <reference path='privacyFunctionReturnTypeDeclFile_GlobalWidgets.d.ts' />
/// <reference path="privacyFunctionReturnTypeDeclFile_GlobalWidgets.d.ts" />
import Widgets = require("privacyFunctionReturnTypeDeclFile_Widgets");
import Widgets1 = require("GlobalWidgets");
export declare function createExportedWidget1(): Widgets.Widget1;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,8 @@ export declare class c_public {
bar: string;
}
//// [privacyTopLevelAmbientExternalModuleImportWithExport_core.d.ts]
/// <reference path='privacyTopLevelAmbientExternalModuleImportWithExport_require2.d.ts' />
/// <reference path='privacyTopLevelAmbientExternalModuleImportWithExport_require3.d.ts' />
/// <reference path="privacyTopLevelAmbientExternalModuleImportWithExport_require2.d.ts" />
/// <reference path="privacyTopLevelAmbientExternalModuleImportWithExport_require3.d.ts" />
export import im_public_mi_private = require("privacyTopLevelAmbientExternalModuleImportWithExport_require");
export import im_public_mu_private = require("privacyTopLevelAmbientExternalModuleImportWithExport_require1");
export import im_public_mi_public = require("m");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,8 @@ export declare class c_public {
bar: string;
}
//// [privacyTopLevelAmbientExternalModuleImportWithoutExport_core.d.ts]
/// <reference path='privacyTopLevelAmbientExternalModuleImportWithoutExport_require2.d.ts' />
/// <reference path='privacyTopLevelAmbientExternalModuleImportWithoutExport_require3.d.ts' />
/// <reference path="privacyTopLevelAmbientExternalModuleImportWithoutExport_require2.d.ts" />
/// <reference path="privacyTopLevelAmbientExternalModuleImportWithoutExport_require3.d.ts" />
import im_private_mi_private = require("m");
import im_private_mu_private = require("m2");
import im_private_mi_public = require("privacyTopLevelAmbientExternalModuleImportWithoutExport_require");
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/// <reference path='ref/m1.d.ts' />
/// <reference path='ref/m2.d.ts' />
/// <reference path="ref/m1.d.ts" />
/// <reference path="ref/m2.d.ts" />
declare var a1: number;
declare class c1 {
p1: number;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/// <reference path='ref/m1.d.ts' />
/// <reference path='ref/m2.d.ts' />
/// <reference path="ref/m1.d.ts" />
/// <reference path="ref/m2.d.ts" />
declare var a1: number;
declare class c1 {
p1: number;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/// <reference path='ref/m1.d.ts' />
/// <reference path='ref/m2.d.ts' />
/// <reference path="ref/m1.d.ts" />
/// <reference path="ref/m2.d.ts" />
declare var a1: number;
declare class c1 {
p1: number;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/// <reference path='ref/m1.d.ts' />
/// <reference path='ref/m2.d.ts' />
/// <reference path="ref/m1.d.ts" />
/// <reference path="ref/m2.d.ts" />
declare var a1: number;
declare class c1 {
p1: number;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/// <reference path='../ref/m2.d.ts' />
/// <reference path="../ref/m2.d.ts" />
declare var m1_a1: number;
declare class m1_c1 {
m1_c1_p1: number;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/// <reference path='../ref/m2.d.ts' />
/// <reference path="../ref/m2.d.ts" />
declare var m1_a1: number;
declare class m1_c1 {
m1_c1_p1: number;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/// <reference path='../outdir/outAndOutDirFolder/ref/m2.d.ts' />
/// <reference path="../outdir/outAndOutDirFolder/ref/m2.d.ts" />
declare var m1_a1: number;
declare class m1_c1 {
m1_c1_p1: number;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/// <reference path='../outdir/outAndOutDirFolder/ref/m2.d.ts' />
/// <reference path="../outdir/outAndOutDirFolder/ref/m2.d.ts" />
declare var m1_a1: number;
declare class m1_c1 {
m1_c1_p1: number;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/// <reference path='ref/m1.d.ts' />
/// <reference path='../outputdir_multifolder_ref/m2.d.ts' />
/// <reference path="ref/m1.d.ts" />
/// <reference path="../outputdir_multifolder_ref/m2.d.ts" />
declare var a1: number;
declare class c1 {
p1: number;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/// <reference path='ref/m1.d.ts' />
/// <reference path='../outputdir_multifolder_ref/m2.d.ts' />
/// <reference path="ref/m1.d.ts" />
/// <reference path="../outputdir_multifolder_ref/m2.d.ts" />
declare var a1: number;
declare class c1 {
p1: number;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/// <reference path='ref/m1.d.ts' />
/// <reference path='../outputdir_multifolder_ref/m2.d.ts' />
/// <reference path="ref/m1.d.ts" />
/// <reference path="../outputdir_multifolder_ref/m2.d.ts" />
declare var a1: number;
declare class c1 {
p1: number;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/// <reference path='ref/m1.d.ts' />
/// <reference path='../outputdir_multifolder_ref/m2.d.ts' />
/// <reference path="ref/m1.d.ts" />
/// <reference path="../outputdir_multifolder_ref/m2.d.ts" />
declare var a1: number;
declare class c1 {
p1: number;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/// <reference path='m1.d.ts' />
/// <reference path="m1.d.ts" />
declare var a1: number;
declare class c1 {
p1: number;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/// <reference path='m1.d.ts' />
/// <reference path="m1.d.ts" />
declare var a1: number;
declare class c1 {
p1: number;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/// <reference path='m1.d.ts' />
/// <reference path="m1.d.ts" />
declare var a1: number;
declare class c1 {
p1: number;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/// <reference path='m1.d.ts' />
/// <reference path="m1.d.ts" />
declare var a1: number;
declare class c1 {
p1: number;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/// <reference path='ref/m1.d.ts' />
/// <reference path="ref/m1.d.ts" />
declare var a1: number;
declare class c1 {
p1: number;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/// <reference path='ref/m1.d.ts' />
/// <reference path="ref/m1.d.ts" />
declare var a1: number;
declare class c1 {
p1: number;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/// <reference path='ref/m1.d.ts' />
/// <reference path="ref/m1.d.ts" />
declare var a1: number;
declare class c1 {
p1: number;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/// <reference path='ref/m1.d.ts' />
/// <reference path="ref/m1.d.ts" />
declare var a1: number;
declare class c1 {
p1: number;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/// <reference path='ref/m1.d.ts' />
/// <reference path='ref/m2.d.ts' />
/// <reference path="ref/m1.d.ts" />
/// <reference path="ref/m2.d.ts" />
declare var a1: number;
declare class c1 {
p1: number;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/// <reference path='ref/m1.d.ts' />
/// <reference path='ref/m2.d.ts' />
/// <reference path="ref/m1.d.ts" />
/// <reference path="ref/m2.d.ts" />
declare var a1: number;
declare class c1 {
p1: number;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/// <reference path='ref/m1.d.ts' />
/// <reference path='ref/m2.d.ts' />
/// <reference path="ref/m1.d.ts" />
/// <reference path="ref/m2.d.ts" />
declare var a1: number;
declare class c1 {
p1: number;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/// <reference path='ref/m1.d.ts' />
/// <reference path='ref/m2.d.ts' />
/// <reference path="ref/m1.d.ts" />
/// <reference path="ref/m2.d.ts" />
declare var a1: number;
declare class c1 {
p1: number;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/// <reference path='../ref/m2.d.ts' />
/// <reference path="../ref/m2.d.ts" />
declare var m1_a1: number;
declare class m1_c1 {
m1_c1_p1: number;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/// <reference path='../ref/m2.d.ts' />
/// <reference path="../ref/m2.d.ts" />
declare var m1_a1: number;
declare class m1_c1 {
m1_c1_p1: number;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/// <reference path='../outdir/outAndOutDirFolder/ref/m2.d.ts' />
/// <reference path="../outdir/outAndOutDirFolder/ref/m2.d.ts" />
declare var m1_a1: number;
declare class m1_c1 {
m1_c1_p1: number;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/// <reference path='../outdir/outAndOutDirFolder/ref/m2.d.ts' />
/// <reference path="../outdir/outAndOutDirFolder/ref/m2.d.ts" />
declare var m1_a1: number;
declare class m1_c1 {
m1_c1_p1: number;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/// <reference path='ref/m1.d.ts' />
/// <reference path='../outputdir_multifolder_ref/m2.d.ts' />
/// <reference path="ref/m1.d.ts" />
/// <reference path="../outputdir_multifolder_ref/m2.d.ts" />
declare var a1: number;
declare class c1 {
p1: number;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/// <reference path='ref/m1.d.ts' />
/// <reference path='../outputdir_multifolder_ref/m2.d.ts' />
/// <reference path="ref/m1.d.ts" />
/// <reference path="../outputdir_multifolder_ref/m2.d.ts" />
declare var a1: number;
declare class c1 {
p1: number;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/// <reference path='ref/m1.d.ts' />
/// <reference path='../outputdir_multifolder_ref/m2.d.ts' />
/// <reference path="ref/m1.d.ts" />
/// <reference path="../outputdir_multifolder_ref/m2.d.ts" />
declare var a1: number;
declare class c1 {
p1: number;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/// <reference path='ref/m1.d.ts' />
/// <reference path='../outputdir_multifolder_ref/m2.d.ts' />
/// <reference path="ref/m1.d.ts" />
/// <reference path="../outputdir_multifolder_ref/m2.d.ts" />
declare var a1: number;
declare class c1 {
p1: number;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/// <reference path='m1.d.ts' />
/// <reference path="m1.d.ts" />
declare var a1: number;
declare class c1 {
p1: number;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/// <reference path='m1.d.ts' />
/// <reference path="m1.d.ts" />
declare var a1: number;
declare class c1 {
p1: number;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/// <reference path='m1.d.ts' />
/// <reference path="m1.d.ts" />
declare var a1: number;
declare class c1 {
p1: number;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/// <reference path='m1.d.ts' />
/// <reference path="m1.d.ts" />
declare var a1: number;
declare class c1 {
p1: number;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/// <reference path='ref/m1.d.ts' />
/// <reference path="ref/m1.d.ts" />
declare var a1: number;
declare class c1 {
p1: number;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/// <reference path='ref/m1.d.ts' />
/// <reference path="ref/m1.d.ts" />
declare var a1: number;
declare class c1 {
p1: number;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/// <reference path='ref/m1.d.ts' />
/// <reference path="ref/m1.d.ts" />
declare var a1: number;
declare class c1 {
p1: number;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/// <reference path='ref/m1.d.ts' />
/// <reference path="ref/m1.d.ts" />
declare var a1: number;
declare class c1 {
p1: number;
Expand Down
Loading