Avoid incorrectly reusing assertion nodes from property assignments #60576

Andarist · 2024-11-24T18:16:33Z

fixes #60573 (a regression from #59282 )

typescript-bot · 2024-11-24T18:16:37Z

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

src/compiler/expressionToTypeNode.ts

…nodes-with-different-types

jakebailey · 2024-12-04T18:26:25Z

If this fixes #60573, we should definitely add a dts test that shows that things are fixed.

jakebailey · 2024-12-04T18:33:04Z

src/compiler/expressionToTypeNode.ts

+            if (assertionNode && !isConstTypeReference(assertionNode) && resolver.canReuseTypeNodeAnnotation(context, node, assertionNode, symbol)) {
+                result = serializeExistingTypeNode(assertionNode, context);


I was largely unsure about this given you ask a question about node then use that to work with assertionNode, but this is effectively the same check as:

function typeFromPropertyAssignment(node: PropertyAssignment | ShorthandPropertyAssignment, symbol: Symbol, context: SyntacticTypeNodeBuilderContext) { const typeAnnotation = getEffectiveTypeAnnotationNode(node); let result; if (typeAnnotation && resolver.canReuseTypeNodeAnnotation(context, node, typeAnnotation, symbol)) { result = serializeExistingTypeNode(typeAnnotation, context); }

So I definitely like this change more than the initial version.

jakebailey · 2024-12-04T18:33:14Z

@typescript-bot test it

typescript-bot · 2024-12-04T18:33:19Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-12-04T18:55:55Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-12-04T18:56:29Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/60576/merge:

Everything looks good!

…nodes-with-different-types

typescript-bot · 2024-12-04T19:16:31Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,363	_62,363	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,395	_50,395	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{194,233k (± 0.95%)}	_{194,267k (± 0.97%)}	_~	_193,042k	_196,713k	_{p=0.748 n=6}
_{Parse Time}	_{1.30s (± 1.15%)}	_{1.31s (± 0.68%)}	_~	_1.30s	_1.32s	_{p=0.456 n=6}
_{Bind Time}	_0.72s	_0.72s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.78s (± 0.36%)}	_{9.79s (± 0.46%)}	_~	_9.72s	_9.85s	_{p=0.872 n=6}
_{Emit Time}	_{2.73s (± 0.38%)}	_{2.73s (± 0.65%)}	_~	_2.71s	_2.76s	_{p=0.805 n=6}
_{Total Time}	_{14.53s (± 0.29%)}	_{14.54s (± 0.41%)}	_~	_14.48s	_14.64s	_{p=0.936 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₇	₃₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,936	_947,936	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,955	_410,955	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,226,007k (± 0.00%)}	_{1,226,016k (± 0.00%)}	_~	_1,225,935k	_1,226,080k	_{p=0.575 n=6}
_{Parse Time}	_{6.63s (± 0.55%)}	_{6.64s (± 0.52%)}	_~	_6.58s	_6.68s	_{p=0.871 n=6}
_{Bind Time}	_{1.89s (± 0.22%)}	_{1.89s (± 0.58%)}	_~	_1.88s	_1.91s	_{p=1.000 n=6}
_{Check Time}	_{32.00s (± 0.34%)}	_{31.96s (± 0.33%)}	_~	_31.87s	_32.15s	_{p=0.517 n=6}
_{Emit Time}	_{15.22s (± 0.37%)}	_{15.18s (± 0.31%)}	_~	_15.10s	_15.22s	_{p=0.167 n=6}
_{Total Time}	_{55.74s (± 0.25%)}	_{55.66s (± 0.25%)}	_~	_55.48s	_55.86s	_{p=0.471 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,501,823	_2,501,823	_~	_~	_~	_{p=1.000 n=6}
_Types	_909,645	_909,645	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,319,287k (± 0.00%)}	_{2,319,273k (± 0.00%)}	_~	_2,319,207k	_2,319,317k	_{p=0.378 n=6}
_{Parse Time}	_{9.30s (± 0.18%)}	_{9.30s (± 0.23%)}	_~	_9.28s	_9.33s	_{p=0.514 n=6}
_{Bind Time}	_{2.16s (± 0.83%)}	_{2.15s (± 0.97%)}	_~	_2.12s	_2.18s	_{p=0.452 n=6}
_{Check Time}	_{74.95s (± 0.23%)}	_{74.98s (± 0.37%)}	_~	_74.57s	_75.42s	_{p=0.936 n=6}
_{Emit Time}	_0.28s	_{0.28s (± 3.53%)}	_~	_0.27s	_0.29s	_{p=0.652 n=6}
_{Total Time}	_{86.69s (± 0.21%)}	_{86.72s (± 0.32%)}	_~	_86.31s	_87.17s	_{p=0.686 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,287	_1,225,287	_~	_~	_~	_{p=1.000 n=6}
_Types	_266,555	_266,555	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,354,218k (± 0.03%)}	_{2,354,129k (± 0.02%)}	_~	_2,353,675k	_2,354,651k	_{p=0.810 n=6}
_{Parse Time}	_{5.23s (± 0.59%)}	_{5.25s (± 0.44%)}	_~	_5.23s	_5.29s	_{p=0.683 n=6}
_{Bind Time}	_{1.77s (± 1.57%)}	_{1.78s (± 1.56%)}	_~	_1.76s	_1.83s	_{p=0.746 n=6}
_{Check Time}	_{35.19s (± 0.65%)}	_{35.19s (± 0.44%)}	_~	_35.07s	_35.49s	_{p=0.873 n=6}
_{Emit Time}	_{2.97s (± 1.21%)}	_{3.02s (± 3.00%)}	_~	_2.95s	_3.19s	_{p=0.630 n=6}
_{Total Time}	_{45.17s (± 0.53%)}	_{45.25s (± 0.55%)}	_~	_45.10s	_45.74s	_{p=0.298 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,287	_1,225,287	_~	_~	_~	_{p=1.000 n=6}
_Types	_266,555	_266,555	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,907,885k (±12.87%)}	_{2,786,589k (±14.24%)}	_~	_2,423,271k	_3,150,329k	_{p=0.298 n=6}
_{Parse Time}	_{6.97s (± 1.41%)}	_{6.91s (± 2.01%)}	_~	_6.77s	_7.08s	_{p=0.575 n=6}
_{Bind Time}	_{2.16s (± 1.67%)}	_{2.16s (± 1.82%)}	_~	_2.10s	_2.20s	_{p=1.000 n=6}
_{Check Time}	_{42.73s (± 0.76%)}	_{42.80s (± 0.52%)}	_~	_42.60s	_43.21s	_{p=1.000 n=6}
_{Emit Time}	_{3.48s (± 2.40%)}	_{3.57s (± 5.02%)}	_~	_3.40s	_3.83s	_{p=0.575 n=6}
_{Total Time}	_{55.37s (± 0.76%)}	_{55.43s (± 0.53%)}	_~	_55.01s	_55.91s	_{p=0.810 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_262,259	_262,259	_~	_~	_~	_{p=1.000 n=6}
_Types	_106,616	_106,616	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{439,871k (± 0.01%)}	_{439,875k (± 0.01%)}	_~	_439,813k	_439,921k	_{p=0.748 n=6}
_{Parse Time}	_{3.54s (± 0.52%)}	_{3.52s (± 0.69%)}	_~	_3.50s	_3.56s	_{p=0.164 n=6}
_{Bind Time}	_{1.31s (± 0.89%)}	_{1.31s (± 0.89%)}	_~	_1.30s	_1.33s	_{p=1.000 n=6}
_{Check Time}	_{18.96s (± 0.50%)}	_{18.87s (± 0.36%)}	_~	_18.79s	_18.98s	_{p=0.093 n=6}
_{Emit Time}	_{1.52s (± 1.56%)}	_{1.54s (± 0.89%)}	_~	_1.52s	_1.56s	_{p=0.191 n=6}
_{Total Time}	_{25.33s (± 0.45%)}	_{25.24s (± 0.25%)}	_~	_25.16s	_25.34s	_{p=0.173 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₀	₇₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_226,062	_226,062	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,488	_94,488	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,772k (± 0.07%)}	_{371,606k (± 0.05%)}	_~	_371,472k	_371,958k	_{p=0.173 n=6}
_{Parse Time}	_{2.92s (± 1.14%)}	_{2.88s (± 1.45%)}	_~	_2.82s	_2.94s	_{p=0.199 n=6}
_{Bind Time}	_{1.58s (± 0.74%)}	_{1.59s (± 1.01%)}	_~	_1.57s	_1.61s	_{p=0.285 n=6}
_{Check Time}	_{16.53s (± 0.41%)}	_{16.48s (± 0.16%)}	_~	_16.44s	_16.50s	_{p=0.327 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_0.00s	_~	_~	_~	_{p=0.405 n=6}
_{Total Time}	_{21.03s (± 0.32%)}	_{20.96s (± 0.28%)}	_~	_20.89s	_21.04s	_{p=0.108 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,197,663	_3,197,663	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,099,162	_1,099,162	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,271,365k (± 0.01%)}	_{3,271,502k (± 0.01%)}	_~	_3,271,145k	_3,272,144k	_{p=0.173 n=6}
_{Parse Time}	_{14.08s (± 0.49%)}	_{14.11s (± 0.53%)}	_~	_14.02s	_14.23s	_{p=0.688 n=6}
_{Bind Time}	_{4.54s (± 0.37%)}	_{4.52s (± 0.28%)}	_{-0.02s (- 0.44%)}	_4.51s	_4.54s	_{p=0.048 n=6}
_{Check Time}	_{88.17s (± 1.86%)}	_{87.70s (± 1.90%)}	_~	_86.28s	_90.15s	_{p=0.689 n=6}
_{Emit Time}	_{28.27s (± 2.92%)}	_{27.60s (± 8.67%)}	_~	_22.81s	_29.12s	_{p=1.000 n=6}
_{Total Time}	_{135.07s (± 0.95%)}	_{133.93s (± 1.01%)}	_~	_131.70s	_135.77s	_{p=0.173 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_288,751	_288,751	_~	_~	_~	_{p=1.000 n=6}
_Types	_117,157	_117,157	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{441,035k (± 0.03%)}	_{441,029k (± 0.03%)}	_~	_440,839k	_441,224k	_{p=1.000 n=6}
_{Parse Time}	_{4.06s (± 0.83%)}	_{4.08s (± 0.78%)}	_~	_4.03s	_4.12s	_{p=0.376 n=6}
_{Bind Time}	_{1.76s (± 2.28%)}	_{1.77s (± 1.82%)}	_~	_1.74s	_1.82s	_{p=0.687 n=6}
_{Check Time}	_{18.90s (± 0.75%)}	_{18.92s (± 0.55%)}	_~	_18.72s	_19.00s	_{p=1.000 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.72s (± 0.64%)}	_{24.77s (± 0.48%)}	_~	_24.57s	_24.91s	_{p=0.810 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_552,390	_552,390	_~	_~	_~	_{p=1.000 n=6}
_Types	_185,096	_185,096	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{492,463k (± 0.02%)}	_{492,518k (± 0.01%)}	_~	_492,450k	_492,614k	_{p=0.936 n=6}
_{Parse Time}	_{3.41s (± 1.01%)}	_{3.41s (± 0.86%)}	_~	_3.36s	_3.45s	_{p=0.935 n=6}
_{Bind Time}	_{1.18s (± 0.69%)}	_{1.17s (± 1.03%)}	_~	_1.15s	_1.18s	_{p=1.000 n=6}
_{Check Time}	_{19.55s (± 1.11%)}	_{19.66s (± 2.43%)}	_~	_19.34s	_20.62s	_{p=0.810 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.14s (± 0.88%)}	_{24.25s (± 2.00%)}	_~	_23.95s	_25.22s	_{p=1.000 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

jakebailey · 2024-12-04T19:21:47Z

@typescript-bot pack this

typescript-bot · 2024-12-04T19:24:11Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`pack this`	✅ Started

Andarist · 2024-12-04T19:42:52Z

tests/baselines/reference/declarationAssertionNodeNotReusedWhenTypeNotEquivalent1.js

+//// [declarationAssertionNodeNotReusedWhenTypeNotEquivalent1.d.ts]
+export declare const unwrapped: {
+    prop1: "hello";
+};


@jakebailey here is the requested dts test

weswigham

Yeah, this looks solid now. It'd probably be relevant to ask what output this limits under isolatedDeclarations, but... 🤷‍♂️ it kinda is what it is.

typescript-bot · 2024-12-04T19:51:57Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60576/merge:

Everything looks good!

jakebailey · 2024-12-04T19:52:36Z

@typescript-bot pack this

typescript-bot · 2024-12-04T19:52:42Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`pack this`	✅ Started	✅ Results

typescript-bot · 2024-12-04T19:54:51Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/164278/artifacts?artifactName=tgz&fileId=579FD5D10F806287DEC373A9533F60476A5F5163C508B9047F1A00060D2FA2A002&fileName=/typescript-5.8.0-insiders.20241204.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.8.0-pr-60576-12".;

typescript-bot · 2024-12-04T20:03:54Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/60576/merge:

Everything looks good!

jakebailey · 2024-12-04T20:04:29Z

@typescript-bot cherry-pick this to release-5.7

typescript-bot · 2024-12-04T20:04:34Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`cherry-pick this to release-5.7`	✅ Started	✅ Results

…60576)

typescript-bot · 2024-12-04T20:06:07Z

Hey, @jakebailey! I've created #60679 for you.

…e-5.7 (#60679) Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>

Avoid incorrectly reusing assertion nodes from property assignments

a2e2f05

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Nov 24, 2024

Andarist commented Nov 24, 2024

View reviewed changes

src/compiler/expressionToTypeNode.ts Outdated Show resolved Hide resolved

Andarist mentioned this pull request Nov 24, 2024

Type assertion regression in TypeScript 5.7 #60573

Closed

Andarist added 2 commits December 4, 2024 13:28

Merge remote-tracking branch 'origin/main' into dont-reuse-assertion-…

a2db14d

…nodes-with-different-types

improve the fix

8282c6d

typescript-bot added For Milestone Bug PRs that fix a bug with a specific milestone and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Dec 4, 2024

remove obsolete import

1175802

jakebailey reviewed Dec 4, 2024

View reviewed changes

Merge remote-tracking branch 'origin/main' into dont-reuse-assertion-…

f001c49

…nodes-with-different-types

add dts test

0407bd6

Andarist commented Dec 4, 2024

View reviewed changes

weswigham approved these changes Dec 4, 2024

View reviewed changes

jakebailey approved these changes Dec 4, 2024

View reviewed changes

jakebailey merged commit 676d329 into microsoft:main Dec 4, 2024
32 checks passed

typescript-bot pushed a commit that referenced this pull request Dec 4, 2024

Avoid incorrectly reusing assertion nodes from property assignments (#…

c2fff85

…60576)

typescript-bot mentioned this pull request Dec 4, 2024

🤖 Pick PR #60576 (Avoid incorrectly reusing assertion...) into release-5.7 #60679

Merged

weswigham mentioned this pull request Dec 4, 2024

Regression in DTS generation between TypeScript 5.6 and 5.7 #60506

Closed

DanielRosenwasser pushed a commit that referenced this pull request Dec 11, 2024

🤖 Pick PR #60576 (Avoid incorrectly reusing assertion...) into releas…

b82fd16

…e-5.7 (#60679) Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Avoid incorrectly reusing assertion nodes from property assignments #60576

Avoid incorrectly reusing assertion nodes from property assignments #60576

Andarist commented Nov 24, 2024 •

edited

Loading

typescript-bot commented Nov 24, 2024

jakebailey commented Dec 4, 2024

jakebailey Dec 4, 2024

jakebailey commented Dec 4, 2024

typescript-bot commented Dec 4, 2024 •

edited

Loading

typescript-bot commented Dec 4, 2024

typescript-bot commented Dec 4, 2024

typescript-bot commented Dec 4, 2024

tsc

jakebailey commented Dec 4, 2024

typescript-bot commented Dec 4, 2024 •

edited

Loading

Andarist Dec 4, 2024

weswigham left a comment

typescript-bot commented Dec 4, 2024

jakebailey commented Dec 4, 2024

typescript-bot commented Dec 4, 2024 •

edited

Loading

typescript-bot commented Dec 4, 2024 •

edited

Loading

typescript-bot commented Dec 4, 2024

jakebailey commented Dec 4, 2024

typescript-bot commented Dec 4, 2024 •

edited

Loading

typescript-bot commented Dec 4, 2024

		if (assertionNode && !isConstTypeReference(assertionNode) && resolver.canReuseTypeNodeAnnotation(context, node, assertionNode, symbol)) {
		result = serializeExistingTypeNode(assertionNode, context);

Avoid incorrectly reusing assertion nodes from property assignments #60576

Avoid incorrectly reusing assertion nodes from property assignments #60576

Conversation

Andarist commented Nov 24, 2024 • edited Loading

typescript-bot commented Nov 24, 2024

jakebailey commented Dec 4, 2024

jakebailey Dec 4, 2024

Choose a reason for hiding this comment

jakebailey commented Dec 4, 2024

typescript-bot commented Dec 4, 2024 • edited Loading

typescript-bot commented Dec 4, 2024

typescript-bot commented Dec 4, 2024

typescript-bot commented Dec 4, 2024

tsc

jakebailey commented Dec 4, 2024

typescript-bot commented Dec 4, 2024 • edited Loading

Andarist Dec 4, 2024

Choose a reason for hiding this comment

weswigham left a comment

Choose a reason for hiding this comment

typescript-bot commented Dec 4, 2024

jakebailey commented Dec 4, 2024

typescript-bot commented Dec 4, 2024 • edited Loading

typescript-bot commented Dec 4, 2024 • edited Loading

typescript-bot commented Dec 4, 2024

jakebailey commented Dec 4, 2024

typescript-bot commented Dec 4, 2024 • edited Loading

typescript-bot commented Dec 4, 2024

Andarist commented Nov 24, 2024 •

edited

Loading

typescript-bot commented Dec 4, 2024 •

edited

Loading

typescript-bot commented Dec 4, 2024 •

edited

Loading

typescript-bot commented Dec 4, 2024 •

edited

Loading

typescript-bot commented Dec 4, 2024 •

edited

Loading

typescript-bot commented Dec 4, 2024 •

edited

Loading