Fixed syntactic nullisness semantics for tagged template expressions #60616

Andarist · 2024-11-26T20:28:31Z

jakebailey · 2024-11-26T20:33:54Z

typescript-bot · 2024-11-26T20:33:59Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-11-26T21:02:14Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-11-26T21:15:22Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/60616/merge:

Everything looks good!

typescript-bot · 2024-11-26T21:16:07Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,363	_62,363	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,395	_50,395	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{194,356k (± 0.92%)}	_{193,030k (± 0.01%)}	_~	_192,997k	_193,047k	_{p=0.128 n=6}
_{Parse Time}	_{1.29s (± 1.06%)}	_{1.32s (± 0.39%)}	_{+0.02s (+ 1.80%)}	_1.31s	_1.32s	_{p=0.022 n=6}
_{Bind Time}	_0.72s	_0.72s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.83s (± 0.20%)}	_{9.81s (± 0.64%)}	_~	_9.69s	_9.87s	_{p=0.742 n=6}
_{Emit Time}	_{2.73s (± 0.44%)}	_{2.73s (± 0.59%)}	_~	_2.70s	_2.74s	_{p=1.000 n=6}
_{Total Time}	_{14.57s (± 0.28%)}	_{14.58s (± 0.45%)}	_~	_14.46s	_14.65s	_{p=0.687 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₇	₃₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,936	_947,936	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,955	_410,955	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,226,042k (± 0.00%)}	_{1,226,027k (± 0.00%)}	_~	_1,225,994k	_1,226,061k	_{p=0.748 n=6}
_{Parse Time}	_{6.65s (± 0.58%)}	_{6.66s (± 0.83%)}	_~	_6.55s	_6.70s	_{p=0.466 n=6}
_{Bind Time}	_{1.88s (± 0.29%)}	_{1.88s (± 0.43%)}	_~	_1.87s	_1.89s	_{p=0.859 n=6}
_{Check Time}	_{31.87s (± 0.10%)}	_{31.96s (± 0.30%)}	_~	_31.82s	_32.08s	_{p=0.126 n=6}
_{Emit Time}	_{15.22s (± 0.38%)}	_{15.22s (± 0.24%)}	_~	_15.18s	_15.27s	_{p=1.000 n=6}
_{Total Time}	_{55.61s (± 0.14%)}	_{55.72s (± 0.21%)}	_~	_55.59s	_55.87s	_{p=0.173 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,500,013	_2,500,013	_~	_~	_~	_{p=1.000 n=6}
_Types	_909,416	_909,416	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,318,018k (± 0.00%)}	_{2,318,213k (± 0.01%)}	_{+195k (+ 0.01%)}	_2,318,096k	_2,318,509k	_{p=0.008 n=6}
_{Parse Time}	_{11.16s (± 0.83%)}	_{11.19s (± 0.35%)}	_~	_11.16s	_11.27s	_{p=0.872 n=6}
_{Bind Time}	_{2.64s (± 0.70%)}	_{2.63s (± 0.40%)}	_~	_2.61s	_2.64s	_{p=0.086 n=6}
_{Check Time}	_{91.17s (± 2.19%)}	_{90.72s (± 1.39%)}	_~	_89.27s	_92.58s	_{p=0.936 n=6}
_{Emit Time}	_{0.35s (± 2.16%)}	_{0.36s (± 2.08%)}	_{+0.01s (+ 3.83%)}	_0.35s	_0.37s	_{p=0.024 n=6}
_{Total Time}	_{105.32s (± 1.85%)}	_{104.89s (± 1.20%)}	_~	_103.43s	_106.74s	_{p=1.000 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,251	_1,225,251	_~	_~	_~	_{p=1.000 n=6}
_Types	_266,545	_266,545	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,720,992k (±14.64%)}	_{2,841,774k (±13.20%)}	_~	_2,356,785k	_3,084,967k	_{p=0.873 n=6}
_{Parse Time}	_{6.69s (± 1.63%)}	_{6.71s (± 1.88%)}	_~	_6.57s	_6.89s	_{p=0.810 n=6}
_{Bind Time}	_{2.13s (± 0.91%)}	_{2.13s (± 0.91%)}	_~	_2.10s	_2.15s	_{p=0.687 n=6}
_{Check Time}	_{42.51s (± 0.38%)}	_{42.60s (± 0.50%)}	_~	_42.32s	_42.92s	_{p=0.471 n=6}
_{Emit Time}	_{3.39s (± 1.16%)}	_{3.52s (± 3.50%)}	_{+0.13s (+ 3.83%)}	_3.42s	_3.74s	_{p=0.037 n=6}
_{Total Time}	_{54.73s (± 0.45%)}	_{54.98s (± 0.42%)}	_~	_54.64s	_55.25s	_{p=0.149 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,251	_1,225,251	_~	_~	_~	_{p=1.000 n=6}
_Types	_266,545	_266,545	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,907,326k (±12.88%)}	_{3,149,634k (± 0.03%)}	_~	_3,148,316k	_3,150,854k	_{p=0.128 n=6}
_{Parse Time}	_{6.94s (± 1.71%)}	_{7.03s (± 0.98%)}	_~	_6.93s	_7.10s	_{p=0.261 n=6}
_{Bind Time}	_{2.16s (± 1.57%)}	_{2.14s (± 1.57%)}	_~	_2.11s	_2.19s	_{p=0.418 n=6}
_{Check Time}	_{42.75s (± 0.38%)}	_{42.79s (± 0.56%)}	_~	_42.42s	_43.05s	_{p=0.575 n=6}
_{Emit Time}	_{3.45s (± 1.84%)}	_{3.46s (± 3.38%)}	_~	_3.32s	_3.64s	_{p=1.000 n=6}
_{Total Time}	_{55.28s (± 0.43%)}	_{55.42s (± 0.24%)}	_~	_55.18s	_55.53s	_{p=0.336 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_262,223	_262,223	_~	_~	_~	_{p=1.000 n=6}
_Types	_106,606	_106,606	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{439,757k (± 0.01%)}	_{439,793k (± 0.01%)}	_~	_439,713k	_439,881k	_{p=0.471 n=6}
_{Parse Time}	_{3.54s (± 0.79%)}	_{3.56s (± 1.03%)}	_~	_3.52s	_3.61s	_{p=0.256 n=6}
_{Bind Time}	_{1.32s (± 2.77%)}	_{1.31s (± 1.04%)}	_~	_1.30s	_1.33s	_{p=0.934 n=6}
_{Check Time}	_{18.94s (± 0.48%)}	_{18.92s (± 0.41%)}	_~	_18.83s	_19.03s	_{p=0.630 n=6}
_{Emit Time}	_{1.53s (± 0.87%)}	_{1.52s (± 0.68%)}	_~	_1.51s	_1.54s	_{p=0.301 n=6}
_{Total Time}	_{25.33s (± 0.52%)}	_{25.32s (± 0.32%)}	_~	_25.19s	_25.40s	_{p=0.809 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₀	₇₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_226,062	_226,062	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,488	_94,488	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,686k (± 0.03%)}	_{371,595k (± 0.01%)}	_~	_371,566k	_371,667k	_{p=0.065 n=6}
_{Parse Time}	_{2.88s (± 1.15%)}	_{2.88s (± 1.41%)}	_~	_2.85s	_2.96s	_{p=0.871 n=6}
_{Bind Time}	_{1.59s (± 0.89%)}	_{1.58s (± 0.76%)}	_~	_1.57s	_1.60s	_{p=0.458 n=6}
_{Check Time}	_{16.49s (± 0.46%)}	_{16.52s (± 0.40%)}	_~	_16.43s	_16.61s	_{p=0.630 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.96s (± 0.42%)}	_{20.98s (± 0.47%)}	_~	_20.87s	_21.14s	_{p=0.809 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₄	₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,179,733	_3,179,733	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,093,537	_1,093,537	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,254,653k (± 0.01%)}	_{3,254,834k (± 0.01%)}	_~	_3,254,390k	_3,255,424k	_{p=1.000 n=6}
_{Parse Time}	_{14.13s (± 0.19%)}	_{14.07s (± 0.33%)}	_{-0.06s (- 0.41%)}	_14.01s	_14.13s	_{p=0.029 n=6}
_{Bind Time}	_{4.52s (± 0.80%)}	_{4.50s (± 0.61%)}	_~	_4.47s	_4.55s	_{p=0.466 n=6}
_{Check Time}	_{87.01s (± 1.60%)}	_{87.53s (± 1.83%)}	_~	_85.96s	_90.11s	_{p=0.575 n=6}
_{Emit Time}	_{27.41s (± 7.82%)}	_{27.37s (± 8.00%)}	_~	_23.08s	_28.88s	_{p=0.936 n=6}
_{Total Time}	_{133.06s (± 0.66%)}	_{133.48s (± 0.93%)}	_~	_131.74s	_134.80s	_{p=0.298 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_288,684	_288,684	_~	_~	_~	_{p=1.000 n=6}
_Types	_117,136	_117,136	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{440,706k (± 0.01%)}	_{440,667k (± 0.02%)}	_~	_440,596k	_440,765k	_{p=0.298 n=6}
_{Parse Time}	_{3.27s (± 0.16%)}	_{3.27s (± 0.23%)}	_~	_3.26s	_3.28s	_{p=0.241 n=6}
_{Bind Time}	_{1.47s (± 0.35%)}	_{1.47s (± 0.51%)}	_~	_1.46s	_1.48s	_{p=0.241 n=6}
_{Check Time}	_{15.62s (± 0.31%)}	_{15.60s (± 0.42%)}	_~	_15.49s	_15.66s	_{p=0.629 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.36s (± 0.22%)}	_{20.34s (± 0.31%)}	_~	_20.24s	_20.40s	_{p=0.560 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₈	₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_551,583	_551,583	_~	_~	_~	_{p=1.000 n=6}
_Types	_184,808	_184,808	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{491,878k (± 0.02%)}	_{491,874k (± 0.01%)}	_~	_491,783k	_491,921k	_{p=0.471 n=6}
_{Parse Time}	_{3.44s (± 0.80%)}	_{3.43s (± 0.65%)}	_~	_3.40s	_3.45s	_{p=1.000 n=6}
_{Bind Time}	_{1.18s (± 1.07%)}	_{1.18s (± 1.07%)}	_~	_1.16s	_1.19s	_{p=1.000 n=6}
_{Check Time}	_{19.71s (± 1.11%)}	_{19.64s (± 0.18%)}	_~	_19.61s	_19.70s	_{p=0.872 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_{0.00s (±244.70%)}	_~	_0.00s	_0.01s	_{p=1.000 n=6}
_{Total Time}	_{24.33s (± 0.92%)}	_{24.25s (± 0.16%)}	_~	_24.19s	_24.29s	_{p=1.000 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

jakebailey

I think this is right, though a shame. At least regular template strings are not affected.

typescript-bot · 2024-11-26T22:31:42Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60616/merge:

Everything looks good!

jakebailey · 2024-11-27T00:28:34Z

@typescript-bot cherry-pick this to release-5.7

typescript-bot · 2024-11-27T00:28:38Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`cherry-pick this to release-5.7`	✅ Started	❌ Results

typescript-bot · 2024-11-27T00:30:21Z

Hey, @jakebailey! I was unable to cherry-pick this PR.

Check the logs at: https://github.com/microsoft/TypeScript/actions/runs/12041395613

jakebailey · 2024-12-16T19:43:54Z

This failed to cherry pick because these two are not in the release branch:

…icrosoft#60616)

Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com> Co-authored-by: Ryan Cavanaugh <RyanCavanaugh@users.noreply.github.com>

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Nov 26, 2024

Fixed syntactic nullisness semantics for tagged template expressions

4a63167

Andarist force-pushed the fix/nullish-syntactic-semantics-tagged-templates branch from b918877 to 4a63167 Compare November 26, 2024 20:29

jakebailey requested a review from RyanCavanaugh November 26, 2024 21:48

jakebailey approved these changes Nov 26, 2024

View reviewed changes

RyanCavanaugh merged commit 9fe6c36 into microsoft:main Nov 26, 2024
30 checks passed

Andarist deleted the fix/nullish-syntactic-semantics-tagged-templates branch November 27, 2024 06:21

jakebailey pushed a commit to jakebailey/TypeScript that referenced this pull request Dec 16, 2024

Fixed syntactic nullisness semantics for tagged template expressions (m…

75372aa

…icrosoft#60616)

DanielRosenwasser pushed a commit that referenced this pull request Dec 17, 2024

Cherry-pick #60402, #60440, #60616 into release-5.7 (#60777)

e844dc3

Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com> Co-authored-by: Ryan Cavanaugh <RyanCavanaugh@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed syntactic nullisness semantics for tagged template expressions #60616

Fixed syntactic nullisness semantics for tagged template expressions #60616

Andarist commented Nov 26, 2024

jakebailey commented Nov 26, 2024

typescript-bot commented Nov 26, 2024 •

edited

Loading

typescript-bot commented Nov 26, 2024

typescript-bot commented Nov 26, 2024

typescript-bot commented Nov 26, 2024

tsc

jakebailey left a comment

typescript-bot commented Nov 26, 2024

jakebailey commented Nov 27, 2024

typescript-bot commented Nov 27, 2024 •

edited

Loading

typescript-bot commented Nov 27, 2024

jakebailey commented Dec 16, 2024

Fixed syntactic nullisness semantics for tagged template expressions #60616

Fixed syntactic nullisness semantics for tagged template expressions #60616

Conversation

Andarist commented Nov 26, 2024

jakebailey commented Nov 26, 2024

typescript-bot commented Nov 26, 2024 • edited Loading

typescript-bot commented Nov 26, 2024

typescript-bot commented Nov 26, 2024

typescript-bot commented Nov 26, 2024

tsc

jakebailey left a comment

Choose a reason for hiding this comment

typescript-bot commented Nov 26, 2024

jakebailey commented Nov 27, 2024

typescript-bot commented Nov 27, 2024 • edited Loading

typescript-bot commented Nov 27, 2024

jakebailey commented Dec 16, 2024

typescript-bot commented Nov 26, 2024 •

edited

Loading

typescript-bot commented Nov 27, 2024 •

edited

Loading