Disallow confusing combinations of !in and !instanceof #60628

bgenia · 2024-11-27T20:39:41Z

Disallows !in and !instanceof sequences.

jakebailey · 2024-11-27T20:42:16Z

src/compiler/scanner.ts

@@ -1967,7 +1967,18 @@ export function createScanner(
                        }
                        return pos += 2, token = SyntaxKind.ExclamationEqualsToken;
                    }
+                    const hasLeadingWhitespace = charCodeChecked(pos - 1) === CharacterCodes.space;


This doesn't seem like the right check; the character could be a tab or other character. I think we have a helper for this sort of check.

Thanks; you'll probably want a test with a tab in it just to verify.

jakebailey · 2024-11-27T20:52:16Z

@typescript-bot test it

typescript-bot · 2024-11-27T20:52:21Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-11-27T21:10:44Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/60628/merge:

Everything looks good!

typescript-bot · 2024-11-27T21:13:24Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-11-27T21:34:37Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,363	_62,363	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,395	_50,395	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,039k (± 0.01%)}	_{194,276k (± 0.97%)}	_{+1,236k (+ 0.64%)}	_193,051k	_196,714k	_{p=0.013 n=6}
_{Parse Time}	_{1.30s (± 0.94%)}	_{1.33s (± 0.88%)}	_{+0.03s (+ 2.04%)}	_1.31s	_1.34s	_{p=0.012 n=6}
_{Bind Time}	_0.72s	_0.72s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.79s (± 0.25%)}	_{9.82s (± 0.27%)}	_~	_9.78s	_9.85s	_{p=0.145 n=6}
_{Emit Time}	_{2.73s (± 0.50%)}	_{2.74s (± 0.89%)}	_~	_2.71s	_2.78s	_{p=0.682 n=6}
_{Total Time}	_{14.55s (± 0.12%)}	_{14.61s (± 0.08%)}	_{+0.05s (+ 0.37%)}	_14.59s	_14.62s	_{p=0.005 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₇	₃₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,936	_947,936	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,955	_410,955	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,226,015k (± 0.00%)}	_{1,226,020k (± 0.00%)}	_~	_1,225,972k	_1,226,082k	_{p=0.936 n=6}
_{Parse Time}	_{6.65s (± 0.71%)}	_{6.62s (± 0.46%)}	_~	_6.57s	_6.66s	_{p=0.419 n=6}
_{Bind Time}	_{1.89s (± 0.27%)}	_{1.89s (± 0.22%)}	_~	_1.88s	_1.89s	_{p=0.595 n=6}
_{Check Time}	_{32.03s (± 0.28%)}	_{32.06s (± 0.27%)}	_~	_31.96s	_32.17s	_{p=0.575 n=6}
_{Emit Time}	_{15.15s (± 0.61%)}	_{15.20s (± 0.49%)}	_~	_15.10s	_15.28s	_{p=0.575 n=6}
_{Total Time}	_{55.72s (± 0.30%)}	_{55.77s (± 0.19%)}	_~	_55.67s	_55.96s	_{p=0.748 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,500,182	_2,500,182	_~	_~	_~	_{p=1.000 n=6}
_Types	_909,474	_909,474	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,318,036k (± 0.00%)}	_{2,318,034k (± 0.00%)}	_~	_2,317,999k	_2,318,056k	_{p=0.630 n=6}
_{Parse Time}	_{9.28s (± 0.40%)}	_{9.29s (± 0.13%)}	_~	_9.27s	_9.30s	_{p=0.089 n=6}
_{Bind Time}	_{2.17s (± 0.71%)}	_{2.16s (± 0.68%)}	_~	_2.15s	_2.19s	_{p=0.401 n=6}
_{Check Time}	_{74.82s (± 0.43%)}	_{74.72s (± 0.54%)}	_~	_74.01s	_75.16s	_{p=0.810 n=6}
_{Emit Time}	_{0.29s (± 2.61%)}	_{0.29s (± 4.22%)}	_~	_0.27s	_0.30s	_{p=0.867 n=6}
_{Total Time}	_{86.56s (± 0.38%)}	_{86.46s (± 0.45%)}	_~	_85.75s	_86.88s	_{p=0.748 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,251	_1,225,281	_{+30 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,546	_266,563	_{+17 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,354,228k (± 0.02%)}	_{2,354,585k (± 0.02%)}	_~	_2,353,834k	_2,355,244k	_{p=0.173 n=6}
_{Parse Time}	_{5.23s (± 0.99%)}	_{5.29s (± 0.95%)}	_~	_5.22s	_5.37s	_{p=0.093 n=6}
_{Bind Time}	_{1.76s (± 1.21%)}	_{1.76s (± 1.24%)}	_~	_1.73s	_1.79s	_{p=1.000 n=6}
_{Check Time}	_{35.17s (± 0.22%)}	_{35.19s (± 0.25%)}	_~	_35.08s	_35.30s	_{p=0.936 n=6}
_{Emit Time}	_{2.98s (± 0.64%)}	_{2.97s (± 1.14%)}	_~	_2.92s	_3.01s	_{p=1.000 n=6}
_{Total Time}	_{45.16s (± 0.16%)}	_{45.22s (± 0.27%)}	_~	_45.08s	_45.37s	_{p=0.689 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,251	_1,225,281	_{+30 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,546	_266,563	_{+17 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,907,664k (±12.88%)}	_{3,149,840k (± 0.02%)}	_~	_3,149,113k	_3,151,110k	_{p=0.230 n=6}
_{Parse Time}	_{6.94s (± 1.91%)}	_{7.05s (± 0.74%)}	_~	_7.00s	_7.14s	_{p=0.078 n=6}
_{Bind Time}	_{2.15s (± 1.83%)}	_{2.14s (± 1.70%)}	_~	_2.09s	_2.18s	_{p=0.872 n=6}
_{Check Time}	_{42.80s (± 0.58%)}	_{42.90s (± 0.25%)}	_~	_42.79s	_43.06s	_{p=0.471 n=6}
_{Emit Time}	_{3.44s (± 2.01%)}	_{3.48s (± 1.64%)}	_~	_3.40s	_3.54s	_{p=0.336 n=6}
_{Total Time}	_{55.33s (± 0.58%)}	_{55.57s (± 0.32%)}	_~	_55.36s	_55.81s	_{p=0.230 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_262,223	_262,231	_{+8 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,607	_106,622	_{+15 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{439,818k (± 0.01%)}	_{439,867k (± 0.02%)}	_~	_439,749k	_439,954k	_{p=0.336 n=6}
_{Parse Time}	_{3.56s (± 1.22%)}	_{3.58s (± 0.94%)}	_~	_3.56s	_3.65s	_{p=0.107 n=6}
_{Bind Time}	_{1.32s (± 1.39%)}	_{1.32s (± 0.78%)}	_~	_1.30s	_1.33s	_{p=1.000 n=6}
_{Check Time}	_{18.99s (± 0.55%)}	_{18.98s (± 0.47%)}	_~	_18.87s	_19.08s	_{p=1.000 n=6}
_{Emit Time}	_{1.52s (± 0.80%)}	_{1.52s (± 0.93%)}	_~	_1.50s	_1.54s	_{p=0.615 n=6}
_{Total Time}	_{25.39s (± 0.24%)}	_{25.40s (± 0.33%)}	_~	_25.29s	_25.48s	_{p=0.936 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₀	₇₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_226,062	_226,062	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,488	_94,488	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,581k (± 0.01%)}	_{371,620k (± 0.02%)}	_~	_371,540k	_371,704k	_{p=0.378 n=6}
_{Parse Time}	_{2.89s (± 1.27%)}	_{2.90s (± 1.14%)}	_~	_2.86s	_2.94s	_{p=0.685 n=6}
_{Bind Time}	_{1.59s (± 0.62%)}	_{1.59s (± 0.89%)}	_~	_1.57s	_1.61s	_{p=0.869 n=6}
_{Check Time}	_{16.46s (± 0.44%)}	_{16.57s (± 1.18%)}	_~	_16.38s	_16.93s	_{p=0.423 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_0.00s	_~	_~	_~	_{p=0.405 n=6}
_{Total Time}	_{20.95s (± 0.40%)}	_{21.07s (± 0.92%)}	_~	_20.85s	_21.40s	_{p=0.261 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₄	₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,184,671	_3,184,671	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,095,225	_1,095,225	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,259,086k (± 0.01%)}	_{3,259,026k (± 0.01%)}	_~	_3,258,414k	_3,259,551k	_{p=0.810 n=6}
_{Parse Time}	_{14.02s (± 0.34%)}	_{14.10s (± 0.69%)}	_~	_14.02s	_14.27s	_{p=0.109 n=6}
_{Bind Time}	_{4.49s (± 2.73%)}	_{4.56s (± 2.92%)}	_~	_4.47s	_4.74s	_{p=0.169 n=6}
_{Check Time}	_{86.54s (± 1.65%)}	_{86.11s (± 1.19%)}	_~	_85.06s	_88.08s	_{p=0.810 n=6}
_{Emit Time}	_{27.80s (± 2.86%)}	_{27.84s (± 3.05%)}	_~	_26.89s	_28.77s	_{p=0.810 n=6}
_{Total Time}	_{132.85s (± 0.92%)}	_{132.61s (± 0.78%)}	_~	_130.95s	_133.78s	_{p=0.689 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_288,684	_288,684	_~	_~	_~	_{p=1.000 n=6}
_Types	_117,136	_117,136	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{440,801k (± 0.02%)}	_{440,939k (± 0.04%)}	_~	_440,717k	_441,218k	_{p=0.378 n=6}
_{Parse Time}	_{4.06s (± 0.82%)}	_{4.09s (± 0.83%)}	_~	_4.06s	_4.13s	_{p=0.090 n=6}
_{Bind Time}	_{1.74s (± 1.66%)}	_{1.74s (± 0.60%)}	_~	_1.72s	_1.75s	_{p=0.462 n=6}
_{Check Time}	_{18.79s (± 0.36%)}	_{18.89s (± 0.73%)}	_~	_18.72s	_19.04s	_{p=0.146 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.58s (± 0.37%)}	_{24.72s (± 0.56%)}	_~	_24.53s	_24.85s	_{p=0.128 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₈	₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_551,583	_551,583	_~	_~	_~	_{p=1.000 n=6}
_Types	_184,808	_184,808	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{491,885k (± 0.02%)}	_{491,915k (± 0.03%)}	_~	_491,688k	_492,130k	_{p=0.689 n=6}
_{Parse Time}	_{3.42s (± 0.84%)}	_{3.46s (± 0.84%)}	_{+0.04s (+ 1.12%)}	_3.42s	_3.50s	_{p=0.043 n=6}
_{Bind Time}	_{1.18s (± 0.93%)}	_{1.18s (± 1.16%)}	_~	_1.16s	_1.19s	_{p=0.933 n=6}
_{Check Time}	_{19.81s (± 2.30%)}	_{19.78s (± 2.06%)}	_~	_19.57s	_20.61s	_{p=0.936 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.42s (± 1.84%)}	_{24.42s (± 1.65%)}	_~	_24.21s	_25.24s	_{p=0.689 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-11-27T22:51:14Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60628/merge:

Everything looks good!

Disallow confusing combinations of !in and !instanceof

76b130a

typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Nov 27, 2024

jakebailey reviewed Nov 27, 2024

View reviewed changes

Use isWhiteSpaceLike to check for leading whitespace before exclamation

5947f8f

Add tests with leading tab characters before exclamation

a2429cb

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disallow confusing combinations of !in and !instanceof #60628

Disallow confusing combinations of !in and !instanceof #60628

bgenia commented Nov 27, 2024

jakebailey Nov 27, 2024

bgenia Nov 27, 2024

jakebailey Nov 27, 2024

jakebailey commented Nov 27, 2024

typescript-bot commented Nov 27, 2024 •

edited

Loading

typescript-bot commented Nov 27, 2024

typescript-bot commented Nov 27, 2024

typescript-bot commented Nov 27, 2024

tsc

typescript-bot commented Nov 27, 2024

Disallow confusing combinations of !in and !instanceof #60628

Are you sure you want to change the base?

Disallow confusing combinations of !in and !instanceof #60628

Conversation

bgenia commented Nov 27, 2024

jakebailey Nov 27, 2024

Choose a reason for hiding this comment

bgenia Nov 27, 2024

Choose a reason for hiding this comment

jakebailey Nov 27, 2024

Choose a reason for hiding this comment

jakebailey commented Nov 27, 2024

typescript-bot commented Nov 27, 2024 • edited Loading

typescript-bot commented Nov 27, 2024

typescript-bot commented Nov 27, 2024

typescript-bot commented Nov 27, 2024

tsc

typescript-bot commented Nov 27, 2024

typescript-bot commented Nov 27, 2024 •

edited

Loading