Remove reference not found errors from jsx: preserve
#60687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
weswigham
reviewed
Dec 5, 2024
tests/baselines/reference/jsxFragmentFactoryReference(jsx=react-jsx).errors.txt
Outdated
Show resolved
Hide resolved
|
I found that a lot of the errors generated in the original PR seem to be incorrect as well. The most recent change removes those, and adds some more tests to show the behavior with the rest of the |
andrewbranch
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
You could do // @noTypesAndSymbols: true and maybe even // @noEmit: true since we really only care about errors for these tests
|
@typescript-bot cherry-pick this to release-5.7 |
typescript-bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
DanielRosenwasser
pushed a commit
that referenced
this pull request
Dec 9, 2024
…e-5.7 (#60721) Co-authored-by: Isabel Duan <isabelduan@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #60603
Cleans up a lot of errors that shouldn't have been included with #59933. From discussion with @andrewbranch:
preserveshouldn't perform the checkreactshould check forReactin scope, andjsx/jsxFragpragmas should check if entity name is in scopereact-jsx,react-jsx-dev, settings andjsxImportSourcepragma should check that the corresponding module can be imported