Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always discriminate contextual types by existing discriminant property #61097

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Always discriminate contextual types by existing discriminant property #61097

wants to merge 1 commit into from
+827 −11

Conversation

Andarist
Copy link
Contributor

@Andarist Andarist commented Feb 1, 2025

fixes #58508
fixes #61095

I think the added tests/cases/compiler/contextuallyTypedByDiscriminableUnion2.ts test case tells it all (TS playground). Currently both property assignments that reference external values and shorthand property assignments are capable of narrowing this case but a property assignment with an "inline" initializer isn't.

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Feb 1, 2025
@jakebailey
Copy link
Member

@typescript-bot test it

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 1, 2025 •
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top400 ✅ Started 👀 Results
user test this ✅ Started ✅ Results
run dt ✅ Started 👀 Results
perf test this faster ✅ Started 👀 Results

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/61097/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

Hey @jakebailey, the results of running the DT tests are ready.

There were interesting changes:

Branch only errors:

Package: knockout
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/knockout/test/templatingBehaviors.ts
  719:28  error  TypeScript@local compile error: 
Type 'KnockoutObservable<boolean>' is not assignable to type 'string'  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.28_typescript@5.8.0-dev.20250201/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.28_typescript@5.8.0-dev.20250201/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Package: react-dates
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/react-dates/react-dates-tests.tsx
  35:28  error  TypeScript@local compile error: 
Binding element 'isVisible' implicitly has an 'any' type      @definitelytyped/expect
  35:39  error  TypeScript@local compile error: 
Binding element 'month' implicitly has an 'any' type          @definitelytyped/expect
  35:46  error  TypeScript@local compile error: 
Binding element 'onMonthSelect' implicitly has an 'any' type  @definitelytyped/expect
  35:61  error  TypeScript@local compile error: 
Binding element 'onYearSelect' implicitly has an 'any' type   @definitelytyped/expect

✖ 4 problems (4 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.28_typescript@5.8.0-dev.20250201/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.28_typescript@5.8.0-dev.20250201/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

You can check the log here.

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-Unions - node (v18.15.0, x64)
Errors 34 34 ~ ~ ~ p=1.000 n=6
Symbols 62,390 62,391 +1 (+ 0.00%) ~ ~ p=0.001 n=6
Types 50,395 50,395 ~ ~ ~ p=1.000 n=6
Memory used 195,012k (± 0.99%) 195,527k (± 0.96%) ~ 193,086k 196,770k p=0.689 n=6
Parse Time 1.32s (± 0.93%) 1.32s (± 1.00%) ~ 1.30s 1.34s p=0.341 n=6
Bind Time 0.73s (± 0.70%) 0.73s (± 0.70%) ~ 0.73s 0.74s p=1.000 n=6
Check Time 9.79s (± 0.36%) 9.79s (± 0.28%) ~ 9.76s 9.83s p=0.872 n=6
Emit Time 2.75s (± 0.76%) 2.74s (± 0.27%) ~ 2.73s 2.75s p=0.741 n=6
Total Time 14.59s (± 0.32%) 14.59s (± 0.22%) ~ 14.54s 14.63s p=0.745 n=6
angular-1 - node (v18.15.0, x64)
Errors 37 37 ~ ~ ~ p=1.000 n=6
Symbols 948,488 948,719 +231 (+ 0.02%) ~ ~ p=0.001 n=6
Types 411,006 411,022 +16 (+ 0.00%) ~ ~ p=0.001 n=6
Memory used 1,225,594k (± 0.00%) 1,225,675k (± 0.00%) ~ 1,225,617k 1,225,727k p=0.066 n=6
Parse Time 7.99s (± 0.94%) 7.99s (± 1.22%) ~ 7.86s 8.12s p=0.872 n=6
Bind Time 2.29s (± 0.53%) 2.29s (± 0.66%) ~ 2.26s 2.30s p=0.675 n=6
Check Time 38.28s (± 0.29%) 38.15s (± 0.33%) ~ 37.94s 38.32s p=0.092 n=6
Emit Time 18.28s (± 0.32%) 18.35s (± 0.54%) ~ 18.22s 18.52s p=0.296 n=6
Total Time 66.85s (± 0.20%) 66.77s (± 0.20%) ~ 66.56s 66.91s p=0.336 n=6
mui-docs - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 2,447,455 2,448,462 +1,007 (+ 0.04%) ~ ~ p=0.001 n=6
Types 898,654 898,656 +2 (+ 0.00%) ~ ~ p=0.001 n=6
Memory used 2,309,898k (± 0.00%) 2,310,379k (± 0.00%) +481k (+ 0.02%) 2,310,341k 2,310,413k p=0.005 n=6
Parse Time 8.99s (± 0.28%) 8.97s (± 0.41%) ~ 8.93s 9.02s p=0.332 n=6
Bind Time 2.19s (± 0.53%) 2.20s (± 0.38%) ~ 2.18s 2.20s p=0.555 n=6
Check Time 74.56s (± 0.40%) 74.31s (± 0.39%) ~ 74.08s 74.88s p=0.128 n=6
Emit Time 0.28s (± 1.99%) 0.28s (± 3.19%) ~ 0.27s 0.29s p=0.341 n=6
Total Time 86.02s (± 0.33%) 85.76s (± 0.32%) ~ 85.53s 86.30s p=0.128 n=6
self-build-src - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,229,397 1,229,638 +241 (+ 0.02%) ~ ~ p=0.001 n=6
Types 267,085 267,137 +52 (+ 0.02%) ~ ~ p=0.001 n=6
Memory used 2,361,938k (± 0.01%) 2,362,274k (± 0.01%) +336k (+ 0.01%) 2,361,910k 2,362,542k p=0.045 n=6
Parse Time 5.30s (± 1.41%) 5.25s (± 0.78%) ~ 5.20s 5.32s p=0.378 n=6
Bind Time 1.81s (± 1.24%) 1.81s (± 0.64%) ~ 1.79s 1.82s p=0.808 n=6
Check Time 35.43s (± 0.29%) 35.45s (± 0.21%) ~ 35.33s 35.52s p=0.810 n=6
Emit Time 3.04s (± 0.87%) 3.04s (± 0.71%) ~ 3.01s 3.07s p=0.748 n=6
Total Time 45.58s (± 0.16%) 45.55s (± 0.13%) ~ 45.46s 45.62s p=0.521 n=6
self-build-src-public-api - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,229,397 1,229,638 +241 (+ 0.02%) ~ ~ p=0.001 n=6
Types 267,085 267,137 +52 (+ 0.02%) ~ ~ p=0.001 n=6
Memory used 3,038,879k (± 9.76%) 3,038,954k (± 9.77%) ~ 2,432,081k 3,161,531k p=0.936 n=6
Parse Time 6.97s (± 1.71%) 7.00s (± 1.10%) ~ 6.85s 7.06s p=0.575 n=6
Bind Time 2.14s (± 2.00%) 2.14s (± 1.21%) ~ 2.09s 2.16s p=0.572 n=6
Check Time 42.78s (± 0.53%) 42.83s (± 0.17%) ~ 42.70s 42.89s p=0.936 n=6
Emit Time 3.51s (± 1.22%) 3.52s (± 3.47%) ~ 3.33s 3.68s p=0.575 n=6
Total Time 55.37s (± 0.51%) 55.50s (± 0.18%) ~ 55.36s 55.62s p=0.378 n=6
self-compiler - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 263,074 263,123 +49 (+ 0.02%) ~ ~ p=0.001 n=6
Types 106,881 106,899 +18 (+ 0.02%) ~ ~ p=0.001 n=6
Memory used 441,342k (± 0.02%) 441,332k (± 0.01%) ~ 441,248k 441,378k p=0.873 n=6
Parse Time 3.58s (± 0.74%) 3.57s (± 0.70%) ~ 3.54s 3.61s p=0.293 n=6
Bind Time 1.32s (± 0.64%) 1.32s (± 1.04%) ~ 1.30s 1.34s p=0.931 n=6
Check Time 19.05s (± 0.22%) 19.03s (± 0.32%) ~ 18.91s 19.09s p=0.628 n=6
Emit Time 1.54s (± 1.07%) 1.53s (± 1.13%) ~ 1.50s 1.55s p=0.566 n=6
Total Time 25.49s (± 0.19%) 25.44s (± 0.27%) ~ 25.32s 25.51s p=0.195 n=6
ts-pre-modules - node (v18.15.0, x64)
Errors 70 70 ~ ~ ~ p=1.000 n=6
Symbols 226,113 226,165 +52 (+ 0.02%) ~ ~ p=0.001 n=6
Types 94,488 94,507 +19 (+ 0.02%) ~ ~ p=0.001 n=6
Memory used 371,714k (± 0.01%) 371,706k (± 0.01%) ~ 371,666k 371,739k p=0.689 n=6
Parse Time 2.34s (± 0.57%) 2.33s (± 0.70%) ~ 2.31s 2.36s p=0.405 n=6
Bind Time 1.35s (± 1.84%) 1.36s (± 1.27%) ~ 1.34s 1.38s p=0.367 n=6
Check Time 13.77s (± 0.20%) 13.78s (± 0.33%) ~ 13.73s 13.86s p=1.000 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 17.46s (± 0.28%) 17.47s (± 0.32%) ~ 17.40s 17.54s p=0.808 n=6
vscode - node (v18.15.0, x64)
Errors 3 3 ~ ~ ~ p=1.000 n=6
Symbols 3,273,619 3,275,080 +1,461 (+ 0.04%) ~ ~ p=0.001 n=6
Types 1,125,682 1,125,906 +224 (+ 0.02%) ~ ~ p=0.001 n=6
Memory used 3,347,404k (± 0.01%) 3,347,992k (± 0.01%) +588k (+ 0.02%) 3,347,403k 3,348,420k p=0.045 n=6
Parse Time 14.56s (± 0.21%) 14.55s (± 0.82%) ~ 14.45s 14.74s p=0.422 n=6
Bind Time 4.63s (± 0.32%) 4.62s (± 0.71%) ~ 4.57s 4.66s p=0.624 n=6
Check Time 89.88s (± 2.02%) 89.63s (± 2.29%) ~ 87.94s 92.87s p=0.575 n=6
Emit Time 28.71s (± 2.62%) 28.41s (± 3.24%) ~ 27.53s 29.43s p=0.521 n=6
Total Time 137.77s (± 1.22%) 137.21s (± 2.06%) ~ 134.88s 141.61s p=0.378 n=6
webpack - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 292,552 292,568 +16 (+ 0.01%) ~ ~ p=0.001 n=6
Types 119,125 119,123 -2 (- 0.00%) ~ ~ p=0.001 n=6
Memory used 446,130k (± 0.03%) 446,083k (± 0.02%) ~ 445,996k 446,245k p=0.471 n=6
Parse Time 4.07s (± 1.84%) 4.04s (± 1.16%) ~ 3.97s 4.11s p=0.374 n=6
Bind Time 1.78s (± 1.41%) 1.78s (± 1.11%) ~ 1.75s 1.80s p=0.935 n=6
Check Time 18.72s (± 0.70%) 18.76s (± 0.50%) ~ 18.62s 18.88s p=0.748 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 24.56s (± 0.75%) 24.59s (± 0.40%) ~ 24.42s 24.71s p=0.936 n=6
xstate-main - node (v18.15.0, x64)
Errors 5 5 ~ ~ ~ p=1.000 n=6
Symbols 555,375 556,512 +1,137 (+ 0.20%) ~ ~ p=0.001 n=6
Types 186,146 186,185 +39 (+ 0.02%) ~ ~ p=0.001 n=6
Memory used 494,519k (± 0.01%) 495,045k (± 0.01%) +526k (+ 0.11%) 495,000k 495,084k p=0.005 n=6
Parse Time 3.41s (± 0.64%) 3.41s (± 0.80%) ~ 3.39s 3.46s p=1.000 n=6
Bind Time 1.19s (± 0.68%) 1.19s (± 1.23%) ~ 1.17s 1.21s p=1.000 n=6
Check Time 19.54s (± 0.44%) 19.60s (± 0.17%) ~ 19.57s 19.66s p=0.065 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 24.15s (± 0.43%) 24.21s (± 0.17%) ~ 24.15s 24.25s p=0.077 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Compiler-Unions - node (v18.15.0, x64)
  • angular-1 - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/61097/merge:

Something interesting changed - please have a look.

Details

omnivore-app/omnivore

3 of 23 projects failed to build with the old tsc and were ignored

packages/web/tsconfig.json

  • error TS2615: Type of property 'bg' circularly references itself in mapped type 'Utils<{ bg: (value: { readonly [$$PropertyValue]: "backgroundColor"; }) => any; p: (value: { readonly [$$PropertyValue]: "padding"; }) => any; pt: (value: { readonly [$$PropertyValue]: "paddingTop"; }) => any; ... 11 more ...; my: (value: { ...; }) => any; }>'.
  • error TS7023: 'bg' implicitly has return type 'any' because it does not have a return type annotation and is referenced directly or indirectly in one of its return expressions.
  • error TS2615: Type of property 'p' circularly references itself in mapped type 'Utils<{ bg: unknown; p: (value: { readonly [$$PropertyValue]: "padding"; }) => any; pt: (value: { readonly [$$PropertyValue]: "paddingTop"; }) => any; pb: (value: { readonly [$$PropertyValue]: "paddingBottom"; }) => any; ... 10 more ...; my: (value: { ...; }) => any; }>'.
  • error TS7023: 'p' implicitly has return type 'any' because it does not have a return type annotation and is referenced directly or indirectly in one of its return expressions.
  • error TS2615: Type of property 'pt' circularly references itself in mapped type 'Utils<{ bg: unknown; p: unknown; pt: (value: { readonly [$$PropertyValue]: "paddingTop"; }) => any; pb: (value: { readonly [$$PropertyValue]: "paddingBottom"; }) => any; pl: (value: { readonly [$$PropertyValue]: "paddingLeft"; }) => any; ... 9 more ...; my: (value: { ...; }) => any; }>'.
  • error TS7023: 'pt' implicitly has return type 'any' because it does not have a return type annotation and is referenced directly or indirectly in one of its return expressions.
  • error TS2615: Type of property 'pb' circularly references itself in mapped type 'Utils<{ bg: unknown; p: unknown; pt: unknown; pb: (value: { readonly [$$PropertyValue]: "paddingBottom"; }) => any; pl: (value: { readonly [$$PropertyValue]: "paddingLeft"; }) => any; pr: (value: { readonly [$$PropertyValue]: "paddingRight"; }) => any; ... 8 more ...; my: (value: { ...; }) => any; }>'.
  • error TS7023: 'pb' implicitly has return type 'any' because it does not have a return type annotation and is referenced directly or indirectly in one of its return expressions.
  • error TS2615: Type of property 'pl' circularly references itself in mapped type 'Utils<{ bg: unknown; p: unknown; pt: unknown; pb: unknown; pl: (value: { readonly [$$PropertyValue]: "paddingLeft"; }) => any; pr: (value: { readonly [$$PropertyValue]: "paddingRight"; }) => any; px: (value: { readonly [$$PropertyValue]: "padding"; }) => any; ... 7 more ...; my: (value: { ...; }) => any; }>'.
  • error TS7023: 'pl' implicitly has return type 'any' because it does not have a return type annotation and is referenced directly or indirectly in one of its return expressions.
  • error TS2615: Type of property 'pr' circularly references itself in mapped type 'Utils<{ bg: unknown; p: unknown; pt: unknown; pb: unknown; pl: unknown; pr: (value: { readonly [$$PropertyValue]: "paddingRight"; }) => any; px: (value: { readonly [$$PropertyValue]: "padding"; }) => any; py: (value: { readonly [$$PropertyValue]: "padding"; }) => any; ... 6 more ...; my: (value: { ...; }) => any; }>'.
  • error TS7023: 'pr' implicitly has return type 'any' because it does not have a return type annotation and is referenced directly or indirectly in one of its return expressions.
  • error TS2615: Type of property 'px' circularly references itself in mapped type 'Utils<{ bg: unknown; p: unknown; pt: unknown; pb: unknown; pl: unknown; pr: unknown; px: (value: { readonly [$$PropertyValue]: "padding"; }) => any; py: (value: { readonly [$$PropertyValue]: "padding"; }) => any; m: (value: { readonly [$$PropertyValue]: "margin"; }) => any; ... 5 more ...; my: (value: { ...; }) => a...'.
  • error TS7023: 'px' implicitly has return type 'any' because it does not have a return type annotation and is referenced directly or indirectly in one of its return expressions.
  • error TS2615: Type of property 'py' circularly references itself in mapped type 'Utils<{ bg: unknown; p: unknown; pt: unknown; pb: unknown; pl: unknown; pr: unknown; px: unknown; py: (value: { readonly [$$PropertyValue]: "padding"; }) => any; m: (value: { readonly [$$PropertyValue]: "margin"; }) => any; mt: (value: { readonly [$$PropertyValue]: "marginTop"; }) => any; ... 4 more ...; my: (value:...'.
  • error TS7023: 'py' implicitly has return type 'any' because it does not have a return type annotation and is referenced directly or indirectly in one of its return expressions.
  • error TS2615: Type of property 'm' circularly references itself in mapped type 'Utils<{ bg: unknown; p: unknown; pt: unknown; pb: unknown; pl: unknown; pr: unknown; px: unknown; py: unknown; m: (value: { readonly [$$PropertyValue]: "margin"; }) => any; mt: (value: { readonly [$$PropertyValue]: "marginTop"; }) => any; mb: (value: { readonly [$$PropertyValue]: "marginBottom"; }) => any; ml: (valu...'.
  • error TS7023: 'm' implicitly has return type 'any' because it does not have a return type annotation and is referenced directly or indirectly in one of its return expressions.
  • error TS2615: Type of property 'mt' circularly references itself in mapped type 'Utils<{ bg: unknown; p: unknown; pt: unknown; pb: unknown; pl: unknown; pr: unknown; px: unknown; py: unknown; m: unknown; mt: (value: { readonly [$$PropertyValue]: "marginTop"; }) => any; mb: (value: { readonly [$$PropertyValue]: "marginBottom"; }) => any; ml: (value: { ...; }) => any; mr: (value: { ...; }) => any;...'.
  • error TS7023: 'mt' implicitly has return type 'any' because it does not have a return type annotation and is referenced directly or indirectly in one of its return expressions.
  • error TS2615: Type of property 'mb' circularly references itself in mapped type 'Utils<{ bg: unknown; p: unknown; pt: unknown; pb: unknown; pl: unknown; pr: unknown; px: unknown; py: unknown; m: unknown; mt: unknown; mb: (value: { readonly [$$PropertyValue]: "marginBottom"; }) => any; ml: (value: { readonly [$$PropertyValue]: "marginLeft"; }) => any; mr: (value: { ...; }) => any; mx: (value: { ....'.
  • error TS7023: 'mb' implicitly has return type 'any' because it does not have a return type annotation and is referenced directly or indirectly in one of its return expressions.
  • error TS2615: Type of property 'ml' circularly references itself in mapped type 'Utils<{ bg: unknown; p: unknown; pt: unknown; pb: unknown; pl: unknown; pr: unknown; px: unknown; py: unknown; m: unknown; mt: unknown; mb: unknown; ml: (value: { readonly [$$PropertyValue]: "marginLeft"; }) => any; mr: (value: { readonly [$$PropertyValue]: "marginRight"; }) => any; mx: (value: { ...; }) => any; my:...'.
  • error TS7023: 'ml' implicitly has return type 'any' because it does not have a return type annotation and is referenced directly or indirectly in one of its return expressions.
  • error TS2615: Type of property 'mr' circularly references itself in mapped type 'Utils<{ bg: unknown; p: unknown; pt: unknown; pb: unknown; pl: unknown; pr: unknown; px: unknown; py: unknown; m: unknown; mt: unknown; mb: unknown; ml: unknown; mr: (value: { readonly [$$PropertyValue]: "marginRight"; }) => any; mx: (value: { readonly [$$PropertyValue]: "margin"; }) => any; my: (value: { ...; }) =>...'.
  • error TS7023: 'mr' implicitly has return type 'any' because it does not have a return type annotation and is referenced directly or indirectly in one of its return expressions.
  • error TS2615: Type of property 'mx' circularly references itself in mapped type 'Utils<{ bg: unknown; p: unknown; pt: unknown; pb: unknown; pl: unknown; pr: unknown; px: unknown; py: unknown; m: unknown; mt: unknown; mb: unknown; ml: unknown; mr: unknown; mx: (value: { readonly [$$PropertyValue]: "margin"; }) => any; my: (value: { readonly [$$PropertyValue]: "margin"; }) => any; }>'.
  • error TS7023: 'mx' implicitly has return type 'any' because it does not have a return type annotation and is referenced directly or indirectly in one of its return expressions.
  • error TS2615: Type of property 'my' circularly references itself in mapped type 'Utils<{ bg: unknown; p: unknown; pt: unknown; pb: unknown; pl: unknown; pr: unknown; px: unknown; py: unknown; m: unknown; mt: unknown; mb: unknown; ml: unknown; mr: unknown; mx: unknown; my: (value: { readonly [$$PropertyValue]: "margin"; }) => any; }>'.
  • error TS7023: 'my' implicitly has return type 'any' because it does not have a return type annotation and is referenced directly or indirectly in one of its return expressions.

react-navigation/react-navigation

9 of 14 projects failed to build with the old tsc and were ignored

tsconfig.json

packages/react-native-tab-view/tsconfig.build.json

example/tsconfig.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
PR Backlog
Status: Not started
Milestone
No milestone
3 participants
@Andarist @jakebailey @typescript-bot