Fixed isReadonlySymbol check for intersection properties with .valueDeclaration
#61346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andarist
commented
Mar 4, 2025
Comment on lines
+39012
to
+39015
| if (checkFlags & CheckFlags.Synthetic) { | ||
| // unions and intersections eagerly compute Readonly flag on creation | ||
| return !!(checkFlags & CheckFlags.Readonly); | ||
| } |
There was a problem hiding this comment.
- The issue arised because
getDeclarationModifierFlagsFromSymbol(symbol)was returningModifierFlags.Readonlybased on the.valueDeclaration. .valueDeclarationis only set on union/intersection properties when it's "uniform"(ish). In this example, one source property symbol had a.valueDeclarationand the other one hadn't (the one from the mapped type hadn't it)- but given that, as the existing comment states, the readonly flag is precomputed eagerly for union/intersections - this is really the only thing the compiler has to check in that situation. So I leveraged that for the fix here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #61344