Skip to content

fix(57026): Renaming on declaration whose name is a String Literal #61353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix(57026): Renaming on declaration whose name is a String Literal #61353

wants to merge 7 commits into from

Conversation

@NamHaiBui
Copy link

@NamHaiBui NamHaiBui commented Mar 5, 2025 •
edited
Loading

Fixes #57026

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Mar 5, 2025
@NamHaiBui NamHaiBui changed the title Renaming on declaration whose name is a String Literal Renaming on declaration whose name is a String Literal(57026) Mar 5, 2025
@NamHaiBui NamHaiBui changed the title Renaming on declaration whose name is a String Literal(57026) fix(57026): Renaming on declaration whose name is a String Literal Mar 5, 2025
@NamHaiBui NamHaiBui marked this pull request as ready for review March 5, 2025 02:52
@NamHaiBui
Copy link
Author

NamHaiBui commented Apr 15, 2025

@jakebailey @DanielRosenwasser
Hi, can you review my pr if it's not too much trouble?
I am working on contributing to Typescript as my senior project.

jakebailey
jakebailey reviewed Apr 15, 2025
View reviewed changes
tests/cases/fourslash/renameStringLiteralTypes5.ts Outdated
////declare const fnc_1: <K extends keyof Case_1>(p: K) => void
////
////fn("Prop 1"/**/)
////fnc_1("Att 2")
Copy link
Member

@jakebailey jakebailey Apr 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these tests being modified rather than being added to, if anything?

Copy link
Author

@NamHaiBui NamHaiBui Apr 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a duplicate test of renameStringLiteralTypes4 so I modified it to reflect one of the cases mentioned in the original issue.

Copy link
Member

@jakebailey jakebailey Apr 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are not duplicate tests. One is a type, the other is an interface.

Copy link
Author

@NamHaiBui NamHaiBui Apr 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry about that, I will revert changes and add an additional tests for type as well. Thank you and sorry for the oversight.

@NamHaiBui
Copy link
Author

NamHaiBui commented Apr 16, 2025 •
edited
Loading

@jakebailey
I have updated the code and added in tests to check for both Type declaration and interface declaration.
Again, thank you so much for reviewing this and helping me.

@NamHaiBui NamHaiBui requested a review from jakebailey April 22, 2025 14:41
@NamHaiBui
Copy link
Author

NamHaiBui commented Apr 25, 2025

@jakebailey Hi, is it possible to get a review on this soon?
It would be greatly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakebailey jakebailey Awaiting requested review from jakebailey

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rename doesn't work on declaration whose name is a string literal

3 participants

@NamHaiBui @jakebailey @typescript-bot