Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors on type assertions in erasableSyntaxOnly #61452

Merged
merged 3 commits into from
Mar 19, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/compiler/checker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37316,8 +37316,8 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
grammarErrorOnNode(node, Diagnostics.This_syntax_is_reserved_in_files_with_the_mts_or_cts_extension_Use_an_as_expression_instead);
}
if (compilerOptions.erasableSyntaxOnly) {
const start = node.type.pos - "<".length;
const end = skipTrivia(file.text, node.type.end) + ">".length;
const start = skipTrivia(file.text, node.pos);
const end = node.expression.pos;
diagnostics.add(createFileDiagnostic(file, start, end - start, Diagnostics.This_syntax_is_not_allowed_when_erasableSyntaxOnly_is_enabled));
}
}
Expand Down
24 changes: 24 additions & 0 deletions tests/baselines/reference/erasableSyntaxOnly2.errors.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
index.ts(1,10): error TS1294: This syntax is not allowed when 'erasableSyntaxOnly' is enabled.
index.ts(1,19): error TS1005: '>' expected.
index.ts(2,9): error TS1294: This syntax is not allowed when 'erasableSyntaxOnly' is enabled.
index.ts(2,18): error TS1005: '>' expected.
index.ts(3,9): error TS1294: This syntax is not allowed when 'erasableSyntaxOnly' is enabled.
index.ts(3,17): error TS1005: '>' expected.


==== index.ts (6 errors) ====
let a = (<unknown function foo() {});
~~~~~~~~
!!! error TS1294: This syntax is not allowed when 'erasableSyntaxOnly' is enabled.
~~~~~~~~
!!! error TS1005: '>' expected.
let b = <unknown 123;
~~~~~~~~
!!! error TS1294: This syntax is not allowed when 'erasableSyntaxOnly' is enabled.
~~~
!!! error TS1005: '>' expected.
let c = <unknown
~~~~~~~~
!!! error TS1294: This syntax is not allowed when 'erasableSyntaxOnly' is enabled.

!!! error TS1005: '>' expected.
11 changes: 11 additions & 0 deletions tests/baselines/reference/erasableSyntaxOnly2.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
//// [tests/cases/compiler/erasableSyntaxOnly2.ts] ////

//// [index.ts]
let a = (<unknown function foo() {});
let b = <unknown 123;
let c = <unknown

//// [index.js]
var a = function foo() { };
var b = 123;
var c = ;
13 changes: 13 additions & 0 deletions tests/baselines/reference/erasableSyntaxOnly2.symbols
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
//// [tests/cases/compiler/erasableSyntaxOnly2.ts] ////

=== index.ts ===
let a = (<unknown function foo() {});
>a : Symbol(a, Decl(index.ts, 0, 3))
>foo : Symbol(foo, Decl(index.ts, 0, 17))

let b = <unknown 123;
>b : Symbol(b, Decl(index.ts, 1, 3))

let c = <unknown
>c : Symbol(c, Decl(index.ts, 2, 3))

31 changes: 31 additions & 0 deletions tests/baselines/reference/erasableSyntaxOnly2.types
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
//// [tests/cases/compiler/erasableSyntaxOnly2.ts] ////

=== index.ts ===
let a = (<unknown function foo() {});
>a : unknown
> : ^^^^^^^
>(<unknown function foo() {}) : unknown
> : ^^^^^^^
><unknown function foo() {} : unknown
> : ^^^^^^^
>function foo() {} : () => void
> : ^^^^^^^^^^
>foo : () => void
> : ^^^^^^^^^^

let b = <unknown 123;
>b : unknown
> : ^^^^^^^
><unknown 123 : unknown
> : ^^^^^^^
>123 : 123
> : ^^^

let c = <unknown
>c : unknown
> : ^^^^^^^
><unknown : unknown
> : ^^^^^^^
> : any
> : ^^^

6 changes: 6 additions & 0 deletions tests/cases/compiler/erasableSyntaxOnly2.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
// @erasableSyntaxOnly: true

// @filename: index.ts
let a = (<unknown function foo() {});
let b = <unknown 123;
let c = <unknown