Improve `.origin` preservation in `getNarrowedTypeWorker` #61589

Andarist · 2025-04-17T13:58:01Z

This reverts commit 2eecb4d.

Andarist · 2025-04-17T14:02:46Z

src/compiler/checker.ts

-                );
-                // If no constituents are directly related, create intersections for any generic constituents that
+            let matchedCandidates: Type[] = [];
+            let narrowedType = mapType(type, t =>


This whole change aims to avoid any major functional changes.

Conceptually, it just "flips" the order of the 2 nested for loops. Before candidates were iterated and that iteration was iterating through types. With this change, it's the other way around - types are iterated and they have an inner loop through candidates. This required some changes to pull this off (like the introduction of matchedCandidates).

But why this is even needed? The goal of this code is to narrow down a type by a candidate and to truly narrow down a type a mapType or filterType have to be used because they try to preserve .origin information. By having the outer loop mapping through candidate this "merely" produced a result related to type but not one that would directly be derived from it -so the .origin had very slim chances of surviving when narrowing by a union candidate

Andarist · 2025-04-17T14:03:48Z

tests/baselines/reference/narrowingUnionToUnion.types

 >     : ^^^^^^^^^^^^^^^^^^^^^^^^^

    test;  // EmptyString
->test : EmptyString


Those changes are fine - it's the candidate that had .origin on it but the goal is to preserve type's .origin and not .candidate's. The contained types here are exactly the same

jakebailey · 2025-04-17T14:07:16Z

@typescript-bot test it
@typescript-bot pack this

typescript-bot · 2025-04-17T14:07:22Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`pack this`	✅ Started	✅ Results
`test top400`	✅ Started	👀 Results
`user test this`	✅ Started	👀 Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2025-04-17T14:11:29Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/165021/artifacts?artifactName=tgz&fileId=24DA55CD64888D5082CC34590B0920BBC7EC3B8C66ABBE37844DA0AFCB1CBA1502&fileName=/typescript-5.9.0-insiders.20250417.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.9.0-pr-61589-2".;

typescript-bot · 2025-04-17T14:31:14Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2025-04-17T14:31:42Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/61589/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Timeout"

Otherwise...

Something interesting changed - please have a look.

Details

webpack

tsconfig.types.json

[NEW] error TS7053: Element implicitly has an 'any' type because expression of type '"type"' can't be used to index type 'Node | Node[]'.
- lib/util/concatenate.js#L80

tsconfig.json

[NEW] error TS7053: Element implicitly has an 'any' type because expression of type '"type"' can't be used to index type 'Node | Node[]'.
- lib/util/concatenate.js#L80

typescript-bot · 2025-04-17T14:53:48Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₉	_{🔻+5 (+14.71%)}	_~	_~	_{p=0.001 n=6}
_Symbols	_62,390	_67,043	_{🔻+4,653 (+ 7.46%)}	_~	_~	_{p=0.001 n=6}
_Types	_50,395	_51,926	_{+1,531 (+ 3.04%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{193,619k (± 0.74%)}	_{196,390k (± 0.72%)}	_{+2,771k (+ 1.43%)}	_195,628k	_199,233k	_{p=0.045 n=6}
_{Parse Time}	_{1.30s (± 0.64%)}	_{1.30s (± 0.80%)}	_~	_1.29s	_1.32s	_{p=1.000 n=6}
_{Bind Time}	_0.73s	_0.73s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.75s (± 0.47%)}	_{9.82s (± 0.28%)}	_{+0.08s (+ 0.79%)}	_9.78s	_9.86s	_{p=0.010 n=6}
_{Emit Time}	_{2.72s (± 1.11%)}	_{2.70s (± 1.01%)}	_~	_2.66s	_2.72s	_{p=0.164 n=6}
_{Total Time}	_{14.50s (± 0.47%)}	_{14.55s (± 0.37%)}	_~	_14.47s	_14.59s	_{p=0.170 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅₆	₅₆	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_948,670	_948,673	_{+3 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_410,947	_410,979	_{+32 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{1,224,351k (± 0.01%)}	_{1,224,211k (± 0.00%)}	_{-140k (- 0.01%)}	_1,224,172k	_1,224,311k	_{p=0.008 n=6}
_{Parse Time}	_{6.62s (± 0.77%)}	_{6.66s (± 0.97%)}	_~	_6.54s	_6.71s	_{p=0.171 n=6}
_{Bind Time}	_{1.88s (± 0.62%)}	_{1.89s (± 0.33%)}	_~	_1.88s	_1.90s	_{p=0.179 n=6}
_{Check Time}	_{31.93s (± 0.20%)}	_{31.94s (± 0.38%)}	_~	_31.76s	_32.11s	_{p=0.629 n=6}
_{Emit Time}	_{15.24s (± 0.63%)}	_{15.30s (± 0.78%)}	_~	_15.14s	_15.48s	_{p=0.520 n=6}
_{Total Time}	_{55.68s (± 0.25%)}	_{55.79s (± 0.45%)}	_~	_55.42s	_56.11s	_{p=0.298 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,360,029	_2,360,029	_~	_~	_~	_{p=1.000 n=6}
_Types	_868,081	_868,081	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,314,243k (± 0.00%)}	_{2,314,254k (± 0.00%)}	_~	_2,314,166k	_2,314,359k	_{p=0.873 n=6}
_{Parse Time}	_{10.55s (± 0.39%)}	_{10.56s (± 0.20%)}	_~	_10.54s	_10.60s	_{p=0.809 n=6}
_{Bind Time}	_{2.68s (± 0.28%)}	_{2.70s (± 1.27%)}	_~	_2.64s	_2.74s	_{p=0.062 n=6}
_{Check Time}	_{84.41s (± 2.77%)}	_{83.57s (± 0.43%)}	_~	_82.88s	_83.84s	_{p=1.000 n=6}
_{Emit Time}	_{0.37s (± 3.60%)}	_{0.38s (± 1.46%)}	_~	_0.37s	_0.38s	_{p=0.228 n=6}
_{Total Time}	_{98.01s (± 2.39%)}	_{97.22s (± 0.35%)}	_~	_96.59s	_97.49s	_{p=0.688 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,228,025	_1,228,173	_{+148 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_267,258	_267,341	_{+83 (+ 0.03%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,360,870k (± 0.03%)}	_{2,360,816k (± 0.01%)}	_~	_2,360,685k	_2,361,078k	_{p=0.575 n=6}
_{Parse Time}	_{5.17s (± 0.74%)}	_{5.20s (± 1.26%)}	_~	_5.12s	_5.32s	_{p=0.630 n=6}
_{Bind Time}	_{1.80s (± 0.50%)}	_{1.80s (± 0.96%)}	_~	_1.77s	_1.82s	_{p=0.681 n=6}
_{Check Time}	_{35.37s (± 0.34%)}	_{35.43s (± 0.89%)}	_~	_35.19s	_36.05s	_{p=0.810 n=6}
_{Emit Time}	_{2.98s (± 1.92%)}	_{2.99s (± 1.42%)}	_~	_2.91s	_3.03s	_{p=0.871 n=6}
_{Total Time}	_{45.32s (± 0.33%)}	_{45.42s (± 0.87%)}	_~	_45.07s	_46.20s	_{p=0.689 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,228,025	_1,228,173	_{+148 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_267,258	_267,341	_{+83 (+ 0.03%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,427,915k (± 0.02%)}	_{2,427,797k (± 0.03%)}	_~	_2,426,789k	_2,428,388k	_{p=0.810 n=6}
_{Parse Time}	_{5.45s (± 0.88%)}	_{5.45s (± 1.06%)}	_~	_5.40s	_5.55s	_{p=0.689 n=6}
_{Bind Time}	_{1.81s (± 1.28%)}	_{1.81s (± 1.07%)}	_~	_1.78s	_1.83s	_{p=1.000 n=6}
_{Check Time}	_{35.43s (± 0.63%)}	_{35.35s (± 0.27%)}	_~	_35.23s	_35.46s	_{p=0.936 n=6}
_{Emit Time}	_{3.07s (± 1.77%)}	_{3.06s (± 1.04%)}	_~	_3.02s	_3.11s	_{p=0.872 n=6}
_{Total Time}	_{45.77s (± 0.60%)}	_{45.69s (± 0.21%)}	_~	_45.59s	_45.84s	_{p=0.471 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_263,403	_263,529	_{+126 (+ 0.05%)}	_~	_~	_{p=0.001 n=6}
_Types	_107,094	_107,158	_{+64 (+ 0.06%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{441,739k (± 0.01%)}	_{442,029k (± 0.01%)}	_{+290k (+ 0.07%)}	_441,952k	_442,122k	_{p=0.005 n=6}
_{Parse Time}	_{3.55s (± 0.87%)}	_{3.55s (± 0.29%)}	_~	_3.54s	_3.57s	_{p=0.871 n=6}
_{Bind Time}	_{1.32s (± 0.63%)}	_{1.32s (± 1.48%)}	_~	_1.31s	_1.36s	_{p=0.445 n=6}
_{Check Time}	_{19.01s (± 0.33%)}	_{19.07s (± 0.51%)}	_~	_18.95s	_19.20s	_{p=0.685 n=6}
_{Emit Time}	_{1.53s (± 1.28%)}	_{1.53s (± 1.09%)}	_~	_1.51s	_1.55s	_{p=0.744 n=6}
_{Total Time}	_{25.42s (± 0.23%)}	_{25.48s (± 0.38%)}	_~	_25.34s	_25.61s	_{p=0.296 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₁	₇₃	_{+2 (+ 2.82%)}	_~	_~	_{p=0.001 n=6}
_Symbols	_225,981	_227,646	_{+1,665 (+ 0.74%)}	_~	_~	_{p=0.001 n=6}
_Types	_94,356	_95,227	_{+871 (+ 0.92%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{371,274k (± 0.02%)}	_{372,867k (± 0.02%)}	_{+1,593k (+ 0.43%)}	_372,801k	_372,970k	_{p=0.005 n=6}
_{Parse Time}	_{2.89s (± 1.26%)}	_{2.90s (± 0.89%)}	_~	_2.86s	_2.94s	_{p=0.623 n=6}
_{Bind Time}	_{1.59s (± 0.77%)}	_{1.60s (± 1.61%)}	_~	_1.58s	_1.64s	_{p=0.868 n=6}
_{Check Time}	_{16.47s (± 0.56%)}	_{16.59s (± 0.45%)}	_{+0.12s (+ 0.76%)}	_16.46s	_16.67s	_{p=0.045 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_0.00s	_~	_~	_~	_{p=0.405 n=6}
_{Total Time}	_{20.95s (± 0.38%)}	_{21.09s (± 0.53%)}	_~	_20.89s	_21.20s	_{p=0.065 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₄	₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,361,603	_3,361,604	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_1,139,020	_1,139,024	_{+4 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,419,409k (± 0.03%)}	_{3,419,219k (± 0.00%)}	_~	_3,419,109k	_3,419,328k	_{p=0.575 n=6}
_{Parse Time}	_{14.60s (± 0.36%)}	_{14.61s (± 0.36%)}	_~	_14.56s	_14.70s	_{p=0.871 n=6}
_{Bind Time}	_{4.85s (± 3.34%)}	_{4.70s (± 0.33%)}	_~	_4.68s	_4.72s	_{p=0.124 n=6}
_{Check Time}	_{92.75s (± 3.06%)}	_{92.14s (± 1.52%)}	_~	_91.16s	_94.95s	_{p=1.000 n=6}
_{Emit Time}	_{29.78s (± 1.65%)}	_{29.52s (± 0.58%)}	_~	_29.36s	_29.83s	_{p=0.336 n=6}
_{Total Time}	_{141.97s (± 2.32%)}	_{140.97s (± 0.93%)}	_~	_139.97s	_143.58s	_{p=0.521 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₂	₂	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_316,035	_316,035	_~	_~	_~	_{p=1.000 n=6}
_Types	_140,050	_140,050	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{470,878k (± 0.03%)}	_{470,780k (± 0.01%)}	_~	_470,721k	_470,846k	_{p=0.298 n=6}
_{Parse Time}	_{5.15s (± 0.47%)}	_{5.16s (± 0.53%)}	_~	_5.12s	_5.19s	_{p=0.806 n=6}
_{Bind Time}	_{2.25s (± 1.55%)}	_{2.25s (± 0.92%)}	_~	_2.22s	_2.27s	_{p=0.871 n=6}
_{Check Time}	_{25.83s (± 0.28%)}	_{25.72s (± 0.30%)}	_~	_25.65s	_25.84s	_{p=0.077 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{33.24s (± 0.32%)}	_{33.12s (± 0.30%)}	_~	_33.03s	_33.29s	_{p=0.075 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_568,548	_568,549	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_190,459	_190,460	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{498,508k (± 0.02%)}	_{498,504k (± 0.04%)}	_~	_498,120k	_498,692k	_{p=0.575 n=6}
_{Parse Time}	_{4.18s (± 0.65%)}	_{4.19s (± 0.36%)}	_~	_4.18s	_4.22s	_{p=0.746 n=6}
_{Bind Time}	_{1.50s (± 0.69%)}	_{1.51s (± 1.00%)}	_~	_1.48s	_1.52s	_{p=0.161 n=6}
_{Check Time}	_{25.08s (± 2.41%)}	_{25.12s (± 2.73%)}	_~	_24.69s	_26.51s	_{p=0.810 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{30.76s (± 1.91%)}	_{30.82s (± 2.23%)}	_~	_30.38s	_32.21s	_{p=0.688 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

Andarist · 2025-04-17T15:17:55Z

Damn, those perf results are not great 😢 But first I'll have to investigate the webpack change

typescript-bot · 2025-04-17T15:37:36Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/61589/merge:

Something interesting changed - please have a look.

Details

apollographql/apollo-client

1 of 13 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2339: Property 'kind' does not exist on type 'ASTNode | readonly ASTNode[]'.
- src/utilities/graphql/transform.ts#L182
error TS2339: Property 'kind' does not exist on type 'FieldNode | FragmentSpreadNode | InlineFragmentNode | DirectiveNode | ArgumentNode | NameNode | ... 36 more ... | readonly ASTNode[]'.
- src/utilities/graphql/transform.ts#L186

src/tsconfig.json

error TS2339: Property 'kind' does not exist on type 'ASTNode | readonly ASTNode[]'.
- src/utilities/graphql/transform.ts#L182
error TS2339: Property 'kind' does not exist on type 'FieldNode | FragmentSpreadNode | InlineFragmentNode | DirectiveNode | ArgumentNode | NameNode | ... 36 more ... | readonly ASTNode[]'.
- src/utilities/graphql/transform.ts#L186

resend/react-email

36 of 39 projects failed to build with the old tsc and were ignored

packages/render/tsconfig.json

error TS2339: Property 'type' does not exist on type 'Doc[] | DocCommand'.
- packages/render/src/shared/utils/pretty.ts#L26
error TS2339: Property 'type' does not exist on type 'Doc[] | BreakParent | Cursor | IfBreak | IndentIfBreak | Line | LineSuffixBoundary | Trim'.
- packages/render/src/shared/utils/pretty.ts#L51
error TS2322: Type '{ breakContents: Doc; flatContents: Doc; length: number; toString(): string; toLocaleString(): string; toLocaleString(locales: string | string[], options?: (NumberFormatOptions & DateTimeFormatOptions) | undefined): string; ... 37 more ...; [Symbol.unscopables]: { ...; }; } | ... 6 more ... | { ...; }' is not assignable to type 'Doc'.
- packages/render/src/shared/utils/pretty.ts#L54
error TS2339: Property 'breakContents' does not exist on type 'Doc[] | BreakParent | Cursor | IfBreak | IndentIfBreak | Line | LineSuffixBoundary | Trim'.
- packages/render/src/shared/utils/pretty.ts#L54
error TS2339: Property 'flatContents' does not exist on type 'Doc[] | BreakParent | Cursor | IfBreak | IndentIfBreak | Line | LineSuffixBoundary | Trim'.
- packages/render/src/shared/utils/pretty.ts#L55
error TS2345: Argument of type 'string | Doc[] | BreakParent | Cursor | IfBreak | IndentIfBreak | Line | LineSuffixBoundary | Trim' is not assignable to parameter of type 'string | DocCommand'.
- packages/render/src/shared/utils/pretty.ts#L60

TanStack/query

79 of 118 projects failed to build with the old tsc and were ignored

packages/eslint-plugin-query/tsconfig.prod.json

error TS2345: Argument of type 'ClassBody | TSEnumBody | TSInterfaceBody | TSModuleBlock | Expression | Statement | Statement[] | TypeElement[] | ClassElement[] | ProgramStatement[]' is not assignable to parameter of type 'Node'.
- packages/eslint-plugin-query/src/utils/ast-utils.ts#L331 in packages/eslint-plugin-query/tsconfig.prod.json
error TS2345: Argument of type 'Expression | Statement | Statement[]' is not assignable to parameter of type 'Node'.
- packages/eslint-plugin-query/src/utils/ast-utils.ts#L341 in packages/eslint-plugin-query/tsconfig.prod.json

packages/eslint-plugin-query/tsconfig.json

error TS2345: Argument of type 'ClassBody | TSEnumBody | TSInterfaceBody | TSModuleBlock | Expression | Statement | Statement[] | TypeElement[] | ClassElement[] | ProgramStatement[]' is not assignable to parameter of type 'Node'.
- packages/eslint-plugin-query/src/utils/ast-utils.ts#L331 in packages/eslint-plugin-query/tsconfig.json
error TS2345: Argument of type 'Expression | Statement | Statement[]' is not assignable to parameter of type 'Node'.
- packages/eslint-plugin-query/src/utils/ast-utils.ts#L341 in packages/eslint-plugin-query/tsconfig.json

Andarist · 2025-04-18T19:35:34Z

@jakebailey could you rerun the tests here?

jakebailey · 2025-04-18T19:41:15Z

@typescript-bot test it
@typescript-bot pack this

typescript-bot · 2025-04-18T19:41:19Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`pack this`	✅ Started	✅ Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2025-04-18T19:45:44Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/165032/artifacts?artifactName=tgz&fileId=DC191BE44328575CEBE60ACECA83A2D2C1BFC93B0034E732034C342CEB4A671802&fileName=/typescript-5.9.0-insiders.20250418.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.9.0-pr-61589-11".;

typescript-bot · 2025-04-18T20:04:42Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2025-04-18T20:04:48Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/61589/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Timeout"

Otherwise...

Everything looks good!

typescript-bot · 2025-04-18T20:22:47Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₅	_{+1 (+ 2.94%)}	_~	_~	_{p=0.001 n=6}
_Symbols	_62,390	_62,396	_{+6 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_50,395	_50,411	_{+16 (+ 0.03%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{193,546k (± 0.76%)}	_{192,063k (± 0.99%)}	_~	_190,814k	_194,617k	_{p=0.230 n=6}
_{Parse Time}	_{1.31s (± 0.62%)}	_{1.31s (± 0.39%)}	_~	_1.31s	_1.32s	_{p=0.114 n=6}
_{Bind Time}	_0.73s	_0.73s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.74s (± 0.27%)}	_{9.62s (± 0.13%)}	_{-0.12s (- 1.21%)}	_9.61s	_9.64s	_{p=0.005 n=6}
_{Emit Time}	_{2.73s (± 0.68%)}	_{2.72s (± 0.77%)}	_~	_2.69s	_2.74s	_{p=0.418 n=6}
_{Total Time}	_{14.51s (± 0.28%)}	_{14.38s (± 0.08%)}	_{-0.13s (- 0.87%)}	_14.36s	_14.39s	_{p=0.005 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅₆	₅₆	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_948,670	_948,671	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_410,947	_410,963	_{+16 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{1,224,382k (± 0.00%)}	_{1,224,179k (± 0.01%)}	_{-203k (- 0.02%)}	_1,224,091k	_1,224,353k	_{p=0.008 n=6}
_{Parse Time}	_{6.59s (± 0.94%)}	_{6.64s (± 0.65%)}	_~	_6.56s	_6.68s	_{p=0.195 n=6}
_{Bind Time}	_{1.89s (± 0.44%)}	_{1.88s (± 0.43%)}	_{-0.02s (- 0.97%)}	_1.87s	_1.89s	_{p=0.013 n=6}
_{Check Time}	_{32.01s (± 0.58%)}	_{31.83s (± 0.25%)}	_~	_31.70s	_31.94s	_{p=0.093 n=6}
_{Emit Time}	_{15.21s (± 0.66%)}	_{15.18s (± 0.64%)}	_~	_15.06s	_15.30s	_{p=0.810 n=6}
_{Total Time}	_{55.70s (± 0.53%)}	_{55.54s (± 0.31%)}	_~	_55.32s	_55.81s	_{p=0.378 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,360,780	_2,360,780	_~	_~	_~	_{p=1.000 n=6}
_Types	_868,446	_868,446	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,316,189k (± 0.00%)}	_{2,316,210k (± 0.00%)}	_~	_2,316,181k	_2,316,247k	_{p=0.230 n=6}
_{Parse Time}	_{10.55s (± 0.44%)}	_{10.53s (± 0.29%)}	_~	_10.49s	_10.57s	_{p=0.335 n=6}
_{Bind Time}	_{2.66s (± 1.72%)}	_{2.69s (± 1.07%)}	_~	_2.65s	_2.73s	_{p=0.518 n=6}
_{Check Time}	_{83.75s (± 1.59%)}	_{83.88s (± 1.41%)}	_~	_82.63s	_85.41s	_{p=0.810 n=6}
_{Emit Time}	_{0.36s (± 3.77%)}	_{0.36s (± 3.51%)}	_~	_0.35s	_0.38s	_{p=0.510 n=6}
_{Total Time}	_{97.33s (± 1.36%)}	_{97.46s (± 1.21%)}	_~	_96.21s	_98.99s	_{p=0.936 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,228,025	_1,228,173	_{+148 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_267,258	_267,341	_{+83 (+ 0.03%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,360,702k (± 0.02%)}	_{2,360,960k (± 0.02%)}	_~	_2,360,429k	_2,361,618k	_{p=0.689 n=6}
_{Parse Time}	_{5.21s (± 0.94%)}	_{5.20s (± 1.01%)}	_~	_5.15s	_5.27s	_{p=0.521 n=6}
_{Bind Time}	_{1.80s (± 0.78%)}	_{1.80s (± 0.42%)}	_~	_1.79s	_1.81s	_{p=0.867 n=6}
_{Check Time}	_{35.39s (± 0.30%)}	_{35.38s (± 0.26%)}	_~	_35.24s	_35.51s	_{p=0.810 n=6}
_{Emit Time}	_{3.00s (± 0.93%)}	_{3.01s (± 1.61%)}	_~	_2.97s	_3.10s	_{p=1.000 n=6}
_{Total Time}	_{45.40s (± 0.21%)}	_{45.40s (± 0.18%)}	_~	_45.30s	_45.52s	_{p=0.936 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,228,025	_1,228,173	_{+148 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_267,258	_267,341	_{+83 (+ 0.03%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,793,946k (±14.29%)}	_{3,038,523k (± 9.77%)}	_{🔻+244,577k (+ 8.75%)}	_2,431,756k	_3,160,235k	_{p=0.020 n=6}
_{Parse Time}	_{6.89s (± 2.66%)}	_{7.01s (± 1.02%)}	_~	_6.92s	_7.12s	_{p=0.471 n=6}
_{Bind Time}	_{2.17s (± 1.48%)}	_{2.17s (± 1.60%)}	_~	_2.13s	_2.23s	_{p=0.808 n=6}
_{Check Time}	_{42.91s (± 0.47%)}	_{42.92s (± 0.39%)}	_~	_42.73s	_43.13s	_{p=0.936 n=6}
_{Emit Time}	_{3.65s (± 4.43%)}	_{3.55s (± 0.92%)}	_~	_3.50s	_3.57s	_{p=0.229 n=6}
_{Total Time}	_{55.62s (± 0.27%)}	_{55.64s (± 0.37%)}	_~	_55.37s	_55.83s	_{p=0.936 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_263,403	_263,529	_{+126 (+ 0.05%)}	_~	_~	_{p=0.001 n=6}
_Types	_107,094	_107,158	_{+64 (+ 0.06%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{441,742k (± 0.02%)}	_{441,990k (± 0.01%)}	_{+248k (+ 0.06%)}	_441,937k	_442,065k	_{p=0.005 n=6}
_{Parse Time}	_{3.54s (± 1.04%)}	_{3.55s (± 0.79%)}	_~	_3.50s	_3.58s	_{p=0.413 n=6}
_{Bind Time}	_{1.33s (± 0.82%)}	_{1.32s (± 0.68%)}	_~	_1.31s	_1.33s	_{p=0.149 n=6}
_{Check Time}	_{18.99s (± 0.47%)}	_{19.07s (± 0.43%)}	_~	_18.98s	_19.18s	_{p=0.336 n=6}
_{Emit Time}	_{1.53s (± 1.35%)}	_{1.54s (± 0.54%)}	_~	_1.53s	_1.55s	_{p=0.868 n=6}
_{Total Time}	_{25.39s (± 0.33%)}	_{25.47s (± 0.37%)}	_~	_25.35s	_25.59s	_{p=0.149 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₁	₇₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,981	_226,095	_{+114 (+ 0.05%)}	_~	_~	_{p=0.001 n=6}
_Types	_94,356	_94,456	_{+100 (+ 0.11%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{371,261k (± 0.01%)}	_{371,610k (± 0.02%)}	_{+349k (+ 0.09%)}	_371,487k	_371,737k	_{p=0.005 n=6}
_{Parse Time}	_{2.90s (± 1.37%)}	_{2.91s (± 0.80%)}	_~	_2.88s	_2.95s	_{p=0.808 n=6}
_{Bind Time}	_{1.60s (± 1.00%)}	_{1.62s (± 2.34%)}	_~	_1.55s	_1.65s	_{p=0.169 n=6}
_{Check Time}	_{16.54s (± 0.34%)}	_{16.58s (± 0.68%)}	_~	_16.46s	_16.74s	_{p=0.688 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{21.05s (± 0.17%)}	_{21.12s (± 0.40%)}	_~	_21.02s	_21.23s	_{p=0.198 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₄	₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,362,714	_3,362,715	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_1,139,426	_1,139,430	_{+4 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,420,807k (± 0.00%)}	_{3,420,725k (± 0.00%)}	_~	_3,420,622k	_3,420,840k	_{p=0.066 n=6}
_{Parse Time}	_{12.12s (± 0.26%)}	_{12.08s (± 0.21%)}	_~	_12.05s	_12.12s	_{p=0.063 n=6}
_{Bind Time}	_{3.90s (± 0.38%)}	_{3.93s (± 0.54%)}	_~	_3.90s	_3.96s	_{p=0.052 n=6}
_{Check Time}	_{77.71s (± 0.19%)}	_{77.79s (± 0.46%)}	_~	_77.24s	_78.33s	_{p=0.575 n=6}
_{Emit Time}	_{25.02s (± 0.22%)}	_{25.01s (± 0.35%)}	_~	_24.94s	_25.18s	_{p=0.521 n=6}
_{Total Time}	_{118.75s (± 0.11%)}	_{118.82s (± 0.33%)}	_~	_118.14s	_119.35s	_{p=0.378 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₂	₂	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_316,041	_316,041	_~	_~	_~	_{p=1.000 n=6}
_Types	_140,052	_140,052	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{470,767k (± 0.03%)}	_{470,857k (± 0.02%)}	_~	_470,652k	_470,979k	_{p=0.298 n=6}
_{Parse Time}	_{5.17s (± 0.56%)}	_{5.14s (± 0.91%)}	_~	_5.06s	_5.18s	_{p=0.257 n=6}
_{Bind Time}	_{2.27s (± 0.62%)}	_{2.27s (± 0.92%)}	_~	_2.24s	_2.29s	_{p=0.935 n=6}
_{Check Time}	_{25.80s (± 0.18%)}	_{25.80s (± 0.37%)}	_~	_25.71s	_25.93s	_{p=0.748 n=6}
_{Emit Time}	_{0.00s (±154.76%)}	_0.00s	_~	_~	_~	_{p=0.174 n=6}
_{Total Time}	_{33.24s (± 0.17%)}	_{33.21s (± 0.30%)}	_~	_33.09s	_33.36s	_{p=0.575 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_568,548	_568,549	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_190,459	_190,460	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{498,527k (± 0.03%)}	_{498,507k (± 0.02%)}	_~	_498,380k	_498,576k	_{p=0.575 n=6}
_{Parse Time}	_{4.17s (± 0.45%)}	_{4.17s (± 0.28%)}	_~	_4.16s	_4.19s	_{p=0.621 n=6}
_{Bind Time}	_{1.51s (± 0.54%)}	_{1.50s (± 0.70%)}	_~	_1.48s	_1.51s	_{p=0.078 n=6}
_{Check Time}	_{25.00s (± 2.14%)}	_{25.07s (± 1.59%)}	_~	_24.76s	_25.61s	_{p=0.296 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{30.69s (± 1.73%)}	_{30.74s (± 1.31%)}	_~	_30.42s	_31.27s	_{p=0.629 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2025-04-18T21:10:44Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/61589/merge:

Everything looks good!

… sam key type

Andarist · 2025-04-20T16:05:51Z

@jakebailey could you rerun this again? I don't think this will fix the degraded performance (I'm working on that) but it would be nice to learn if the extended test suites can catch any new functional issues with the current version

jakebailey · 2025-04-20T16:57:03Z

@typescript-bot test it
@typescript-bot pack this

typescript-bot · 2025-04-20T16:57:07Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`pack this`	✅ Started	✅ Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2025-04-20T17:01:15Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/165038/artifacts?artifactName=tgz&fileId=C49E64C15E4422445E6375E948F8C98A365BC57BC995A2CB80EBBFEC51CD3BD302&fileName=/typescript-5.9.0-insiders.20250420.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.9.0-pr-61589-19".;

typescript-bot · 2025-04-20T17:18:59Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2025-04-20T17:19:54Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/61589/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Timeout"

Otherwise...

Everything looks good!

typescript-bot · 2025-04-20T17:43:17Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,390	_62,393	_{+3 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_50,395	_50,381	_{-14 (- 0.03%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{194,151k (± 0.95%)}	_{194,091k (± 0.96%)}	_~	_192,853k	_196,511k	_{p=0.128 n=6}
_{Parse Time}	_{1.31s (± 1.15%)}	_{1.31s (± 0.57%)}	_~	_1.30s	_1.32s	_{p=0.492 n=6}
_{Bind Time}	_0.73s	_0.73s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.75s (± 0.42%)}	_{9.82s (± 0.29%)}	_{+0.07s (+ 0.70%)}	_9.78s	_9.86s	_{p=0.019 n=6}
_{Emit Time}	_{2.73s (± 0.36%)}	_{2.74s (± 1.15%)}	_~	_2.72s	_2.80s	_{p=0.797 n=6}
_{Total Time}	_{14.51s (± 0.37%)}	_{14.59s (± 0.32%)}	_{+0.08s (+ 0.57%)}	_14.53s	_14.66s	_{p=0.030 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅₆	₅₆	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_948,670	_948,672	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_410,947	_410,962	_{+15 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{1,224,357k (± 0.00%)}	_{1,224,333k (± 0.00%)}	_~	_1,224,258k	_1,224,422k	_{p=0.470 n=6}
_{Parse Time}	_{6.62s (± 0.87%)}	_{6.65s (± 0.60%)}	_~	_6.58s	_6.70s	_{p=0.569 n=6}
_{Bind Time}	_{1.88s (± 0.40%)}	_{1.89s (± 0.52%)}	_~	_1.88s	_1.90s	_{p=0.109 n=6}
_{Check Time}	_{32.00s (± 0.36%)}	_{31.97s (± 0.32%)}	_~	_31.86s	_32.12s	_{p=0.575 n=6}
_{Emit Time}	_{15.22s (± 0.64%)}	_{15.15s (± 0.48%)}	_~	_15.05s	_15.24s	_{p=0.370 n=6}
_{Total Time}	_{55.72s (± 0.19%)}	_{55.66s (± 0.20%)}	_~	_55.50s	_55.83s	_{p=0.378 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,360,830	_2,360,830	_~	_~	_~	_{p=1.000 n=6}
_Types	_868,468	_868,468	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,315,960k (± 0.00%)}	_{2,316,065k (± 0.01%)}	_~	_2,315,937k	_2,316,558k	_{p=1.000 n=6}
_{Parse Time}	_{8.73s (± 0.47%)}	_{8.76s (± 0.35%)}	_~	_8.73s	_8.81s	_{p=0.197 n=6}
_{Bind Time}	_{2.19s (± 0.94%)}	_{2.19s (± 0.50%)}	_~	_2.18s	_2.21s	_{p=0.933 n=6}
_{Check Time}	_{69.84s (± 0.36%)}	_{69.87s (± 0.36%)}	_~	_69.53s	_70.30s	_{p=0.872 n=6}
_{Emit Time}	_{0.30s (± 2.75%)}	_{0.30s (± 2.98%)}	_~	_0.29s	_0.31s	_{p=0.550 n=6}
_{Total Time}	_{81.07s (± 0.34%)}	_{81.13s (± 0.32%)}	_~	_80.82s	_81.58s	_{p=0.748 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,228,025	_1,228,022	_{-3 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_267,258	_267,246	_{-12 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,972,231k (±10.03%)}	_{2,607,030k (±14.47%)}	_~	_2,361,757k	_3,095,546k	_{p=0.298 n=6}
_{Parse Time}	_{6.68s (± 1.72%)}	_{6.59s (± 1.53%)}	_~	_6.47s	_6.74s	_{p=0.128 n=6}
_{Bind Time}	_{2.15s (± 1.02%)}	_{2.18s (± 1.94%)}	_~	_2.12s	_2.24s	_{p=0.227 n=6}
_{Check Time}	_{42.96s (± 0.43%)}	_{42.99s (± 0.99%)}	_~	_42.45s	_43.38s	_{p=0.688 n=6}
_{Emit Time}	_{3.45s (± 1.33%)}	_{3.52s (± 2.79%)}	_~	_3.41s	_3.64s	_{p=0.471 n=6}
_{Total Time}	_{55.25s (± 0.55%)}	_{55.28s (± 0.96%)}	_~	_54.61s	_55.79s	_{p=0.575 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,228,025	_1,228,022	_{-3 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_267,258	_267,246	_{-12 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,427,654k (± 0.01%)}	_{2,427,484k (± 0.03%)}	_~	_2,426,659k	_2,428,243k	_{p=0.575 n=6}
_{Parse Time}	_{5.46s (± 1.25%)}	_{5.48s (± 1.43%)}	_~	_5.41s	_5.59s	_{p=0.688 n=6}
_{Bind Time}	_{1.81s (± 0.65%)}	_{1.82s (± 0.54%)}	_~	_1.81s	_1.83s	_{p=0.082 n=6}
_{Check Time}	_{35.45s (± 0.77%)}	_{35.35s (± 0.14%)}	_~	_35.28s	_35.40s	_{p=0.810 n=6}
_{Emit Time}	_{3.04s (± 1.30%)}	_{3.06s (± 2.04%)}	_~	_2.99s	_3.16s	_{p=0.521 n=6}
_{Total Time}	_{45.76s (± 0.72%)}	_{45.70s (± 0.21%)}	_~	_45.59s	_45.80s	_{p=0.936 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_263,403	_263,399	_{-4 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_107,094	_107,077	_{-17 (- 0.02%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{441,746k (± 0.01%)}	_{441,786k (± 0.01%)}	_~	_441,719k	_441,860k	_{p=0.298 n=6}
_{Parse Time}	_{3.56s (± 1.03%)}	_{3.55s (± 1.43%)}	_~	_3.50s	_3.63s	_{p=0.376 n=6}
_{Bind Time}	_{1.33s (± 0.67%)}	_{1.32s (± 0.68%)}	_~	_1.31s	_1.33s	_{p=0.113 n=6}
_{Check Time}	_{18.97s (± 0.37%)}	_{19.05s (± 0.36%)}	_~	_18.97s	_19.18s	_{p=0.053 n=6}
_{Emit Time}	_{1.54s (± 1.58%)}	_{1.54s (± 1.19%)}	_~	_1.52s	_1.57s	_{p=0.513 n=6}
_{Total Time}	_{25.40s (± 0.26%)}	_{25.46s (± 0.44%)}	_~	_25.36s	_25.67s	_{p=0.469 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₁	₇₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,981	_225,980	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_94,356	_94,356	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,269k (± 0.04%)}	_{371,230k (± 0.01%)}	_~	_371,179k	_371,305k	_{p=0.630 n=6}
_{Parse Time}	_{2.90s (± 0.83%)}	_{2.90s (± 1.17%)}	_~	_2.85s	_2.94s	_{p=1.000 n=6}
_{Bind Time}	_{1.61s (± 1.44%)}	_{1.60s (± 1.60%)}	_~	_1.58s	_1.64s	_{p=0.461 n=6}
_{Check Time}	_{16.50s (± 0.30%)}	_{16.55s (± 0.33%)}	_~	_16.47s	_16.62s	_{p=0.077 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{21.01s (± 0.32%)}	_{21.05s (± 0.41%)}	_~	_20.93s	_21.14s	_{p=0.470 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₄	₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,364,573	_3,364,574	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_1,140,065	_1,140,069	_{+4 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,422,246k (± 0.01%)}	_{3,422,398k (± 0.01%)}	_~	_3,421,949k	_3,422,626k	_{p=0.471 n=6}
_{Parse Time}	_{14.61s (± 0.43%)}	_{14.81s (± 3.18%)}	_~	_14.53s	_15.76s	_{p=0.689 n=6}
_{Bind Time}	_{4.67s (± 0.55%)}	_{4.71s (± 1.06%)}	_~	_4.65s	_4.79s	_{p=0.107 n=6}
_{Check Time}	_{93.00s (± 3.44%)}	_{94.02s (± 3.12%)}	_~	_90.49s	_97.92s	_{p=0.810 n=6}
_{Emit Time}	_{28.74s (± 6.69%)}	_{28.47s (± 9.87%)}	_~	_24.92s	_31.03s	_{p=0.378 n=6}
_{Total Time}	_{141.02s (± 1.44%)}	_{142.01s (± 2.55%)}	_~	_139.27s	_148.17s	_{p=0.936 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₂	₂	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_316,041	_316,041	_~	_~	_~	_{p=1.000 n=6}
_Types	_140,052	_140,052	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{470,893k (± 0.02%)}	_{470,799k (± 0.03%)}	_~	_470,667k	_471,008k	_{p=0.173 n=6}
_{Parse Time}	_{5.16s (± 0.72%)}	_{5.18s (± 0.66%)}	_~	_5.12s	_5.22s	_{p=0.332 n=6}
_{Bind Time}	_{2.26s (± 0.78%)}	_{2.24s (± 0.94%)}	_~	_2.21s	_2.27s	_{p=0.054 n=6}
_{Check Time}	_{25.79s (± 0.47%)}	_{25.82s (± 0.41%)}	_~	_25.70s	_25.97s	_{p=0.747 n=6}
_{Emit Time}	_0.00s	_{0.00s (±244.70%)}	_~	_0.00s	_0.01s	_{p=0.405 n=6}
_{Total Time}	_{33.21s (± 0.40%)}	_{33.24s (± 0.29%)}	_~	_33.13s	_33.40s	_{p=0.574 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_570,517	_570,518	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_191,417	_191,418	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{500,777k (± 0.03%)}	_{500,877k (± 0.03%)}	_~	_500,604k	_501,055k	_{p=0.173 n=6}
_{Parse Time}	_{4.31s (± 0.58%)}	_{4.31s (± 0.73%)}	_~	_4.28s	_4.37s	_{p=0.936 n=6}
_{Bind Time}	_{1.53s (± 1.12%)}	_{1.53s (± 0.87%)}	_~	_1.51s	_1.54s	_{p=0.867 n=6}
_{Check Time}	_{25.15s (± 2.07%)}	_{25.00s (± 1.36%)}	_~	_24.78s	_25.68s	_{p=1.000 n=6}
_{Emit Time}	_0.00s	_{0.00s (±244.70%)}	_~	_0.00s	_0.01s	_{p=0.405 n=6}
_{Total Time}	_{30.99s (± 1.72%)}	_{30.84s (± 1.09%)}	_~	_30.58s	_31.51s	_{p=0.936 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2025-04-20T18:26:36Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/61589/merge:

Everything looks good!

Andarist · 2025-04-21T08:10:19Z

The last results were better but there is still some slight increase in check type of Compiler-Unions. I have pushed out now a version that might address this. Could you rerun tests for me again here @jakebailey 🙏 ? :)

jakebailey · 2025-04-21T16:37:20Z

@typescript-bot test it

typescript-bot · 2025-04-21T16:37:24Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2025-04-21T17:00:35Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/61589/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Timeout"

Otherwise...

Everything looks good!

typescript-bot · 2025-04-21T17:00:45Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2025-04-21T17:31:18Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,390	_62,395	_{+5 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_50,395	_50,410	_{+15 (+ 0.03%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{195,967k (± 0.82%)}	_{194,815k (± 0.78%)}	_{-1,152k (- 0.59%)}	_191,719k	_195,540k	_{p=0.045 n=6}
_{Parse Time}	_{1.60s (± 1.60%)}	_{1.59s (± 1.24%)}	_~	_1.57s	_1.63s	_{p=0.511 n=6}
_{Bind Time}	_{0.87s (± 1.87%)}	_{0.89s (± 1.56%)}	_~	_0.87s	_0.90s	_{p=0.254 n=6}
_{Check Time}	_{11.74s (± 0.38%)}	_{11.79s (± 0.20%)}	_{+0.05s (+ 0.43%)}	_11.76s	_11.82s	_{p=0.045 n=6}
_{Emit Time}	_{3.41s (± 4.67%)}	_{3.37s (± 3.98%)}	_~	_3.26s	_3.57s	_{p=0.686 n=6}
_{Total Time}	_{17.63s (± 0.97%)}	_{17.64s (± 0.79%)}	_~	_17.52s	_17.82s	_{p=1.000 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅₆	₅₆	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_948,670	_948,681	_{+11 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_410,947	_410,967	_{+20 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{1,224,373k (± 0.00%)}	_{1,230,127k (± 0.00%)}	_{+5,754k (+ 0.47%)}	_1,230,067k	_1,230,165k	_{p=0.005 n=6}
_{Parse Time}	_{6.63s (± 0.71%)}	_{6.67s (± 0.27%)}	_~	_6.64s	_6.69s	_{p=0.104 n=6}
_{Bind Time}	_{1.89s (± 0.88%)}	_{1.88s (± 1.10%)}	_~	_1.87s	_1.92s	_{p=0.676 n=6}
_{Check Time}	_{32.01s (± 0.45%)}	_{32.41s (± 0.47%)}	_{+0.40s (+ 1.25%)}	_32.25s	_32.61s	_{p=0.005 n=6}
_{Emit Time}	_{15.21s (± 0.95%)}	_{15.27s (± 0.40%)}	_~	_15.19s	_15.35s	_{p=0.630 n=6}
_{Total Time}	_{55.73s (± 0.42%)}	_{56.24s (± 0.30%)}	_{+0.51s (+ 0.91%)}	_56.04s	_56.44s	_{p=0.005 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,360,852	_2,360,852	_~	_~	_~	_{p=1.000 n=6}
_Types	_868,468	_868,468	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,315,968k (± 0.00%)}	_{2,315,993k (± 0.00%)}	_~	_2,315,943k	_2,316,055k	_{p=0.630 n=6}
_{Parse Time}	_{8.72s (± 0.33%)}	_{8.74s (± 0.29%)}	_~	_8.71s	_8.77s	_{p=0.333 n=6}
_{Bind Time}	_{2.19s (± 0.61%)}	_{2.19s (± 0.47%)}	_~	_2.18s	_2.21s	_{p=1.000 n=6}
_{Check Time}	_{69.88s (± 0.38%)}	_{70.16s (± 0.28%)}	_~	_69.87s	_70.45s	_{p=0.066 n=6}
_{Emit Time}	_{0.30s (± 2.75%)}	_0.30s	_~	_~	_~	_{p=0.290 n=6}
_{Total Time}	_{81.08s (± 0.31%)}	_{81.40s (± 0.23%)}	_{+0.31s (+ 0.38%)}	_81.11s	_81.65s	_{p=0.045 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,228,025	_1,228,052	_{+27 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_267,258	_267,249	_{-9 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,360,355k (± 0.01%)}	_{2,360,694k (± 0.02%)}	_~	_2,359,860k	_2,361,479k	_{p=0.230 n=6}
_{Parse Time}	_{5.22s (± 0.85%)}	_{5.20s (± 0.80%)}	_~	_5.16s	_5.28s	_{p=0.469 n=6}
_{Bind Time}	_{1.80s (± 0.84%)}	_{1.80s (± 0.57%)}	_~	_1.78s	_1.81s	_{p=0.867 n=6}
_{Check Time}	_{35.34s (± 0.24%)}	_{35.44s (± 0.07%)}	_{+0.10s (+ 0.28%)}	_35.40s	_35.47s	_{p=0.013 n=6}
_{Emit Time}	_{3.01s (± 0.78%)}	_{3.00s (± 1.98%)}	_~	_2.92s	_3.08s	_{p=1.000 n=6}
_{Total Time}	_{45.36s (± 0.25%)}	_{45.45s (± 0.11%)}	_~	_45.36s	_45.50s	_{p=0.128 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,228,025	_1,228,052	_{+27 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_267,258	_267,249	_{-9 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,428,151k (± 0.01%)}	_{2,427,930k (± 0.02%)}	_~	_2,427,101k	_2,428,549k	_{p=0.575 n=6}
_{Parse Time}	_{5.43s (± 0.61%)}	_{5.48s (± 0.82%)}	_~	_5.40s	_5.53s	_{p=0.066 n=6}
_{Bind Time}	_{1.81s (± 0.54%)}	_{1.81s (± 0.89%)}	_~	_1.78s	_1.83s	_{p=1.000 n=6}
_{Check Time}	_{35.47s (± 0.60%)}	_{35.55s (± 0.97%)}	_~	_35.19s	_36.01s	_{p=0.873 n=6}
_{Emit Time}	_{3.06s (± 0.96%)}	_{3.06s (± 0.56%)}	_~	_3.04s	_3.08s	_{p=1.000 n=6}
_{Total Time}	_{45.78s (± 0.52%)}	_{45.89s (± 0.79%)}	_~	_45.47s	_46.38s	_{p=0.521 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_263,403	_263,426	_{+23 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_107,094	_107,082	_{-12 (- 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{441,728k (± 0.01%)}	_{442,353k (± 0.25%)}	_{+624k (+ 0.14%)}	_441,805k	_444,649k	_{p=0.008 n=6}
_{Parse Time}	_{3.55s (± 1.09%)}	_{3.54s (± 0.90%)}	_~	_3.49s	_3.57s	_{p=0.420 n=6}
_{Bind Time}	_{1.31s (± 1.12%)}	_{1.32s (± 0.64%)}	_~	_1.31s	_1.33s	_{p=0.867 n=6}
_{Check Time}	_{18.93s (± 0.45%)}	_{19.02s (± 0.58%)}	_~	_18.93s	_19.22s	_{p=0.229 n=6}
_{Emit Time}	_{1.54s (± 1.16%)}	_{1.53s (± 1.52%)}	_~	_1.49s	_1.55s	_{p=1.000 n=6}
_{Total Time}	_{25.33s (± 0.45%)}	_{25.40s (± 0.48%)}	_~	_25.29s	_25.63s	_{p=0.336 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₁	₇₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,981	_225,980	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_94,356	_94,356	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,326k (± 0.04%)}	_{371,506k (± 0.07%)}	_~	_371,278k	_371,894k	_{p=0.128 n=6}
_{Parse Time}	_{2.88s (± 1.24%)}	_{2.92s (± 0.42%)}	_{+0.04s (+ 1.22%)}	_2.90s	_2.93s	_{p=0.042 n=6}
_{Bind Time}	_{1.59s (± 0.62%)}	_{1.60s (± 1.02%)}	_~	_1.58s	_1.62s	_{p=0.737 n=6}
_{Check Time}	_{16.50s (± 0.24%)}	_{16.55s (± 0.37%)}	_~	_16.44s	_16.60s	_{p=0.092 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_0.00s	_~	_~	_~	_{p=0.405 n=6}
_{Total Time}	_{20.97s (± 0.25%)}	_{21.07s (± 0.26%)}	_{+0.09s (+ 0.45%)}	_20.99s	_21.12s	_{p=0.037 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₄	₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,364,906	_3,364,908	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_1,140,149	_1,140,154	_{+5 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,422,997k (± 0.01%)}	_{3,422,791k (± 0.00%)}	_~	_3,422,702k	_3,422,858k	_{p=0.078 n=6}
_{Parse Time}	_{18.19s (± 0.45%)}	_{18.25s (± 2.75%)}	_~	_17.96s	_19.27s	_{p=0.149 n=6}
_{Bind Time}	_{5.78s (± 0.53%)}	_{5.77s (± 0.39%)}	_~	_5.75s	_5.81s	_{p=0.936 n=6}
_{Check Time}	_{115.08s (± 4.87%)}	_{113.40s (± 2.51%)}	_~	_111.09s	_118.35s	_{p=0.936 n=6}
_{Emit Time}	_{33.29s (± 9.40%)}	_{35.30s (± 5.28%)}	_~	_31.51s	_36.37s	_{p=0.471 n=6}
_{Total Time}	_{172.33s (± 2.13%)}	_{172.73s (± 1.10%)}	_~	_170.82s	_175.21s	_{p=0.261 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₂	₂	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_316,147	_316,147	_~	_~	_~	_{p=1.000 n=6}
_Types	_140,126	_140,126	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{470,850k (± 0.04%)}	_{470,953k (± 0.02%)}	_~	_470,798k	_471,051k	_{p=0.230 n=6}
_{Parse Time}	_{4.17s (± 1.04%)}	_{4.15s (± 1.25%)}	_~	_4.06s	_4.20s	_{p=0.808 n=6}
_{Bind Time}	_{1.82s (± 1.46%)}	_{1.82s (± 0.83%)}	_~	_1.80s	_1.84s	_{p=0.743 n=6}
_{Check Time}	_{20.80s (± 0.45%)}	_{20.80s (± 0.36%)}	_~	_20.68s	_20.89s	_{p=1.000 n=6}
_{Emit Time}	_{0.00s (±154.76%)}	_{0.00s (±154.76%)}	_~	_0.00s	_0.01s	_{p=1.000 n=6}
_{Total Time}	_{26.80s (± 0.41%)}	_{26.77s (± 0.26%)}	_~	_26.69s	_26.88s	_{p=0.748 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_570,517	_570,518	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_191,417	_191,418	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{500,820k (± 0.04%)}	_{500,953k (± 0.01%)}	_~	_500,850k	_501,000k	_{p=0.092 n=6}
_{Parse Time}	_{4.31s (± 0.45%)}	_{4.32s (± 0.35%)}	_~	_4.30s	_4.34s	_{p=0.623 n=6}
_{Bind Time}	_{1.52s (± 0.99%)}	_{1.54s (± 0.96%)}	_{+0.02s (+ 1.43%)}	_1.52s	_1.56s	_{p=0.040 n=6}
_{Check Time}	_{25.11s (± 2.48%)}	_{24.90s (± 0.32%)}	_~	_24.82s	_25.03s	_{p=1.000 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{30.94s (± 2.02%)}	_{30.76s (± 0.28%)}	_~	_30.64s	_30.89s	_{p=0.688 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2025-04-21T18:09:37Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/61589/merge:

Everything looks good!

Andarist added 6 commits April 17, 2025 00:09

Improve .origin preservation in getNarrowedTypeWorker

5d3fe0a

bring back discriminant logic

2eecb4d

Revert "bring back discriminant logic"

83bab0d

This reverts commit 2eecb4d.

brign back comments

40ebaee

Bring the discriminant logic back in a different form

2097c67

add comment

Loading
Loading status checks…

5c8de5d

github-project-automation bot added this to PR Backlog Apr 17, 2025

github-project-automation bot moved this to Not started in PR Backlog Apr 17, 2025

typescript-bot added the For Backlog Bug label Apr 17, 2025

Andarist commented Apr 17, 2025

View reviewed changes

Andarist marked this pull request as draft April 17, 2025 15:18

fixed narrowing by a type without a discriminant

Loading
Loading status checks…

f3f4f5b

fix an extra case when the union has duplicated constituents with the…

Loading
Loading status checks…

9850ba6

… sam key type

try to optimize

Loading
Loading status checks…

29ae00a

Improve .origin preservation in getNarrowedTypeWorker #61589

Are you sure you want to change the base?

Improve .origin preservation in getNarrowedTypeWorker #61589

Uh oh!

Conversation

Andarist commented Apr 17, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jakebailey commented Apr 17, 2025

Uh oh!

typescript-bot commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Apr 17, 2025

Uh oh!

typescript-bot commented Apr 17, 2025

Uh oh!

typescript-bot commented Apr 17, 2025

tsc

Uh oh!

Andarist commented Apr 17, 2025

Uh oh!

typescript-bot commented Apr 17, 2025

Uh oh!

Uh oh!

Andarist commented Apr 18, 2025

Uh oh!

jakebailey commented Apr 18, 2025

Uh oh!

typescript-bot commented Apr 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Apr 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Apr 18, 2025

Uh oh!

typescript-bot commented Apr 18, 2025

Uh oh!

typescript-bot commented Apr 18, 2025

tsc

Uh oh!

typescript-bot commented Apr 18, 2025

Uh oh!

Uh oh!

Andarist commented Apr 20, 2025

Uh oh!

jakebailey commented Apr 20, 2025

Uh oh!

typescript-bot commented Apr 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Apr 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Apr 20, 2025

Uh oh!

typescript-bot commented Apr 20, 2025

Uh oh!

typescript-bot commented Apr 20, 2025

tsc

Uh oh!

typescript-bot commented Apr 20, 2025

Uh oh!

Uh oh!

Andarist commented Apr 21, 2025

Uh oh!

jakebailey commented Apr 21, 2025

Uh oh!

typescript-bot commented Apr 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Apr 21, 2025

Improve `.origin` preservation in `getNarrowedTypeWorker` #61589

Improve `.origin` preservation in `getNarrowedTypeWorker` #61589

typescript-bot commented Apr 17, 2025 •

edited

Loading

typescript-bot commented Apr 17, 2025 •

edited

Loading

typescript-bot commented Apr 18, 2025 •

edited

Loading

typescript-bot commented Apr 18, 2025 •

edited

Loading

typescript-bot commented Apr 20, 2025 •

edited

Loading

typescript-bot commented Apr 20, 2025 •

edited

Loading

typescript-bot commented Apr 21, 2025 •

edited

Loading