Fix the getCanonicalFileName in sys.ts and also check null value in f… #6509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ile watcher call back
| @@ -378,7 +378,11 @@ namespace ts { | |||
| */ | |||
| function fileEventHandler(eventName: string, relativefileName: string, baseDirPath: Path) { | |||
| // When files are deleted from disk, the triggered "rename" event would have a relativefileName of "undefined" | |||
| const filePath = relativefileName === undefined ? undefined : toPath(relativefileName, baseDirPath, getCanonicalPath); | |||
| /* tslint:disable:no-null */ | |||
| const filePath = relativefileName === undefined || relativefileName === null | |||
There was a problem hiding this comment.
typeof relativeFileName !== "string"?
|
👍 with my minor comments. |
zhengbli
added a commit
that referenced
this pull request
Jan 16, 2016
Fix the getCanonicalFileName in sys.ts and also check null value in f…
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ile watcher call back
This PR fixes the
getCanonicalFileNamefunction used insys.tsfor file systems using case sensitive file names. Also added checking fornullfor file watcher callbacks as node sometimes will passnullas a parameter value.