Treat .js as JSX #6562
Merged
Treat .js as JSX #6562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should add a unit test with --allowJs and some JSX syntax in there, and make sure no errors are reported. |
|
👍 |
|
Why exactly are we doing this? |
|
@DanielRosenwasser Because ReactNative uses JSX directly in .js files, so this is becoming popular. VSCode has asked for this. As JSX is a superset, there is no ambiguity with plain JavaScript. |
|
Need to update the tests also. As expected, some errors changed now that parsing default has changed (though only 2, and the errors look like an improvement - good job! :-) ). Once done- 👍 |
| @@ -546,7 +546,7 @@ namespace ts { | |||
|
|
|||
| function getLanguageVariant(fileName: string) { | |||
| // .tsx and .jsx files are treated as jsx language variant. | |||
| return fileExtensionIs(fileName, ".tsx") || fileExtensionIs(fileName, ".jsx") ? LanguageVariant.JSX : LanguageVariant.Standard; | |||
| return fileExtensionIs(fileName, ".tsx") || fileExtensionIs(fileName, ".jsx") || fileExtensionIs(fileName, '.js') ? LanguageVariant.JSX : LanguageVariant.Standard; | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.