Don't choke on switches in --example=VALUE format

[ghost]

Issue #6758

This treats --example=VALUE as if you had written --example VALUE. This follows the conventions for other tools. Compare with the output of ls --help, cp --help, rm --help, mkdir --help, etc. It's probably too late to just drop support for the second format.

[msftclas]

Hi @viispade, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

[DanielRosenwasser]

This no longer works correctly because shortOptionNames uses lowercase keys

[ghost]

Example: tsc -V will throw an error

Got it.

[DanielRosenwasser]

Hey @viispade, thanks for the PR. As a heads up, you're going to get linting errors in the CI build for things like using var instead of let and const. Just fix those up (run jake lint) and that should fix things right up.

[DanielRosenwasser]

Get rid of the toString(), just index at 0.

[DanielRosenwasser]

Also, this isn't necessarily a "long-form" so just make it optionName

[ghost]

ping

[RyanCavanaugh]

Looks OK to me. @mhegazy ?

[RyanCavanaugh]

Actually we need to agree on the underlying issue first

[ghost]

What is pending? If this is awaiting Anders's input, can you say so in the issue so we all know what all is still needed?

[DanielRosenwasser]

I think we need to decide if we want to allow the general scenario for down the line. It seems innocuous but it's still extra complexity and adds more ways to do the same thing, which arguably can make things more confusing for people.

[RyanCavanaugh]

@viispade that's the intent of the "In Discussion" label

[ghost]

I don't think my last comment was gruff, but if I try to read it in a way different from how I wrote it, I can understand that someone could interpret it that way. To be clear, I was asking for clarification about what the rubric is for the discussion so everyone can understand what the blockers are, and nothing more.

@viispade that's the intent of the "In Discussion" label

My first pass at reading this comment leaves me thinking, "Hmph. Kind of condescending..." Understanding, though, that it may have been written in a different mindset and that my reaction may not match how it was meant to be understood, I give it a more charitable reread. That turns up nothing.

And it doesn't address the question I asked.

If there was never any intent to accept any fix for the issue, I would have preferred being told that instead of being led to believe that the discussion was still open and being sent to change how I should approach the fix.

[RyanCavanaugh]

I was just making a statement of fact 😿 I'm updating the FAQ to clarify what the labels on issues mean; hopefully that can reduce any future confusion.

I have to note that contributing.md says

A bug must have an issue tracking it in the issue tracker that has been approved ("Milestone == Community") by the TypeScript team

[mhegazy]

Instead of adding complexity, why not just an error message if we run into an unknown command line option with = in it (the user is trying --v=x). something like unsupported option format '{0}={1}', use '--{0} {1}' instead.