Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emit import declarations without import clause in .d.ts files #6858

Merged
merged 3 commits into from
Feb 4, 2016

Conversation

vladima
Copy link
Contributor

@vladima vladima commented Feb 2, 2016

fixes #6835

@mhegazy
Copy link
Contributor

mhegazy commented Feb 3, 2016

can we add a test with --out and --rootDir, Just to check for renaming the module.

@mhegazy
Copy link
Contributor

mhegazy commented Feb 3, 2016

👍

@mhegazy
Copy link
Contributor

mhegazy commented Feb 4, 2016

👍

vladima added a commit that referenced this pull request Feb 4, 2016
emit import declarations without import clause in .d.ts files
@vladima vladima merged commit f058117 into master Feb 4, 2016
@vladima vladima deleted the emitImportsInDts branch February 4, 2016 20:13
@masaeedu
Copy link
Contributor

masaeedu commented Feb 4, 2016

@mhegazy This is being back-ported to 1.8, right? This is the third time I'm pestering you about this, I know, sorry. 😄

vladima added a commit that referenced this pull request Feb 4, 2016
emit import declarations without import clause in .d.ts files
@mhegazy
Copy link
Contributor

mhegazy commented Feb 4, 2016

it should be ported to 1.8, and should be in typescript@next later tonight.

vladima added a commit that referenced this pull request Feb 4, 2016
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-exports of external modules with side effects are erased from ES5 targets
4 participants