Js module search depth #6928
Js module search depth #6928
Conversation
|
Out of curiosity, how feasible would it be to remove the limit but then (likely in the background) generate and cache a flattened definition file for each top level module (so we don't have to keep all that backing JS in the service)? Deps don't usually change all that frequently. |
| } | ||
| if (typeof jsonContent.main === "string") { | ||
| const path = normalizePath(combinePaths(candidate, jsonContent.main)); | ||
| const result = loadNodeModuleFromFile(/*don't add extension*/[""], path, failedLookupLocation, !directoryProbablyExists(getDirectoryPath(path), host), host); |
| if(result && result.resolvedModule && result.resolvedModule.resolvedFileName){ | ||
| if(!fileExtensionIs(result.resolvedModule.resolvedFileName, ".ts")){ | ||
| // Loaded a non-TypeScript file from a node modules search | ||
| result.resolvedModule.isJsFileFromNodeSearch = true; |
There was a problem hiding this comment.
do not think you really need that. we can just keep the depth for all files.
There was a problem hiding this comment.
Agreed. And after talking to Vlad and reviewing the code, I can likely also just use the flag he already has (isExternalLibrary).
billti
force-pushed
the
jsModuleSearchDepth
branch
from
ace9d3e to
cfcf7b5
Compare
|
Simplified the code by using an existing flag, and corrected a couple of minor nits. Also added the logic to not compile/emit any source code that was found by searching the I'll play with this a little more and add some further tests, but would appreciate a glance over to see if I've overlooked some behavior or requirement somewhere. |
|
Closing this, as it's not going to make 1.8. I have a pull request for |
This is a possible solution for #6670 (load JavaScript files from
node_modules).A concern with searching node_modules and loading JavaScript code is just how much code we might suck in on a project with lots of dependencies (or even a few, if those have a large dependency chain). This adds a setting to specify how many "hops" to go when loading JavaScript files while searching
node_modules.As an example, just using Gulp, with a setting of
1it loads all the JavaScript files in the 'gulp' package, but does not follow its top level imports. This gives intellisense such as the below.Note how the gulp exports are visible, however
srcis showing asanyas this is a re-export of another dependency. With a setting of2(or deeper), this resolves also, as shown below:A question is what to default this setting at. Even with just Gulp, this loads 147 JavaScript files if loading all dependencies.
0seems unhelpful. Perhaps1is a reasonable default?@vladima for feedback on the code, and @egamma for feedback on the defaults.