Array.prototype.filter.not.forcing.boolean

[NimaZahedi]

Fixes #
Changed the return value of Array.prototype.filter, use any instead of boolean!
based on this issue: #5850

[msftclas]

Hi @NimaZahedi, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

[RyanCavanaugh]

Missing baseline file... run these commands:

• jake runtests
• jake baseline-accept
• git add -A .
• git commit -m "Add baselines"
• git push

[NimaZahedi]

@RyanCavanaugh Ok, but isn't the same as #7776? 😕

[DanielRosenwasser]

@NimaZahedi Ryan means that we shouldn't even have generated an error baseline given your change.

@yuit does the test harness use the LKG's libs?

[RyanCavanaugh]

Ping @yuit - which files are the correct ones to edit?

[NimaZahedi]

@RyanCavanaugh @DanielRosenwasser
I've tried these two set of commands:

• First
  • Make my changes (writing test and fix issue)
  • jake (updating built/local/ files d.ts)
  • jake runtests
  • jake baseline-accept
  • jake runtests
• Second
  • Writing test
  • jake runtests
  • jake baseline-accept
  • Fix issue
  • jake (updating built/local/ files d.ts)
  • jake runtests

[yuit]

@DanielRosenwasser the harness will pick up lib files built to built\local. @NimaZahedi, the file you edit is correct, the issue here is that there are multiple interface of Array-ish (ReadonlyArray, Array, Int8Array etc.); There are around 11 of them. You will want to update them all.

[NimaZahedi]

@yuit I'll do, sure. thanks :)

[NimaZahedi]

@yuit Should I write test case for every single of those types? (I mean the interfaces whose filter method is changed)

[RyanCavanaugh]

👍

No need to write a test for every overload

[mhegazy]

👍

[yuit]

@NimaZahedi look goods :) Thanks!