-
Notifications
You must be signed in to change notification settings - Fork 12.8k
[Salsa] Support @typedef for jsdoc #8103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
df91ef0
Simple case and scoping
zhengbli 23bca4e
Support the case with @property and @type
9a8f639
Support the case with variable name as @typedef type name
2945f64
Add tests for renaming and incremental parsing. Changed how the AST w…
zhengbli a3d74ad
Merge branch 'master' of https://github.com/Microsoft/TypeScript into…
zhengbli 0dddcf4
code clean up
zhengbli 15cbb02
refactor
zhengbli 870fd84
Merge branch 'master' of https://github.com/Microsoft/TypeScript into…
zhengbli d568d79
resolve build error
zhengbli 79bb4ba
Fix broken test
zhengbli 9ff02b1
Merge branch 'master' of https://github.com/Microsoft/TypeScript into…
zhengbli 5f9fa69
Merge branch 'master' of https://github.com/Microsoft/TypeScript into…
zhengbli 81ce532
Change how typedef tag is parsed
zhengbli e69976c
Merge branch 'master' of https://github.com/Microsoft/TypeScript into…
zhengbli 18ee4b0
cr feedback
zhengbli 59b188d
Add navigationTo test for jsdoc typedef
zhengbli 5261467
Merge branch 'master' of https://github.com/Microsoft/TypeScript into…
zhengbli e93f9df
Fix broken test
zhengbli 241920c
Merge branch 'outerControlFlows' of https://github.com/Microsoft/Type…
zhengbli 630517b
Merge branch 'master' of https://github.com/Microsoft/TypeScript into…
zhengbli eb0f035
Remove unused parameter
zhengbli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add test cases that fail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's tricky as currently we don't report error happens within JSDoc comments