Skip to content

Fix display for literal members #8125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 18, 2016
Merged

Conversation

DanielRosenwasser
Copy link
Member

Fixes #606 (comment)

A picture of the old behavior for convenience:
image

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@@ -2078,7 +2106,7 @@ namespace ts {
}
}

function writeTypeofSymbol(type: ObjectType, typeFormatFlags?: TypeFormatFlags) {
function writeTypeOSymbol(type: ObjectType, typeFormatFlags?: TypeFormatFlags) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you meant to rename this function like this. 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't use an apostrophe. 😉

@sheetalkamat
Copy link
Member

👍

@DanielRosenwasser DanielRosenwasser merged commit 0a2a8cc into master Apr 18, 2016
@DanielRosenwasser DanielRosenwasser deleted the fixDisplayForStringyMembers branch April 18, 2016 17:33
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants