Properly display narrowed types when hovering in IDE #8324
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects the type information displayed when hovering over variables in the IDE. Specifically, the
getTypeOfSymbolAtLocation
function used by the language service now consistently returns the narrowed type of a variable unless the variable is the target of an assignment. The PR also removes the old (and shimmed)getNarrowedTypeOfReference
function and replaces all usages with calls to the newgetFlowTypeOfReference
function.