Fix 8467: Fix incorrect emit for accessing static property in static propertyDeclaration

[yuit]

Fix #8467

@vladima could you take a look? :)

EDIT: this change need to be ported to "transforms" branch

[jeffreymorlan]

A tricky case to consider - right now class-expression temporary variables are scoped to the whole function, so they may have been overwritten by the time the access is done:

const arr: {y(): number}[] = [];
for (let i = 0; i < 3; i++) {
    arr.push(class C {
        static x = i;
        static y = () => C.x * 2;
    });
}
arr.forEach(C => console.log(C.y()));

This should print 0, 2, 4 but the way class-expression temporaries are currently, it's going to print 4, 4, 4

[yuit]

@jeffreymorlan Thanks for pointing this out!. The case in your example will be emit incorrect as well even without this change. I will investigate and pull in the fix here

EDIT: I will put the fix for above bug in separate PR. I also open the bug #8578

[yuit]

@mhegazy @vladima could you guys take a look?

[dmudro]

hopefully this can be merged soon in the master as has been breaking static class members for some time when using TS nightly? thanks!

[mhegazy]

👍