This parameters in lib

[sandersn]

Fixes #9654

Adds parameters for all the primitives, not just String.

Unfortunately, 376 additions, 373 deletions is too many for github to show. So you can't actually see the changes themselves in the web UI.

[sandersn]

Looks like Codeflow will work for the Microsoft-internal folks. You just have to install Codeflow's Chrome extension.

[weswigham]

@sandersn Shouldn't all the subclassable interfaces (ie, Array<T>) have this function types of this: this? Array is already generic, so there's minimal opportunity cost to it.

[sandersn]

Unfortunately, switching to this: this exposes a bug with assignability checking for (I believe) types that have lots of methods with this: this. I don't think it is specific to Array necessarily.

I'll open an issue on it when I get a minimal repro. Until then I'll leave the PR the way it is.

[sandersn]

I opened #9707, but I didn't get the bug much smaller.

[mhegazy]

@sandersn i would say let's close this one until we figure out #9707. i do agree we need to fix that one.

[sandersn]

#9707 is actually fixed. I just didn't have time to come back to this PR.

[mhegazy]

Ah. i actually was thinking of #10288, sorry about that.

but now that i am looking at the right bug, I assume no harm comes from this change.

[sandersn]

Unfortunately, it's not done. @weswigham pointed out that Array<T> should have this: this, so I still need to do that before it's finished.

[sandersn]

Actually, I think I misunderstood. Yes, even without fixing #10288, adding more this annotations is useful. (It would be more useful if we could fix #10288.)

[sandersn]

@mhegazy this change is finished now that I added this: this for Array and Object. There's no performance impact, as measured by running the Monaco and TFS performance baselines.

[mhegazy]

Based on conversation with @sandersn, this change has little value, but introduces a new set of complexities to the library and checking the library. value does not offset the cost.