Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade tsd to typings, Related to #9658 #9724

Merged
merged 1 commit into from
Jul 21, 2016
Merged

Upgrade tsd to typings, Related to #9658 #9724

merged 1 commit into from
Jul 21, 2016

Conversation

sudheesh001
Copy link
Contributor

No description provided.

@msftclas
Copy link

Hi @sudheesh001, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Sudheesh Singanamalla). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@weswigham
Copy link
Member

So.... We don't actually use this task anymore. We even cut it from the gulpfile. We were planning on just straight up removing the tsd dev dependency, since we can now use @types for what we need.

@sudheesh001
Copy link
Contributor Author

@weswigham I've updated the pull request to remove the tsd dependency, Please let me know in case there are more changes needed 😄

mhegazy
mhegazy reviewed Jul 19, 2016
View reviewed changes
Jakefile.js
console.log(cmd);
exec(cmd);
}, { async: true });
var scriptsTypingsJson = path.join(scriptsDirectory, "typings.json");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not think we need this either.

@sudheesh001
Copy link
Contributor Author

@weswigham Updated the pull request 😄

@weswigham
Copy link
Member

Seems good. I don't see any other vestiges of tsd left in the repo, so I'll merge it.

@weswigham weswigham merged commit f24341f into microsoft:master Jul 21, 2016
@sudheesh001 sudheesh001 deleted the Patch9658 branch July 22, 2016 06:55
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sudheesh001 @msftclas @weswigham @mhegazy