Return correct errror message for 'git gui' on Mac

microsoft · Jul 31, 2019 · 405aac1 · 405aac1
1 parent bb14fbe
commit 405aac1
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 7 deletions.
diff --git a/GVFS/GVFS.Hooks/HooksPlatform/GVFSHooksPlatform.Mac.cs b/GVFS/GVFS.Hooks/HooksPlatform/GVFSHooksPlatform.Mac.cs
@@ -23,5 +23,10 @@ public static string GetNamedPipeName(string enlistmentRoot)
         {
             return MacPlatform.GetNamedPipeNameImplementation(enlistmentRoot);
         }
+
+        public static string GetGitGuiBlockedMessage()
+        {
+            return "git gui is not supported in VFS for Git repos on Mac";
+        }
     }
 }
diff --git a/GVFS/GVFS.Hooks/HooksPlatform/GVFSHooksPlatform.Windows.cs b/GVFS/GVFS.Hooks/HooksPlatform/GVFSHooksPlatform.Windows.cs
@@ -46,5 +46,11 @@ public static string GetUpgradeHighestAvailableVersionDirectory()
         {
             return WindowsPlatform.GetUpgradeHighestAvailableVersionDirectoryImplementation();
         }
+
+        public static string GetGitGuiBlockedMessage()
+        {
+            return "To access the 'git gui' in a GVFS repo, please invoke 'git-gui.exe' instead.";
+        }
+
     }
 }
diff --git a/GVFS/GVFS.Hooks/Program.cs b/GVFS/GVFS.Hooks/Program.cs
@@ -133,13 +133,7 @@ private static void CheckForLegalCommands(string[] args)
             switch (command)
             {
                 case "gui":
-                    // We use RuntimeInformation instead of GVFSPlatform to avoid loading GVFS.Common into GVFS.Hooks
-                    if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
-                    {
-                        ExitWithError("git gui is not supported in VFS for Git repos on Mac");
-                    }
-
-                    ExitWithError("To access the 'git gui' in a GVFS repo, please invoke 'git-gui.exe' instead.");
+                    ExitWithError(GVFSHooksPlatform.GetGitGuiBlockedMessage());
                     break;
             }
         }