remove unused notification logic on Linux

microsoft · Jul 29, 2020 · 683dbbf · 683dbbf
1 parent aef9cd7
commit 683dbbf
Showing 1 changed file with 11 additions and 35 deletions.
diff --git a/ProjFS.Linux/PrjFSLib.Linux.Managed/VirtualizationInstance.cs b/ProjFS.Linux/PrjFSLib.Linux.Managed/VirtualizationInstance.cs
@@ -399,42 +399,23 @@ private int HandleNonProjEvent(ref ProjFS.Event ev, bool perm)
             }
 
             bool isDirectory = (ev.Mask & ProjFS.Constants.PROJFS_ONDIR) != 0;
-            string triggeringProcessName = GetProcCmdline(ev.Pid);
-            byte[] providerId = new byte[PlaceholderIdLength];
-            byte[] contentId = new byte[PlaceholderIdLength];
-            string relativePath = PtrToStringUTF8(ev.Path);
-            Result result = Result.Success;
+            string relativePath;
 
-            if (!isDirectory)
+            if (nt == NotificationType.FileRenamed ||
+                nt == NotificationType.HardLinkCreated)
             {
-                string currentRelativePath = relativePath;
-
-                // TODO(Linux): can other intermediate file ops race us here?
-                if (nt == NotificationType.FileRenamed || nt == NotificationType.HardLinkCreated)
-                {
-                    currentRelativePath = PtrToStringUTF8(ev.TargetPath);
-                    relativePath = currentRelativePath;
-                }
-
-                result = this.projfs.GetProjAttrs(
-                    currentRelativePath,
-                    providerId,
-                    contentId);
+                relativePath = PtrToStringUTF8(ev.TargetPath);
             }
-
-            if (result == Result.Success)
+            else
             {
-                result = this.OnNotifyOperation(
-                    commandId: 0,
-                    relativePath: relativePath,
-                    providerId: providerId,
-                    contentId: contentId,
-                    triggeringProcessId: ev.Pid,
-                    triggeringProcessName: triggeringProcessName,
-                    isDirectory: isDirectory,
-                    notificationType: nt);
+                relativePath = PtrToStringUTF8(ev.Path);
             }
 
+            Result result = this.OnNotifyOperation(
+                relativePath: relativePath,
+                isDirectory: isDirectory,
+                notificationType: nt);
+
             int ret = -result.ToErrno();
 
             if (perm)
@@ -463,12 +444,7 @@ private int HandlePermEvent(ref ProjFS.Event ev)
         }
 
         private Result OnNotifyOperation(
-            ulong commandId,
             string relativePath,
-            byte[] providerId,
-            byte[] contentId,
-            int triggeringProcessId,
-            string triggeringProcessName,
             bool isDirectory,
             NotificationType notificationType)
         {