-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use IsIncluded only on folder entries #1345
Use IsIncluded only on folder entries #1345
Conversation
/azp run PR - Windows - Functional Tests (Include Mode) |
Azure Pipelines successfully started running 1 pipeline(s). |
bcfe9b7
to
31e22fb
Compare
31e22fb
to
1e72811
Compare
/azp run PR - Windows - Functional Tests (Sparse Mode) |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nit. I pulled this branch and installed locally. Using the gvfs sparse --add
verb works as I expect! Great work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this is looking great 😃
Just some minor questions/comments to help with my understanding of the changes.
GVFS/GVFS.Virtualization/Projection/GitIndexProjection.SortedFolderEntries.cs
Show resolved
Hide resolved
GVFS/GVFS.UnitTests/Virtualization/Projection/SortedFolderEntriesTests.cs
Show resolved
Hide resolved
GVFS/GVFS.UnitTests/Virtualization/Projection/SortedFolderEntriesTests.cs
Show resolved
Hide resolved
GVFS/GVFS.UnitTests/Virtualization/Projection/SortedFolderEntriesTests.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the comment I left in UpdateOrDeleteFilePlaceholder
all of the latest changes are looking good to me!
/azp run PR - Windows - Functional Tests (Sparse Mode) |
Azure Pipelines successfully started running 1 pipeline(s). |
* Use IsIncluded only on folder entries * Add more tests for SortedFolderEntries * Add comments for better understanding of the code * Remove call to GetFolderSparseState in UpdateOrDeleteFilePlaceholder
* Use IsIncluded only on folder entries * Add more tests for SortedFolderEntries * Add comments for better understanding of the code * Remove call to GetFolderSparseState in UpdateOrDeleteFilePlaceholder
@wilbaker these are the changes to use only the
IsIncluded
on a folder.