Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use IsIncluded only on folder entries #1345

Conversation

kewillford
Copy link
Member

@wilbaker these are the changes to use only the IsIncluded on a folder.

@kewillford kewillford requested a review from wilbaker July 22, 2019 18:25
@kewillford
Copy link
Member Author

/azp run PR - Windows - Functional Tests (Include Mode)

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kewillford
Copy link
Member Author

/azp run PR - Windows - Functional Tests (Sparse Mode)

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@derrickstolee derrickstolee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit. I pulled this branch and installed locally. Using the gvfs sparse --add verb works as I expect! Great work.

Copy link
Member

@wilbaker wilbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is looking great 😃

Just some minor questions/comments to help with my understanding of the changes.

Copy link
Member

@wilbaker wilbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the comment I left in UpdateOrDeleteFilePlaceholder all of the latest changes are looking good to me!

@kewillford
Copy link
Member Author

/azp run PR - Windows - Functional Tests (Sparse Mode)

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kewillford kewillford merged commit abaa689 into microsoft:features/included-folders Jul 30, 2019
@kewillford kewillford deleted the include-simplify-folders branch July 30, 2019 20:27
kewillford pushed a commit that referenced this pull request Jul 30, 2019
* Use IsIncluded only on folder entries

* Add more tests for SortedFolderEntries

* Add comments for better understanding of the code

* Remove call to GetFolderSparseState in UpdateOrDeleteFilePlaceholder
kewillford pushed a commit that referenced this pull request Aug 5, 2019
* Use IsIncluded only on folder entries

* Add more tests for SortedFolderEntries

* Add comments for better understanding of the code

* Remove call to GetFolderSparseState in UpdateOrDeleteFilePlaceholder
@alameenshah alameenshah added this to the M159 milestone Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants