-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade: Fix test flakiness around upgrade reminders #1381
Upgrade: Fix test flakiness around upgrade reminders #1381
Conversation
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
If we fail to communicate with the mount process, then 'gvfs status' gives us the information we want, not 'git status'. Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Use a new environment variable, GVFS_UPGRADE_DETERMINISTIC, to always print the "upgrade available" message, if it is present. This should fix test flakiness and issue microsoft#852. Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/azp run GitHub VFSForGit Mac Functional Tests |
No pipelines are associated with this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
/azp run GitHub VFSForGit Mac Functional Tests |
No pipelines are associated with this pull request. |
@derrickstolee with this change the functional tests are no longer testing/validating the upgrade reminder logic in the hooks because Rather than adding the check for |
I think this change allows us to test most of the product code path, and provides value. I guess we could get even closer by tweaking the following line:
to something like:
So this environment variable would only change the frequency (to have it run every time). |
@jamill thanks for posting that suggestion, it made me realize I misread the change to the Thanks! /cc: @derrickstolee |
Should fix #852.
The fix is to use an environment variable to always show the upgrade message, if present.
While looking at the post-command hook code, I discovered some simple cleanups that are isolated to different commits:
gvfs status
instead ofgit status
.