Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper error message for 'git gui' on Mac #1388

Merged
merged 1 commit into from
Aug 1, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions GVFS/GVFS.Hooks/HooksPlatform/GVFSHooksPlatform.Mac.cs
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,10 @@ public static string GetNamedPipeName(string enlistmentRoot)
{
return MacPlatform.GetNamedPipeNameImplementation(enlistmentRoot);
}

public static string GetGitGuiBlockedMessage()
{
return "git gui is not supported in VFS for Git repos on Mac";
}
}
}
5 changes: 5 additions & 0 deletions GVFS/GVFS.Hooks/HooksPlatform/GVFSHooksPlatform.Windows.cs
Original file line number Diff line number Diff line change
Expand Up @@ -46,5 +46,10 @@ public static string GetUpgradeHighestAvailableVersionDirectory()
{
return WindowsPlatform.GetUpgradeHighestAvailableVersionDirectoryImplementation();
}

public static string GetGitGuiBlockedMessage()
{
return "To access the 'git gui' in a GVFS repo, please invoke 'git-gui.exe' instead.";
}
}
}
2 changes: 1 addition & 1 deletion GVFS/GVFS.Hooks/Program.cs
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ private static void CheckForLegalCommands(string[] args)
switch (command)
{
case "gui":
ExitWithError("To access the 'git gui' in a GVFS repo, please invoke 'git-gui.exe' instead.");
ExitWithError(GVFSHooksPlatform.GetGitGuiBlockedMessage());
break;
}
}
Expand Down