[M153 Hotfix] Update Git to revert slow commit-graph write #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See microsoft/git#168 for full details. v2.22.0 had a change that made writing commit-graph files much slower by always parsing from pack-files instead of from the commit-graph file. For some users of the OS repo, this caused super-slow performance and high memory usage. Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
|
/azp run PR - Mac - Build and Unit Test |
|
No pipelines are associated with this pull request. |
wilbaker
approved these changes
Aug 6, 2019
|
I didn't set up the |
jrbriggs
approved these changes
Aug 6, 2019
|
/azp run GitHub VFSForGit Mac Functional Tests |
|
No pipelines are associated with this pull request. |
derrickstolee
added a commit
that referenced
this pull request
Aug 6, 2019
This PR does two things: 1. Updates Git to include the slow commit-graph write fix from microsoft/git#168. Also see #1420 for the M153 hotfix. 2. Removes the multi-pack-index writes from the `PostFetchStep` and instead only writes the multi-pack-index during the `PackfileMaintenanceStep`. In order to get the most out of the step, we need to ensure we have a multi-pack-index before running the `expire` and `repack` steps. Also, we can only expire the packs from that day if they are contained in the multi-pack-index. If we agree that we should send (2) as a hotfix to the M155 release (in addition to (1), which is necessary), then I'll create a hotfix PR to that branch.
derrickstolee
added a commit
that referenced
this pull request
Aug 7, 2019
This PR does two things: Updates Git to include the slow commit-graph write fix from microsoft/git#168. Also see #1420 for the M153 hotfix. Removes the multi-pack-index writes from the PostFetchStep and instead only writes the multi-pack-index during the PackfileMaintenanceStep. In order to get the most out of the step, we need to ensure we have a multi-pack-index before running the expire and repack steps. Also, we can only expire the packs from that day if they are contained in the multi-pack-index. If we agree that we should send (2) as a hotfix to the M155 release (in addition to (1), which is necessary), then I'll create a hotfix PR to that branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See microsoft/git#168 for full details.
v2.22.0 had a change that made writing commit-graph files much
slower by always parsing from pack-files instead of from the
commit-graph file. For some users of the OS repo, this caused
super-slow performance and high memory usage.