Skip launching UI if running unattended #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In testing, we see the installer hanging until the UI is killed.
```
[Environment]::SetEnvironmentVariable("GVFS_UNATTENDED", "1", "Machine")
Start-Process .\SetupGVFS.1.0.21085.9.exe -ArgumentList "/VERYSILENT", "/NORESTART", "/NOCANCEL", "/SP-", "/CLOSEAPPLICATIONS", "/RESTARTAPPLICATIONS", "/LOG=gvfs.log", "/SUPPRESSMSGBOXES" -Wait
# Hangs until GVFS.Service.UI is killed
```
|
Hi, @50Wliu. Thanks for the contribution. We are having some build troubles due to an environment change and @mjcheetham is working on an update of our build system. When that is complete, we will circle back to this and get you some green builds and a careful review and test of your change. |
|
@derrickstolee I downloaded the installer from the CI run and confirmed that:
(Note: I'm testing this in Windows Sandbox, and the installer eventually fails when trying to set up the Windows Projected File System. But I assume that's unrelated to the changes in this PR.) |
derrickstolee
approved these changes
Jul 4, 2021
derrickstolee
added a commit
that referenced
this pull request
Jul 15, 2021
Major Updates ---------------- * Comes with `microsoft/git` v2.32.0.vfs.0.4. * This release will be available via `winget`. * The `gvfs upgrade` verb is deprecated. Any future updates will be taken via `winget`. * This version of Git has an upgrade mechanism that can advance independently of VFS for Git. Run `git update-microsoft-git` to update your Git version. * The build system has been updated to use a more recent version of .NET. * All macOS and POSIX code has been removed to simplify the build system. * A FastFetch bug around deleting files has been fixed. * A prefetch bug around downloading a small number of files has been fixed. Special thanks to contributors @ldennington, @tyrielv, @50Wliu, and @SteveBenz. Pull Requests --------------- * #1738: Bumping version of update-winget action * #1747: UpgradeVerb: write deprecation notice * #1745: do not exit early if no blobs found for a period when prefetching * #1740: Skip launching UI if running unattended * #1737: Update Git to v2.32.0 * #1746: Delete custom upgrader * #1741: Fix winget tag specification * #1744: Overhaul build and project systems and drop Mac/POSIX code * #1736: Update Git to v2.31.1.vfs.0.3 * #1735: Bumping winget action version * #1734: Adding winget workflow * #1733: Update Git to include 2.31.1 * #1730: Fix an issue with FastFetch when deleting files * #1732: Use one NuGet feed * #1726: Config: commitGraph.generationVersion=1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In testing, we see the installer hanging until the UI is killed.
Note, this is my first ever time editing an Inno Setup script or working with Pascal, so I may have gotten some things wrong :).
Fixes #1739.