file.Delete() if file.Exists #1787
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Porges
reviewed
Sep 4, 2022
| @@ -27,7 +27,10 @@ public virtual void DeleteDirectory(string path, bool recursive = true, bool ign | |||
| foreach (FileInfo file in directory.GetFiles()) | |||
| { | |||
| file.Attributes = FileAttributes.Normal; | |||
| file.Delete(); | |||
| if(file.Exists) | |||
There was a problem hiding this comment.
there is still a race here that the file exists and is then deleted before the delete is invoked; a better solution is to perform the delete unconditionally and then catch the exception if the file does not exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If some other process is deleting files at the same time, this fails the entire operation even though the intended action of files to be deleted has been successful.