Point GVFS.Service to the correct executable when C:\Program exists #1806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the binPath isn't quoted, sc.exe will first look for a file at C:\Program. Starting that will yield CreateProcess error 193 (aka invalid Win32 program). By properly quoting the binPath, we guarantee that the correct file will be loaded.
GovM-MSFT
approved these changes
Mar 8, 2024
GovM-MSFT
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue was reported to our team where someone was unable to
gvfs clonea repo. The error message they received wasCould not execute 'C:\Program Files\GVFS\GVFS.Hooks.exe'. CreateProcess error (193).After investigation, we discovered that GVFS.Service was stopped and could not be started with the same error. Eventually, we root-caused it to a rogue
C:\Programfile. When this file was deleted, GVFS.Service started up and the repo clone succeeded.To properly resolve paths with spaces in them, quotes must be added. The installer already attempted to do this, but the quotes it added around the
binPathwould get stripped away during argument parsing.Adding another set of quotes properly retains the quotes until it gets to sc.exe.
Without this change, the "path to executable" is not quoted:
With this change, the path is now quoted:
This is consistent with other services that run out of paths with spaces in them, e.g. Logi Options+, Visual Studio Installer Elevation.
Validation
New-Item -Path C:\Program -ItemType File.