Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use absolute imports #90

Merged
merged 5 commits into from
Oct 28, 2024
Merged

Conversation

bndos
Copy link
Contributor

@bndos bndos commented Oct 27, 2024

- Switch to absolute imports in `vptq/__init__.py` to ensure `vptq.ops` is correctly located on a local setup.
- Allow running `vptq` as a script without requiring the `-m` flag.
- Resolve Issue microsoft#89 where CUDA kernel was not found in local setups due to relative imports.
@bndos
Copy link
Contributor Author

bndos commented Oct 27, 2024

@bndos please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@wejoncy
Copy link
Contributor

wejoncy commented Oct 28, 2024

Hi @bndos very thanks for you contribution.

LGTM.
Could you format the code to pass the CI before we can get it merged?

@YangWang92 YangWang92 merged commit 64d3461 into microsoft:main Oct 28, 2024
7 checks passed
@YangWang92
Copy link
Contributor

Hi @bndos,
Thank you for your contribution. I noticed that there was a problem with our formatter settings, and I've just fixed it. Thank you very much for your help! I have merged it into the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CUDA Kernel Not Found: Fallback to Torch Implementation During vptq Execution in Local Setup
3 participants