fix: Updates backwards compat & fixes cntk export image bug (#789)

Fixes an issue where the images exported out of a video file were missing file extension for video projects.
microsoft · Apr 29, 2019 · 2234c8a · 2234c8a
1 parent 4d02db4
commit 2234c8a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/providers/export/cntk.ts b/src/providers/export/cntk.ts
@@ -76,13 +76,12 @@ export class CntkExportProvider extends ExportProvider<ICntkExportProviderOption
             });
         });
 
+        const buffer = await HtmlFileReader.getAssetArray(assetMetadata.asset);
         const folderName = exportSplit === ExportSplit.Train ? "positive" : "testImages";
         const labelsPath = `${this.exportFolderName}/${folderName}/${assetMetadata.asset.name}.bboxes.labels.tsv`;
         const boundingBoxPath = `${this.exportFolderName}/${folderName}/${assetMetadata.asset.name}.bboxes.tsv`;
         const binaryPath = `${this.exportFolderName}/${folderName}/${assetMetadata.asset.name}`;
 
-        const buffer = await HtmlFileReader.getAssetArray(assetMetadata.asset);
-
         await Promise.all([
             this.storageProvider.writeText(labelsPath, labelData.join(os.EOL)),
             this.storageProvider.writeText(boundingBoxPath, boundingBoxData.join(os.EOL)),

diff --git a/src/services/projectService.ts b/src/services/projectService.ts
@@ -171,7 +171,9 @@ export default class ProjectService implements IProjectService {
      * @param project The project to update
      */
     private ensureBackwardsCompatibility(project: IProject) {
-        if (project.version === "2.0.0") {
+        const projectVersion = project.version.toLowerCase();
+
+        if (projectVersion.startsWith("2.0.0")) {
             // Required for backwards compatibility with v2.0.0 release
             if (project.exportFormat.providerType === "tensorFlowPascalVOC") {
                 project.exportFormat.providerType = "pascalVOC";