Skip to content
This repository has been archived by the owner on Dec 7, 2021. It is now read-only.

fix: Bing Image Search - Support to override endpoint url #1025

Merged
merged 4 commits into from
Nov 4, 2020

Conversation

wbreza
Copy link
Contributor

@wbreza wbreza commented Nov 3, 2020

The Bing Search resource is undergoing a transition from a Cognitive Service to the Azure Marketplace. During this transition it is possible to have bing search resources that use different endpoint urls.

This fix introduces a new endpoint textbox that defaults to the new default resource url (https://api.bing.microsoft.com/). However, for users with older resources that have not specified the field it will fall back to the older cognitive services url ( https://api.cognitive.microsoft.com/bing).

In addition to the fix this also introduces addition filter options to filter image responses by image size and license type.

TODO

  • Write new unit tests
  • Add localization

image

@wbreza wbreza requested a review from tessmichi November 3, 2020 22:12
@wbreza wbreza added the bug label Nov 3, 2020
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 4, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@jding05 jding05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wbreza wbreza merged commit 27ce840 into master Nov 4, 2020
@wbreza wbreza deleted the wabrez/bing-image-search-updates branch November 4, 2020 23:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants