Skip to content
This repository has been archived by the owner on Dec 7, 2021. It is now read-only.

fix: Adds missing registration of mixins to support 'forEachAsync' #1051

Merged
merged 1 commit into from
Apr 13, 2021
Merged

fix: Adds missing registration of mixins to support 'forEachAsync' #1051

merged 1 commit into from
Apr 13, 2021

Conversation

wbreza
Copy link
Contributor

@wbreza wbreza commented Apr 12, 2021

The electron main process did not register the mixins which was causing recursive file system calls to fail.

  • Registers mixin @ electron main
  • Removes console.log statement

@wbreza wbreza requested a review from tbarlow12 April 12, 2021 22:56
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

tbarlow12
tbarlow12 approved these changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@tbarlow12 tbarlow12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - good catch

@wbreza wbreza merged commit 8c9d541 into master Apr 13, 2021
@wbreza wbreza deleted the wabrez/fix-file-listing branch April 13, 2021 15:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tbarlow12 tbarlow12 tbarlow12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wbreza @tbarlow12