Skip to content
This repository has been archived by the owner on Dec 7, 2021. It is now read-only.

feat: Add CSV Exporter #757

Merged
merged 10 commits into from
Apr 26, 2019
Merged

feat: Add CSV Exporter #757

merged 10 commits into from
Apr 26, 2019

Conversation

JacopoMangiavacchi
Copy link
Contributor

@JacopoMangiavacchi JacopoMangiavacchi commented Apr 14, 2019

Adds CSV export provider to VoTT utilizing json2csv npm package

  • Options
    • Asset State
    • Include Images

@pjlittle
Copy link
Collaborator

looks good, just have one question. At some point we may want to use a file/CSV writer so that we don't buffer everything in memory, but for now should be fine.

SonarCloud is complaining about duplicate lines, but it's unclear to me as to why.

Copy link
Contributor

@wbreza wbreza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please re-target to develop branch. I don't believe there should be anything related to active learning here.

@JacopoMangiavacchi JacopoMangiavacchi changed the base branch from jamangia/rectangle-detection to develop April 15, 2019 22:38
@JacopoMangiavacchi JacopoMangiavacchi changed the base branch from develop to jamangia/rectangle-detection April 15, 2019 22:39
@JacopoMangiavacchi
Copy link
Contributor Author

@wbreza unfortunately I started this from the Active Learning branch so if I re-target to develop it will contains all the commits from that branch too.

I think we have to first approve the AL PR. If this is urgent of course we could just copy the changes manually on a new branch but is this really so urgent ?

@JacopoMangiavacchi JacopoMangiavacchi force-pushed the jamangia/rectangle-detection branch from cb71bae to d6db509 Compare April 15, 2019 23:47
@wbreza wbreza force-pushed the jamangia/csv-export branch from 3b8d7fe to 976bf0b Compare April 24, 2019 00:56
@wbreza wbreza changed the base branch from jamangia/rectangle-detection to develop April 24, 2019 00:56
Copy link
Contributor

@tbarlow12 tbarlow12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wbreza wbreza merged commit bae8338 into develop Apr 26, 2019
@wbreza wbreza deleted the jamangia/csv-export branch April 26, 2019 22:36
wbreza pushed a commit that referenced this pull request Apr 29, 2019
Adds CSV export provider
elizabethhalper pushed a commit to riagarg/VoTT that referenced this pull request Aug 20, 2019
author Wallace Breza <wallace@breza.me> 1556573964 -0700
committer Elizabeth Halper <elhalper@microsoft.com> 1566326008 -0700

parent e4ee4cd
author Wallace Breza <wallace@breza.me> 1556573964 -0700
committer Elizabeth Halper <elhalper@microsoft.com> 1566326007 -0700

parent e4ee4cd
author Wallace Breza <wallace@breza.me> 1556573964 -0700
committer Elizabeth Halper <elhalper@microsoft.com> 1566326004 -0700

parent e4ee4cd
author Wallace Breza <wallace@breza.me> 1556573964 -0700
committer Elizabeth Halper <elhalper@microsoft.com> 1566325986 -0700

parent e4ee4cd
author Wallace Breza <wallace@breza.me> 1556573964 -0700
committer Elizabeth Halper <elhalper@microsoft.com> 1566325973 -0700

Release 2.1.0 (microsoft#790)

Updates package version and changelog for 2.1.0 release

changed line

refactor: Remove editor footer

Dummy commit to kick off build again

doc: Add bug & feature templates (microsoft#780)

Adds bug and feature github templates

Create CODE_OF_CONDUCT.md (microsoft#779)

Adds code of conduct

docs: updates to readme and changelog (microsoft#781)

Minor updates and corrections to the main readme and changelog.

fix: Fix display of tag color picker (microsoft#782)

Resolves issue of tag color picker not being shown on alt-click or color-click + edit button. Also adds several tests for increased test coverage of tagInput.tsx

feat: Add CSV Exporter (microsoft#757)

Adds CSV export provider

fix: change method for alloc string to buffer (microsoft#777)

String.length is not appropriate for calculating buffer size
when non-alphabet letter is included in content.
Change the method Buffer.alloc to Buffer.from as directed by the nodejs document.

fix: Updates backwards compat & fixes cntk export image bug (microsoft#789)

Fixes an issue where the images exported out of a video file were missing file extension for video projects.

Release 2.1.0 (microsoft#790)

Updates package version and changelog for 2.1.0 release

changed line

rebase upstream dev
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants