Skip to content
This repository has been archived by the owner on Dec 7, 2021. It is now read-only.

fix: Resolve UnhandledPromiseRejection in test #859

Merged
merged 1 commit into from
Aug 22, 2019
Merged

fix: Resolve UnhandledPromiseRejection in test #859

merged 1 commit into from
Aug 22, 2019

Conversation

tbarlow12
Copy link
Contributor

Create window.require function in tests that returns an electron object

Resolves #849

@tbarlow12 tbarlow12 force-pushed the tabarlow/unit-test-fix branch from ca84186 to f50f3a2 Compare August 20, 2019 20:28
elizabethhalper
elizabethhalper approved these changes Aug 20, 2019
View reviewed changes
Copy link
Collaborator

@elizabethhalper elizabethhalper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

wbreza
wbreza approved these changes Aug 22, 2019
View reviewed changes
Copy link
Contributor

@wbreza wbreza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! I remember seeing many of those warnings.

@tbarlow12 tbarlow12 merged commit add4680 into develop Aug 22, 2019
@tbarlow12 tbarlow12 deleted the tabarlow/unit-test-fix branch August 22, 2019 17:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elizabethhalper elizabethhalper elizabethhalper approved these changes

@wbreza wbreza wbreza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tbarlow12 @wbreza @elizabethhalper