Skip to content
This repository was archived by the owner on Dec 7, 2021. It is now read-only.

feat: add preview of filepaths in project settings #877

Merged
merged 1 commit into from
Aug 23, 2019

Conversation

luisamiranda
Copy link
Member

@luisamiranda luisamiranda commented Aug 23, 2019

Previously, in project settings, a user could only see the display name of the source and target connections, which might not have made clear which directory or storage account they were using. This adds the filepath or storageaccount and container name the to project settings dropdowns for source and target connection.

Resolves #792

Before:
project-settings
After:
project-settings-filepath-preview

@luisamiranda luisamiranda requested a review from wbreza August 23, 2019 20:27
@luisamiranda luisamiranda changed the title feat:add preview of filepaths in project settings WIP: add preview of filepaths in project settings Aug 23, 2019
@luisamiranda luisamiranda force-pushed the lumirand/792/show-file-locations-in-settings branch from 307a08c to 8b59a52 Compare August 23, 2019 21:39
@luisamiranda luisamiranda changed the title WIP: add preview of filepaths in project settings Feature: add preview of filepaths in project settings Aug 23, 2019
@luisamiranda luisamiranda changed the title Feature: add preview of filepaths in project settings feat: add preview of filepaths in project settings Aug 23, 2019
@mydiemho mydiemho closed this Aug 23, 2019
@mydiemho mydiemho reopened this Aug 23, 2019
Copy link
Contributor

@wbreza wbreza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luisamiranda luisamiranda merged commit 11c962b into develop Aug 23, 2019
@luisamiranda luisamiranda deleted the lumirand/792/show-file-locations-in-settings branch August 23, 2019 23:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants